-
Show log
Commit
-
Hash : 96733038
Author :
Date : 2024-09-12T16:10:53
Add back sdk_version entry to build targets ANGLE in android repo are failing to compile on some lunch targets: e.g. mainline_modules*, with sdk_version entry removed from build targets. For instance, after removing sdk_version for build target libEGL_angle, compilation failed with this error message: ``` error: external/angle/Android.bp:8174:1: dependency "libEGL_angle" of "ANGLE" missing variant: os:android,arch:arm64_armv8-a,sdk:sdk,link:shared available variants: os:android,arch:arm64_armv8-a,link:shared os:android,arch:arm_armv8-a,link:shared ``` Add back sdk_version entry to the build targets. END2END_TEST_TARGET needs to be disabled, because with sdk_version entry added to END2END_TEST_TARGET, the target failed to compile due to its' dependency libgmock is missing the variant: ``` error: external/angle/Android.bp:699:1: dependency "libgmock" of "libangle_end2end_tests__library" missing variant: os:android,arch:arm64_armv8-a,sdk:sdk,link:static ``` Bug: b/279980674 Change-Id: I96ea45b93519b84d72a70559d1ade9076ef9d955 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5857112 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
-
Files
- angle_deqp_bundle.py
- angle_deqp_test_merge.py
- angle_presubmit_utils.py
- angle_presubmit_utils_unittest.py
- angle_trace_bundle.py
- apply_clang_format_on_all_sources.py
- bootstrap.py
- code_generation_hashes/
- egl_angle_ext.xml
- entry_point_packed_egl_enums.json
- entry_point_packed_gl_enums.json
- export_targets.py
- extension_data/
- file_exists.py
- gen_angle_gn_info_json.py
- gen_gl_enum_utils.py
- gen_interpreter_utils.py
- gen_proc_table.py
- gen_vk_gl_cts_build.py
- generate_android_bp.py
- generate_entry_points.py
- generate_loader.py
- generate_stats.py
- gl_angle_ext.xml
- install_target.py
- process_angle_perf_results.py
- registry_xml.py
- roll_aosp.sh
- roll_chromium_deps.py
- run_code_generation.py
- tracegz.py
- trigger.bat
- trigger.py
- update_chrome_angle.py
- update_extension_data.py
- vk_mandatory_format_support_capture_to_json.js
- winappsdk_setup.py
