• Show log

    Commit

  • Hash : eaffa034
    Author : Yuxin Hu
    Date : 2024-09-24T20:56:04

    Revert "Vulkan: Consolidate colorspace override states"
    
    This reverts commit bffcd235ba6c031603d798daaa98f1cf9a3f3e46.
    
    Reason for revert: Breaks Android test `org.skia.skqp.SkQPRunner#UnitTest_DMSAA_dst_read`. Details: 
     https://b.corp.google.com/issues/369388539.
    
    Original change's description:
    > Vulkan: Consolidate colorspace override states
    >
    > ColorspaceState struct is now used to cache colorspace related states
    > and used to determine the colorspace of Vulkan image views.
    > ImageViewHelper methods are called during initialization and when
    > colorspace related states are toggled dynamically which in turn process
    > these states and determine the final read and write colorspaces.
    >
    > We can now fully support rendering to EGLImages, with colorspace
    > overrides, via texture or renderbuffer EGLImage targets
    >
    > Bug: angleproject:40644776
    > Tests: ImageTest*Colorspace*Vulkan
    >        MultithreadingTestES3.SharedSrgbTextureMultipleContexts*Vulkan
    >        SRGBTextureTest.SRGB*TextureParameter*Vulkan
    >        SRGBTextureTestES3.SRGBDecodeTexelFetch*Vulkan
    >        ReadPixelsPBOTest.SrgbUnorm*Vulkan
    > Change-Id: I1cc2b5bd834b519b83deab4d80a2fcaabeb271d6
    > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5841290
    > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
    > Reviewed-by: Charlie Lao <cclao@google.com>
    > Commit-Queue: mohan maiya <m.maiya@samsung.com>
    
    Bug: angleproject:40644776
    Change-Id: I5bf6cf2ed0c8ec22fc02d8c3da92673ee85fe002
    Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5888506
    Reviewed-by: Yuxin Hu <yuxinhu@google.com>
    Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
    Commit-Queue: Yuxin Hu <yuxinhu@google.com>
    

  • Properties

  • Git HTTP https://git.kmx.io/kc3-lang/angle.git
    Git SSH git@git.kmx.io:kc3-lang/angle.git
    Public access ? public
    Description

    A conformant OpenGL ES implementation for Windows, Mac, Linux, iOS and Android.

    Homepage

    Github

    Users
    thodg_m kc3_lang_org thodg_w www_kmx_io thodg thodg_l
    Tags