-
Show log
Commit
-
Hash : f0e89be6
Author :
Date : 2017-11-08T14:00:32
Use packed enums for the texture types and targets, part 1 In OpenGL there are two enum "sets" used by the API that are very similar: texture types (or bind point) and texture targets. They only differ in that texture types have GL_TEXTURE_CUBEMAP and target have GL_TEXTURE_CUBEMAP_[POSITIVE|NEGATIVE]_[X|Y|Z]. This is a problem because in ANGLE we use GLenum to pass around both types of data, making it difficult to know which of type and target a variable is. In addition these enums are placed somewhat randomly in the space of OpenGL enums, making it slow to have a mapping from texture types to some data. Such a mapping is in hot-code with gl::State::mTextures. This commit stack makes the texture types and target enums be translated to internal packed enums right at the OpenGL entry point and used throughout ANGLE to have type safety and performance gains. This is the first of two commit which does the refactor for all of the validation and stops inside gl::Context. This was the best place to split patches without having many conversions from packed enums to GL enums. BUG=angleproject:2169 Change-Id: Ib43da7e71c253bd9fe210fb0ec0de61bc286e6d3 Reviewed-on: https://chromium-review.googlesource.com/758835 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
-
Files
- bmp_to_nv12.py
- bootstrap.py
- entry_point_packed_gl_enums.json
- generate_entry_points.py
- generate_new_renderer.py
- generate_vulkan_layers_json.py
- gl.xml
- msvs_projects.py
- perf_test_runner.py
- remove_file_if_exists.py
- run_code_generation.py
- update_canary_angle.py
- vk_mandatory_format_support_capture_to_json.js
