• Show log

    Commit

  • Hash : f9729598
    Author : Jamie Madill
    Date : 2022-04-28T16:36:50

    Revert "Fix commit ID gathering on Android builds."
    
    This reverts commit 1835e5d895f7f75435c2eddf3f87a88ef534c237.
    
    Reason for revert: Breaks Skia integration in linkImpl.
    
    Original change's description:
    > Fix commit ID gathering on Android builds.
    >
    > Android infra does not store the .git directory alongside the
    > checked out code, instead using a gitdir directive to point
    > elsewhere. This caused the commit_id script to fail, which
    > could cause issues with disk-backed program caches on updates
    > when the serialization format changes.
    >
    > This CL also makes it a build failure to fail to get the commit id,
    > and removes the ANGLE_DISABLE_PROGRAM_BINARY_LOAD fallback (which
    > was broken anyway due to not being used anywhere).
    >
    > Bug: b/206109660
    > Test: Run script on Android infra, verify hash is gathered properly.
    > Change-Id: Ie28dc9278b6fbd3dd4f09232c0a88d602fca6980
    > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3604710
    > Commit-Queue: Doug Horn <doughorn@google.com>
    > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
    > Reviewed-by: Jamie Madill <jmadill@chromium.org>
    
    Bug: b/206109660
    Change-Id: I64ac0831a46b9e1ff2e2738624650d67d0609f3c
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3615009
    Commit-Queue: Jamie Madill <jmadill@chromium.org>
    Auto-Submit: Jamie Madill <jmadill@chromium.org>
    Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
    Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
    Reviewed-by: Doug Horn <doughorn@google.com>
    

  • Properties

  • Git HTTP https://git.kmx.io/kc3-lang/angle.git
    Git SSH git@git.kmx.io:kc3-lang/angle.git
    Public access ? public
    Description

    A conformant OpenGL ES implementation for Windows, Mac, Linux, iOS and Android.

    Homepage

    Github

    Users
    thodg_m kc3_lang_org thodg_w www_kmx_io thodg thodg_l
    Tags