• Show log

    Commit

  • Hash : fb948319
    Author : Kenneth Russell
    Date : 2023-01-31T18:16:41

    Revert "Metal: rewrite default uniforms and uniform blocks"
    
    This reverts commit b8bfe6f6c04a6cf4fac81f0363ad23a0b92b22f2.
    
    Reason for revert: potential cause of crashes/timeouts in crbug.com/1411755
    
    Original change's description:
    > Metal: rewrite default uniforms and uniform blocks
    >
    > Instead of rewriting uniforms in shaders to match std140 layout,
    > re-pack incoming uniform blocks' std140 packed variables to match
    > Metal's layout.
    >
    > This change intorduces a new BlockLayoutEncoder for Metal types
    > The block encoder handles packing typically larger GL types (bools)
    > into smaller types, and adding support for more compressed matrix types.
    >
    > Since we no longer need to do shader-time packing and unpacking of data
    > from std140 padded structs, complicated shader transformations have been
    > removed. This patch greatly reduces register pressure, especially when
    > working with shaders with arrays of previously expanded types. (Vec3's)
    >
    > Bug: angleproject:7137
    > Change-Id: Icd1da8c7a383f3354313a58618fc1bf6656726b4
    > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3733524
    > Commit-Queue: Kyle Piddington <kpiddington@apple.com>
    > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
    > Reviewed-by: Kenneth Russell <kbr@chromium.org>
    
    Bug: angleproject:7137
    Bug: chromium:1411755
    Change-Id: I1b6a62d7eb542c3e7ef4b84858ab2683abb66f8b
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4210448
    Commit-Queue: Kenneth Russell <kbr@chromium.org>
    Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
    

  • Properties

  • Git HTTP https://git.kmx.io/kc3-lang/angle.git
    Git SSH git@git.kmx.io:kc3-lang/angle.git
    Public access ? public
    Description

    A conformant OpenGL ES implementation for Windows, Mac, Linux, iOS and Android.

    Homepage

    Github

    Users
    kc3_lang_org thodg_w www_kmx_io thodg_l thodg thodg_m
    Tags