Commit 38b349c41b2456d533cf60fb966a32d1a665dc8f

Alexei Podtelezhnikov 2021-10-18T20:35:28

[pcf] Zero out the allocated properties. Fallout reported as https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=40033 * src/pcf/pcfread.c (pcf_get_properties): Use FT_NEW_ARRAY and zero out `properties` in case of failure.

1
2
3
4
5
6
7
8
9
10
11
12
13
14
diff --git a/src/pcf/pcfread.c b/src/pcf/pcfread.c
index 4c6823a..e60a0a5 100644
--- a/src/pcf/pcfread.c
+++ b/src/pcf/pcfread.c
@@ -613,7 +613,8 @@ THE SOFTWARE.
 
     strings[string_size] = '\0';
 
-    if ( FT_QNEW_ARRAY( properties, nprops ) )
+    /* zero out in case of failure */
+    if ( FT_NEW_ARRAY( properties, nprops ) )
       goto Bail;
 
     face->properties = properties;