Commit 559727d5196633c735298fe16f7f1e835fe94ef7

Werner Lemberg 2015-02-25T06:55:00

Change dimension fields in `FTC_ImageTypeRec' to unsigned type. This doesn't break ABI. * include/ftcache.h (FTC_ImageTypeRec): Use unsigned types for `width' and `height'. * docs/CHANGES: Document it.

diff --git a/ChangeLog b/ChangeLog
index e986e27..0295286 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,16 @@
 2015-02-25  Werner Lemberg  <wl@gnu.org>
 
+	Change dimension fields in `FTC_ImageTypeRec' to unsigned type.
+
+	This doesn't break ABI.
+
+	* include/ftcache.h (FTC_ImageTypeRec): Use unsigned types for
+	`width' and `height'.
+
+	* docs/CHANGES: Document it.
+
+2015-02-25  Werner Lemberg  <wl@gnu.org>
+
 	[cache] Don't use `labs'.
 
 	This is the only place in FreeType where this function was used.
diff --git a/docs/CHANGES b/docs/CHANGES
index 3a0dcd2..352563d 100644
--- a/docs/CHANGES
+++ b/docs/CHANGES
@@ -1,5 +1,5 @@
 
-CHANGES BETWEEN 2.5.5 and 2.5.6
+CHANGES BETWEEN 2.5.5 and 2.6
 
   II. IMPORTANT CHANGES
 
@@ -22,6 +22,17 @@ CHANGES BETWEEN 2.5.5 and 2.5.6
       used from multiple threads at the same time.
 
 
+  III. MISCELLANEOUS
+
+    - Some  fields  in  the  `FTC_ImageTypeRec'  structure  have  been
+      changed from signed to unsigned  type, which better reflects the
+      actual usage.  It is also an additional means to protect against
+      malformed input.
+
+      This  change doesn't  break  the ABI;  however,  it might  cause
+      compiler warnings.
+
+
 ======================================================================
 
 CHANGES BETWEEN 2.5.4 and 2.5.5
diff --git a/include/ftcache.h b/include/ftcache.h
index c1a7555..68525bb 100644
--- a/include/ftcache.h
+++ b/include/ftcache.h
@@ -667,8 +667,8 @@ FT_BEGIN_HEADER
   typedef struct  FTC_ImageTypeRec_
   {
     FTC_FaceID  face_id;
-    FT_Int      width;
-    FT_Int      height;
+    FT_UInt     width;
+    FT_UInt     height;
     FT_Int32    flags;
 
   } FTC_ImageTypeRec;