Log

Author Commit Date CI Message
Azat Khuzhin 3c1f58f5 2015-11-05T17:45:09 be: introduce bufferevent_generic_adj_existing_timeouts_() And use it in openssl/sock layers to avoid copy-pasting it's variants.
Azat Khuzhin f4b6284b 2015-11-05T17:40:25 be_openssl: don't add events during bev creation (like be_sock) Using the following examples you can get changes between be_openssl and be_sock: $ function diff_addr() { eval diff -u $(printf "<(strip_addr %s) " "$@") } $ function strip_addr() { sed 's/0x[a-zA-Z0-9]*/0xFFFF/g' "$@" } $ EVENT_DEBUG_LOGGING_ALL= regress --verbose --no-fork +http/https_connection_retry 2> /tmp/https-retry.log >&2 $ EVENT_DEBUG_LOGGING_ALL= regress --verbose --no-fork +http/connection_retry 2> /tmp/http-retry.log >&2 $ diff_addr /tmp/http-retry.log /tmp/https-retry.log
Azat Khuzhin 3160716f 2015-11-06T10:13:13 test/regress: fix ssl-less builds (need to make this prettier) CI: https://travis-ci.org/libevent/libevent/jobs/89590839
Azat Khuzhin a96b73b9 2015-11-05T17:35:17 be: add_event: use evutil_timerisset()
Azat Khuzhin 45a284ac 2015-11-06T09:45:55 Merge branch 'https-coverage-v6' This patchset adds some basic tests to cover some https cases: $ regress +http/https_.. http/https_basic: [forking] OK http/https_simple: [forking] OK http/https_simple_dirty: [forking] OK http/https_incomplete: [forking] OK http/https_incomplete_timeout: [forking] OK http/https_connection_retry: [forking] OK http/https_connection_retry_conn_address: [forking] OK 7 tests ok. (0 skipped) But there are some leaks in http regression tests (like init_ssl() and others), must be fixed by using custom setup routine. * https-coverage-v6: test/http: allow dirty shutdown for ssl to fix https_incomplete test/http: https basic test/http: incomplete{,_timeout} for https test/http: add simplest test for http/https/https_dirty_shutdown test/http: https: retry coverage test/http: https server support (plus some helpers) test/http: more sanity checks test/ssl: export getkey()/getcert()/get_ssl_ctx()/init_ssl() for https
Azat Khuzhin 1ede3262 2015-11-06T02:24:28 test/http: allow dirty shutdown for ssl to fix https_incomplete
Azat Khuzhin 59714b46 2015-11-05T19:12:58 test/http: https basic
Azat Khuzhin 615490d0 2015-11-05T19:08:30 test/http: incomplete{,_timeout} for https
Azat Khuzhin 93b19dc5 2015-11-05T12:39:35 test/http: add simplest test for http/https/https_dirty_shutdown There is "basic" before, but it uses bufferevent's for creating requests for http layer, while this test uses http layer for client requests too.
Azat Khuzhin 7c2d24ae 2015-11-05T11:17:07 test/http: https: retry coverage
Azat Khuzhin a7088ad0 2015-11-05T10:58:41 test/http: https server support (plus some helpers) TODO: - check BEV_OPT_DEFER_CALLBACKS separately
Azat Khuzhin a27c53c5 2015-11-05T11:18:32 test/http: more sanity checks
Azat Khuzhin 0c4c387c 2015-11-05T10:34:18 test/ssl: export getkey()/getcert()/get_ssl_ctx()/init_ssl() for https
Bill Vaughan f45d39d1 2015-07-24T05:40:59 Fix lock leak in be_pair_flush() if flush type is BEV_NORMAL Fixes: bufferevent/bufferevent_pair_flush_normal $ regress --no-fork bufferevent/bufferevent_pair_flush_normal bufferevent/bufferevent_pair_flush_normal: FAIL ../test/regress_bufferevent.c:181: assert(bufferevent_pair_get_partner(bev1) == NULL): 0x177fa20 vs (nil) [bufferevent_pair_flush_normal FAILED] Fixes #266
Azat Khuzhin ad52602f 2015-10-30T18:38:21 test/regress_be: basic coverage bufferevent_flush() for pair/sock layers Refs #266
Azat Khuzhin f8081afc 2015-10-30T18:37:44 test/regress_be: socket_filter_inactive: check bufferevent after creation Fixes: ../test/regress_bufferevent.c: In function ‘test_bufferevent_socket_filter_inactive’: ../test/regress_bufferevent.c:1180:1: warning: label ‘end’ defined but not used [-Wunused-label] end:
Azat Khuzhin 7c8d0152 2015-10-30T13:34:30 Free event queues even for recursive finalizers For finalizers we can register yet another finalizer out from finalizer, and iff finalizer will be in active_later_queue we can add finalizer to activequeues, and we will have events in activequeues after event_base_free() returns, which is not what we want (we even have an assertion for this). A simple case is bufferevent with underlying (i.e. filters) in inactive queue. Fixes: regress bufferevent/bufferevent_socket_filter_inactive
Azat Khuzhin 337684b8 2015-10-09T01:40:02 test/regress_be: cover finalizers from inactive to active queue Right now this will fail with the next assertion: $ regress --no-fork --verbose bufferevent/bufferevent_socket_filter_inactive bufferevent/bufferevent_socket_filter_inactive: [err] ../event.c:862: Assertion TAILQ_EMPTY(&base->activequeues[i]) failed in event_base_free_ Aborted
Azat Khuzhin 575ff678 2015-10-30T01:34:40 buffer_compat: fix comment -- we have EVBUFFER_EOL_ANY not EOL_STYLE_ANY
Azat Khuzhin d8fd4c07 2015-10-09T01:53:40 test/regress_buffer: fix clang compilation warnings ../test/regress_buffer.c:201:12: warning: logical not is only applied to the left hand side of this comparison [-Wlogical-not-parentheses] tt_assert(!memcmp((char*)EVBUFFER_DATA(evb), "1/hello", 7) != 0);
Azat Khuzhin cd422e09 2015-10-09T01:50:05 test/regress_http: fix compilation warnings (-Wmissing-field-initializers)
Azat Khuzhin f55db985 2015-10-09T01:43:52 test/regress_dns: fix compilation warnings (-Wmissing-field-initializers/for) I don't have an error for loop because gcc5 have --std=gnu11 by default. We need some options-consistency for all versions/compilers and build systems to avoid such patches. Fixes: https://travis-ci.org/libevent/libevent/jobs/84403473 Fixes: https://travis-ci.org/libevent/libevent/builds/84403463
Azat Khuzhin d4bdd0c8 2015-10-09T01:17:51 Merge branch 'evdns-randomization' * evdns-randomization: evdns: fix randomize-case by make case-insensitive as required tests/regress_dns: cover that randomize-case works case-insensitive evnds: inline TEST_NAME macro to make debuggin easier Fixes #288
Azat Khuzhin 9c238deb 2015-10-09T01:13:08 evdns: fix randomize-case by make case-insensitive as required Interesting that this wasn't found by regression tests since they respond with that SoME-rAndDom-CaSe domains, and no case-insensitive mode is required during comparing response from the server and request. Fixes #288 Covered-by: regress dns/search_lower
Azat Khuzhin 1e8bfbc6 2015-10-09T01:11:09 tests/regress_dns: cover that randomize-case works case-insensitive Regression-for: #288
Azat Khuzhin 0c615f4e 2015-10-09T00:03:47 evnds: inline TEST_NAME macro to make debuggin easier
Thomas Bernard 9f02a445 2015-10-05T12:37:41 make test/regress_ssl.c compile without warnings
Azat Khuzhin e4556fcd 2015-10-04T03:49:38 evthread: fix evthread_setup_global_lock_() for debug-lock with a real-lock case Sample bt: (gdb) bt #0 0x00000000004a95d2 in evthread_setup_global_lock_ (lock_=0x0, locktype=0, enable_locks=1) #1 0x00000000004afbc7 in evsig_global_setup_locks_ (enable_locks=1) at signal.c:475 #2 0x00000000004a5da8 in event_global_setup_locks_ (enable_locks=1) at event.c:3838 #3 0x00000000004a8983 in evthread_set_lock_callbacks (cbs=0x7fffffffdde0) at evthread.c:129 #4 0x0000000000445a8f in use_lock_unlock_profiler () at regress_bufferevent.c:306 #5 0x0000000000445af2 in test_bufferevent_pair_release_lock (arg=0x70e710) at regress_bufferevent.c:327 #6 0x000000000048c9a8 in testcase_run_bare_ (testcase=0x6fdc10 <bufferevent_testcases+80>) at tinytest.c:105 #7 0x000000000048cc8a in testcase_run_one (group=0x6ff270 <testgroups+112>, testcase=0x6fdc10 <bufferevent_testcases+80>) at tinytest.c:252 #8 0x000000000048d5c9 in tinytest_main (c=3, v=0x7fffffffe008, groups=0x6ff200 <testgroups>) at tinytest.c:434 #9 0x000000000047a08f in main (argc=3, argv=0x7fffffffe008) at regress_main.c:459 Found-with: regress bufferevent/bufferevent_pair_release_lock (-DEVENT__DISABLE_DEBUG_MODE=ON)
Azat Khuzhin f337296a 2015-10-04T03:35:43 Fix checking for make_base_notifiable() Fixes: a068f2e5 ("event_debug_created_threadable_ctx_: fix compilation without debug mode") Found-after: 3e56da23 ("travis: add builds without debug mode into matrix")
Azat Khuzhin 8240379a 2015-10-04T03:19:12 test/regress_be: drop debug __asm__(int3) to fix arm build Closes #284
Azat Khuzhin 3e56da23 2015-09-30T11:13:44 travis: add builds without debug mode into matrix To cover compilation with this flag, since brew for example uses it by default.
Azat Khuzhin a068f2e5 2015-09-29T20:36:39 event_debug_created_threadable_ctx_: fix compilation without debug mode The following command failed before: $ ./configure --disable-debug-mode Fixes: dcfb19a27b7760299bc9e7291c9abd88c59fd91a ("Debug mode option to error on evthread init AFTER other event calls.")
Azat Khuzhin 3f749e93 2015-09-10T13:38:58 test: fix bufferevent/bufferevent_pair_release_lock in debug mode After this test had been fixed for freebsd the debug build was broken because we can't call evthread_set_lock_callbacks() when something already initialized, and we can't call event_base_free() (in kqueue case) when it is initialized, because of "held_by", but this only playing role during freeing lock profiler so reset lock callbacks there before and this will fix both. Fixes: 79f9ace4ae8a259a5cf1b4ff3869078b60ff16a1 ("test: fix bufferevent/bufferevent_pair_release_lock for freebsd") P.S. after this patch 'make verify' finishes without errors on freebsd.
Azat Khuzhin 79f9ace4 2015-09-10T12:39:20 test: fix bufferevent/bufferevent_pair_release_lock for freebsd On FreeBSD with kqueue there is a call to evthread_debug_lock_mark_unlocked() during event_base_free(), that will fail with an assert because of unmatched "held_by", fix this by reseting lock callbacks to NULL before event_base_free(). Trace: bufferevent/bufferevent_pair_release_lock: [warn] Trying to disable lock functions after they have been set up will probaby not work. [warn] Trying to disable lock functions after they have been set up will probaby not work. FAIL libevent/test/regress_bufferevent.c:259: lock: lock error[err] libevent/evthread.c:277: Assertion lock->held_by == me failed in evthread_debug_lock_mark_unlocked [New Thread 802006400 (LWP 100070/regress)] Program received signal SIGABRT, Aborted. [Switching to Thread 802006400 (LWP 100070/regress)] 0x000000080167d6ca in thr_kill () from /lib/libc.so.7 (gdb) bt #0 0x000000080167d6ca in thr_kill () from /lib/libc.so.7 #1 0x0000000801752149 in abort () from /lib/libc.so.7 #2 0x00000000004dff44 in event_exit (errcode=-559030611) at libevent/log.c:105 #3 0x00000000004e053c in event_errx (eval=-559030611, fmt=0x5182cc "%s:%d: Assertion %s failed in %s") at libevent/log.c:162 #4 0x00000000004d9954 in evthread_debug_lock_mark_unlocked (mode=0, lock=0x802017060) at libevent/evthread.c:277 #5 0x00000000004d909a in debug_lock_unlock (mode=0, lock_=0x802017060) at libevent/evthread.c:290 #6 0x00000000004e132c in evsig_dealloc_ (base=0x80201e300) at libevent/signal.c:434 #7 0x00000000004e36c1 in kq_dealloc (base=0x80201e300) at libevent/kqueue.c:435 #8 0x00000000004c9a44 in event_base_free_ (base=0x80201e300, run_finalizers=1) at libevent/event.c:855 #9 0x00000000004c931a in event_base_free (base=0x0) at libevent/event.c:887 #10 0x0000000000452657 in lock_unlock_free_thread_cbs () at libevent/test/regress_bufferevent.c:279 #11 0x0000000000452621 in free_lock_unlock_profiler (data=0x8020170a0) at libevent/test/regress_bufferevent.c:317 #12 0x000000000044bc8f in test_bufferevent_pair_release_lock (arg=0x8020170a0) at libevent/test/regress_bufferevent.c:334 #13 0x00000000004b2288 in testcase_run_bare_ (testcase=0x737660) at libevent/test/tinytest.c:105 #14 0x00000000004b1e72 in testcase_run_one (group=0x738c90, testcase=0x737660) at libevent/test/tinytest.c:252 #15 0x00000000004b2930 in tinytest_main (c=3, v=0x7fffffffead0, groups=0x738c20) at libevent/test/tinytest.c:434 #16 0x00000000004982fe in main (argc=3, argv=0x7fffffffead0) at libevent/test/regress_main.c:459 (gdb) f 4 #4 0x00000000004d9954 in evthread_debug_lock_mark_unlocked (mode=0, lock=0x802017060) at libevent/evthread.c:277 277 EVUTIL_ASSERT(lock->held_by == me); Current language: auto; currently minimal (gdb) p lock $1 = (struct debug_lock *) 0x802017060 (gdb) p lock->held_by $2 = 0 (gdb) p me $3 = 34393318400
Azat Khuzhin 484d0db0 2015-09-10T12:17:39 Merge branch 'cloudabi-fixes-pr-278' Rebased version of #278 * cloudabi-fixes-pr-278: Assume that ke_udata is an integer type on CloudABI. Add missing include of <netinet/in.h>. Include <sys/ioctl.h>, <sys/resource.h> and <sys/wait.h> optionally.
Ed Schouten 5602e451 2015-08-25T23:31:07 Assume that ke_udata is an integer type on CloudABI.
Ed Schouten b2c68bc2 2015-08-26T09:45:23 Add missing include of <netinet/in.h>. POSIX states that sockaddr_in6 should be declared in <netinet/in.h>. By including this header, the code now builds on FreeBSD and CloudABI.
Ed Schouten c1404b56 2015-08-26T10:06:09 Include <sys/ioctl.h>, <sys/resource.h> and <sys/wait.h> optionally. Though CloudABI implements a very large part of POSIX, it does not provide these header files, for the reason that there is no raw device access, no resource limiting and no access to the global process table through wait(). It looks like these header files are not actually needed in theory. There don't seem to be any constructs in these source files that use these features, but I suspect they might still be required on some systems.
Sebastian Hahn bfcedee0 2015-08-13T15:04:14 Add a prototype for event_disable_debug_mode() Exporting this function seems rather useless, as debugging mode has to be enabled early and calling this function doesn't allow it to get toggled back on later. Fixes a compile warning when using clang 3.6. Fixes #271 Fixes #224
Azat Khuzhin 714fc705 2015-09-10T11:46:17 http: export evhttp_connection_set_family() Fixes #176
Azat Khuzhin a0f308da 2015-09-10T11:18:20 test/regress_be: bufferevent_enable() shouldn't call eventcb by it's own It must enter the event loop regardless BEV_OPT_DEFER_CALLBACKS, to avoid potential errors with subsequent connect(), you will find more info in #43, since this is a regression for it.
Azat Khuzhin 37dc9e0e 2015-09-10T01:17:50 test/regress_be: introduce fake_listener_create()
Azat Khuzhin 9b16d9b8 2015-09-09T19:31:48 Merge branch 'evhttp-request-own-fixes' I hope that I validated all places where evhttp_request_free() called and ownership of request can be belong to user-specific code. * evhttp-request-own-fixes: http: fix evhttp_request_own() by checking EVHTTP_USER_OWNED in more cases test/regress_http: cover evhttp_request_own() Fixes #68
Azat Khuzhin b0d3964f 2015-09-09T19:21:51 http: fix evhttp_request_own() by checking EVHTTP_USER_OWNED in more cases Suggested-by: @ellzey Fixes: http/request_own Fixes: #68
Azat Khuzhin 6f6fa0d2 2015-09-09T19:15:18 test/regress_http: cover evhttp_request_own()
Azat Khuzhin 2cba6779 2015-09-09T18:08:02 Merge branch 'http-server-EOF-at-read-v3' This patchset fixes an issue with detecting EOF in http server and add some regression tests to make sure that we will not break anything. * http-server-EOF-at-read-v3: http: fix detecting EOF without write test/regress_http: cover write during read test/regress_http: verify that closecb will be called without multiple write Closes #78 Link: http://stackoverflow.com/questions/18743948/libevent2-http-server-how-to-detect-client-close/18776728?noredirect=1#18776728
Azat Khuzhin 7ed02ac1 2015-09-08T16:40:55 http: fix detecting EOF without write Before this patch http server don't knows when client disconnected until it will try to write to it, IOW to detect is client still alive you need to write something to client socket, however it is not convenient since it requires to store all clients somewhere and poll them periodically, and I don't see any regressions if we will leave EV_READ always (like libevhtp do), since we already reset read callback in evhttp_write_buffer() (see http/write_during_read). Also since we don't disable EV_READ anymore we don't need some enable EV_READ, so we will reduce number of epoll_ctl() calls. Covered-by: http/terminate_chunked_oneshot Covered-by: http/write_during_read Fixes: #78
Azat Khuzhin 3d15aeb4 2015-09-09T17:45:44 test/regress_http: cover write during read This is the regression for evhttp_write_buffer() where we reset readcb to avoid illegal state: http/write_during_read: [err] evhttp_read_cb: illegal connection state 7 If you will comment that this test will fail.
Azat Khuzhin 4be6c70b 2015-09-08T15:44:13 test/regress_http: verify that closecb will be called without multiple write And now this works incorrect, i.e. http layer will not detect EOF until another write. Reported-in: #78
Azat Khuzhin cf2cf2a0 2015-09-02T11:51:00 test: run regress with EVENT_DEBUG_MODE=1 and without This could show some bugs like "event_assign called on an already added event", and some others that debugging mode could track.
Azat Khuzhin 6ea66554 2015-09-02T11:55:14 test/regress: fix bufferevent_pair_release_lock with EVENT_DEBUG_MODE Before this patch you will see next error: $ EVENT_DEBUG_MODE= regress --no-fork bufferevent/bufferevent_pair_release_lock bufferevent/bufferevent_pair_release_lock: [err] evthread initialization must be called BEFORE anything else!
Azat Khuzhin 4637aa88 2015-09-02T19:34:52 sample/https-client: add -timeout option
Azat Khuzhin 620aae96 2015-09-02T19:34:15 Merge branch 'be-openssl-drop-fd_is_set-v4' This must fix some issues with bufferevent openssl layer + some cleanups. * be-openssl-drop-fd_is_set-v4: be_openssl: don't use *_auto() in do_handshake() we can't have fd == -1 there be_openssl: don't call set_open_callbacks() if fd == -1 be_openssl: introduce be_openssl_auto_fd() helper be_openssl: introduce set_open_callbacks_auto() be_openssl: get rid off hackish "fd_is_set", to fix some corner cases
Azat Khuzhin 877280db 2015-09-02T15:09:24 be_openssl: don't use *_auto() in do_handshake() we can't have fd == -1 there
Azat Khuzhin e8a2da96 2015-09-02T14:19:16 be_openssl: don't call set_open_callbacks() if fd == -1 This must be illegal, firstly we must do set_do handshake and only after this we could read/write.
Azat Khuzhin 2a8a7112 2015-09-02T12:42:29 be_openssl: introduce be_openssl_auto_fd() helper
Azat Khuzhin 510da71f 2015-09-02T12:40:26 be_openssl: introduce set_open_callbacks_auto() This will split cases when we need to extract fd (cases when we have fd==-1 passed to set_open_callbacks()), and cases when we mustn't have to do this -- SET_FD via be_openssl_ctrl().
Azat Khuzhin 40b03798 2015-08-22T21:38:18 be_openssl: get rid off hackish "fd_is_set", to fix some corner cases This patch is a cleanup and a bug fix, it drops ```fd_is_set``` flag, and replace it with some checks to event_initialized(), and now we will not call event_assign() on already added event, plus we will delete event when we really have to (this patch fixes the case when server is down, IOW before this patch we will not call event_del() because ```fd_is_set``` was reset to 0) and this will fix some issues with retries in http layer for ssl. Reported-in: #258 Fixes: regress ssl/bufferevent_socketpair_timeout Fixes: regress ssl/bufferevent_socketpair_timeout_freed_fd
Azat Khuzhin af85ecfc 2015-09-02T19:18:08 Merge branch 'test-regress-be-openssl-v2' This patchset is a bunch of regression tests for bufferevent openssl layer, some of them already show some bugs, that bugs will be fixed in the next patches. * test-regress-be-openssl-v2: test/regress_ssl: check events fd/pending after timeout triggered test/regress_ssl: cover case when server didn't up (failed with timeout) test/regress_ssl: covert that we can't change fd with underlying test/regress_ssl: cover that events (read/write) at finish not pending test/regress_ssl: cover fd manipulations test/regress_ssl: convert open_ssl_bufevs() to mask test/regress_ssl: convert client/server to mask too test/regress_ssl: cover "allow_dirty_shutdown" test/regress_ssl: convert regress_bufferevent_openssl() to bitmask
Azat Khuzhin cdafdf01 2015-09-02T17:49:41 test/regress_ssl: check events fd/pending after timeout triggered In this case client can't connect to server, and this bring to the front some bugs with assigning on already added events (because of ```fd_is_set``` stuff), for more info see #258, since this is the reproducible for it.
Azat Khuzhin 74845f11 2015-09-02T17:36:20 test/regress_ssl: cover case when server didn't up (failed with timeout)
Azat Khuzhin df507afa 2015-09-02T17:17:43 test/regress_ssl: covert that we can't change fd with underlying
Azat Khuzhin 762edb46 2015-09-02T17:06:51 test/regress_ssl: cover that events (read/write) at finish not pending
Azat Khuzhin b78a8297 2015-09-02T12:35:51 test/regress_ssl: cover fd manipulations
Azat Khuzhin 46bba731 2015-09-02T12:31:15 test/regress_ssl: convert open_ssl_bufevs() to mask
Azat Khuzhin 34559913 2015-09-02T12:26:40 test/regress_ssl: convert client/server to mask too
Azat Khuzhin 04303273 2015-09-02T11:34:13 test/regress_ssl: cover "allow_dirty_shutdown"
Azat Khuzhin 342e116f 2015-09-02T11:22:43 test/regress_ssl: convert regress_bufferevent_openssl() to bitmask
Ed Schouten ce1776c9 2015-08-25T15:29:37 Test against SO_REUSEADDR (along with _WIN32). This makes the code build on other systems that also don't have SO_REUSEADDR without requiring special code. [ azat: partially revert WIN32 check since SO_REUSEADDR on win32 differs from unix semantics. ] Closes #275
Azat Khuzhin 25e56fdb 2015-08-25T17:01:42 tests/regress_ssl: drop duplicated assert
Christopher Wiley 2828bdb9 2015-07-24T08:42:06 Always define missing TAILQ functions from sys/queue.h On both Android and Ubuntu machines, TAILQ_END is not defined. This header also does not seem to be part of standard BSD sys/queue.h Fix this by always defining missing TAILQ_ macros rather than conditioning on a particular macro. Fixes #267
Ed Schouten fd36647a 2015-08-25T15:24:39 Don't use BSD u_* types. These types are not part of POSIX. As we only use them in a small number of places, we'd better replace them by C standard types. This makes a larger part of the code build for CloudABI.
Ed Schouten 193c7de5 2015-08-25T15:32:25 Remove BSD-ism: TIMEVAL_TO_TIMESPEC(). Systems like CloudABI implement kqueue() but do not provide the BSD-specific TIMEVAL_TO_TIMESPEC() macro. Change the code to perform this manually, as it is not hard to do this conversion.
Azat Khuzhin c2122919 2015-08-19T23:27:51 be: include all variations of headers for sockaddr_in6 struct Fixes: c42bc6b279fd7cd4bc9b04c86a12e2ec5512cce1 ("be: fix sockaddr_in6 type definition for win32") Fixes: e04555155816306f23829a15b747664a57330c28 ("Merge branch 'reuse-conn_address-on-retry-v11'") CI: https://ci.appveyor.com/project/nmathewson/libevent/build/2.1.5.109 Tested: manually
Azat Khuzhin dfad1a46 2015-08-19T23:00:49 http: eliminate warning about "socklen" in evhttp_connection_connect_()
Azat Khuzhin c42bc6b2 2015-08-19T22:52:22 be: fix sockaddr_in6 type definition for win32 bufferevent-internal.h:217:23: error: field 'in6' has incomplete type struct sockaddr_in6 in6; ^ CI: https://ci.appveyor.com/project/nmathewson/libevent/build/2.1.5.108
Azat Khuzhin f3d7ff5d 2015-08-19T13:22:49 sample/https-client: don't try to free uninitialized SSL sample/https-client.c:459:3: warning: ‘ssl’ may be used uninitialized in this function [-Wmaybe-uninitialized] SSL_free(ssl);
Azat Khuzhin 24a1f25a 2015-08-19T13:19:41 sample/https-client: graceful exit with freeing memory (to make valgrind happy)
Andrey Skriabin 29a04825 2015-04-02T20:42:54 https-client: correctly handle URLs with no path (like "https://host:port") path == NULL check removed Fixes: #233 Fixes: #234
Azat Khuzhin 6dc71e70 2015-08-18T21:57:28 sample/http-connect: don't use assert() to make it work with NDEBUG Otherwise it will not work for cmake release target type.
Azat Khuzhin 9f0bff3f 2015-08-18T21:30:48 test/regress_http: initialize "dns_base" to avoid reading trash Even though it is very unlikely, but it will better to fix this.
Azat Khuzhin f976d436 2015-08-18T21:29:03 sample/http-connect: made it compatible with C90
Azat Khuzhin e0455515 2015-08-18T21:19:11 Merge branch 'reuse-conn_address-on-retry-v11' There is regression tests and also this code worked/tested during crawling a huge number of pages (billions). * reuse-conn_address-on-retry-v11: be_sock: bufferevent_socket_set_conn_address(): assert instead of silent no-op http: reuse connected address only with EVHTTP_CON_REUSE_CONNECTED_ADDR be_sock: sanity check in bufferevent_socket_set_conn_address() be: replace sockaddr_storage with sockaddr_in6 for conn_address be: we don't need to use getpeername() we we have conn_address be: replace conn_address by full struct instead of pointer test/http: cover retrying with saved conn_address by shutting down dns server http: use IP address that we got before (if any) during retrying bufferevent: move conn_address out from http into bufferevent be: make @sa const for bufferevent_socket_connect() util: make @sa const for evutil_socket_connect_()
Azat Khuzhin 0ab88c2a 2015-08-18T20:41:16 be_sock: bufferevent_socket_set_conn_address(): assert instead of silent no-op
Azat Khuzhin a50f5f0a 2015-01-01T06:27:31 http: reuse connected address only with EVHTTP_CON_REUSE_CONNECTED_ADDR
Azat Khuzhin eedbeff3 2014-12-02T14:31:03 be_sock: sanity check in bufferevent_socket_set_conn_address()
Azat Khuzhin 38896124 2014-12-02T14:24:19 be: replace sockaddr_storage with sockaddr_in6 for conn_address We need only ipv6/ipv4 for connect in bufferevent, and since sockaddr_storage is pretty big (128 bytes) it will be better to use sockaddr_in6 here (it will fit ipv4 too).
Azat Khuzhin 2c271e24 2014-11-16T00:30:11 be: we don't need to use getpeername() we we have conn_address Since getpeername() could fail.
Azat Khuzhin e5615aa7 2014-11-16T00:29:19 be: replace conn_address by full struct instead of pointer
Azat Khuzhin f4874d8c 2014-11-15T20:35:40 test/http: cover retrying with saved conn_address by shutting down dns server
Azat Khuzhin 54c887d8 2014-11-12T20:23:46 http: use IP address that we got before (if any) during retrying Before this patch every time we are retrying our request we resolve domain, but we could optimize this (since UDP is slow) by using cached conn_address value, so do this.
Azat Khuzhin 8bb38425 2014-11-15T21:46:11 bufferevent: move conn_address out from http into bufferevent In http the only case when when we could store it is when we already connected, *but* if we are doing request using domain name, then we need to do request to nameserver to get IP address, and this is handled by bufferevent. So when we have IP address (from nameserver) and don't have connection to this IP address, we could already cache it to avoid extra DNS requests (since UDP is slow), and we can't do this from http layer, only from bufferevent.
Azat Khuzhin dc33c783 2014-12-02T15:05:59 be: make @sa const for bufferevent_socket_connect()
Azat Khuzhin a8d32c23 2014-12-02T15:05:36 util: make @sa const for evutil_socket_connect_()
Azat Khuzhin 1d34498e 2015-08-18T12:18:31 sample: add HTTP CONNECT tunnelling example using libevent http layer
Azat Khuzhin 22061ac1 2015-08-18T03:03:51 http: introduce evhttp_request_free_() helper
Azat Khuzhin 6540da38 2015-04-24T19:04:51 http: introduce evhttp_is_request_connection_close() helper
Mark Ellzey 1dbb55da 2015-06-21T22:05:21 Updated gitignore
Mark Ellzey bdeec440 2015-06-17T08:24:52 Merge pull request #190 from JohnOhl/evhttp-post-fix evhttp: Fix failure to send all output data for POST/PUT requests
Mark Ellzey 620ff243 2015-06-17T08:05:53 Update dns-example. There's somebody out there who is going to have a compiler from 1986 who will complain. Better to fix c99 now.