kmx git

Commit	Date	Message
57bb630c	2023-06-20T13:49:37	Add __cplusplus in ws.h to fix compilation errors when using c++ compiler
b0194392	2023-06-08T23:25:22	wepoll: replace default malloc/free with libevent mm_ variants (#1472) This replaces malloc and free in wepoll.c with mm_malloc and mm_free. I'm using event-internal.h instead of mm-internal.h. Using only mm-internal.h in wepoll.c can cause errors regarding the export symbol macros.
45e24185	2023-06-07T22:39:46	Merge pull request #1470 from mdavidsaver/auto-detect-ssl Both cmake and autoconf are capable of automatically detecting the presence of OpenSSL and MbedTLS. However, the present build time logic doesn't do this. With cmake, my starting point is to preserve the reversed logic of `EVENT__DISABLE_OPENSSL` and `EVENT__DISABLE_MBEDTLS`, adding a third option `AUTO` as the new default. I'm following the pattern of this [post on the cmake list](https://cmake.org/pipermail/cmake/2016-October/064342.html). `OFF` and `ON` should continue with their present behaviors. With autoconf, I've tried to implement what I understand to be conventional behavior. eg. `--enable-openssl` and `--disable-openssl` should continue to have the same effect. The default if neither is passed is equivalent to the new `--enable-openssl=auto`. I've also added another commit removing what I think is an unnecessary `break` in `m4/libevent_mbedtls.m4`, which I suspect is leftover from some copy+paste from `m4/libevent_openssl.m4`. Surprisingly to me, a `break` outside of any loop does not seem to be treated as an error.
7cd51ae1	2023-06-06T12:43:02	Add CI tests which require SSL libraries
9ce6ae78	2023-06-05T18:38:22	Add option to auto-detect OpenSSL and MbedTLS
71848a23	2023-06-06T12:34:08	libevent_mbedtls.m4 remove extraneous break Maybe a leftover or copy+paste from a for loop in libevent_openssl.m4 ?
bca26524	2023-05-25T02:05:28	Create Security Policy (#1462) I've created the SECURITY.md file following a GitHub's template and considering the report vulnerability through security advisory, which is a handy new GitHub feature (but it's still in beta and has to be enabled). Closes #1461 Co-authored-by: Azat Khuzhin <a3at.mail@gmail.com>
1418e793	2023-05-25T10:37:24	build: fix some new warnings /opensource/libevent/sample/ws-chat-server.c:253:1: warning: control reaches end of non-void function [-Wreturn-type] } ^
283a371f	2023-05-23T21:46:14	cmake: log when CMAKE_DEBUG_POSTFIX/CMAKE_BUILD_TYPE is changed
2112c396	2023-05-22T08:21:01	autotools: fix generating pkg-config files (by substituting CMAKE_DEBUG_POSTFIX) Fixes: #1459
4effaee5	2023-05-22T00:01:17	cmake: Fix .pc files when building in Release mode Don't define CMAKE_DEBUG_POSTFIX as this breaks Release builds, only apply when doing debug builds.
abc114e3	2023-05-21T12:49:34	Bump default version when git tag is incorrect Fixes: #1457
1c06b68f	2023-05-21T10:09:50	Add a note about the last number in NUMERIC_VERSION
fe9dc8f6	2023-05-21T08:54:07	Merge branch 'release-2.2-pull' - 2.2.1-alpha (#1380) * release-2.2-pull: Bump version to 2.2.1 Update ChangeLog and whatsnew for 2.2.1 Update contributors (for 2.2 release)
8d1388a3	2023-05-21T08:40:48	Bump version to 2.2.1
4e19e8b4	2023-05-20T16:28:28	Update ChangeLog and whatsnew for 2.2.1
6ce568c3	2022-11-20T23:15:29	Update contributors (for 2.2 release)
13ce3045	2023-05-20T18:19:04	Merge branch 'changelog-improvements' * changelog-improvements: Generate changelog in a reverse order Add PR number into the changelog Use authors of the real patches instead of merge commits Cleanup changelog.py
1fb3e6d7	2023-05-20T17:40:01	Generate changelog in a reverse order
8b87ad48	2023-05-20T17:36:58	Add PR number into the changelog
fb2e1a69	2023-05-20T16:34:55	Use authors of the real patches instead of merge commits
c2e917d3	2023-05-20T16:29:22	Cleanup changelog.py - Use positional argument for revision range - Remove unused import - Add some todos
2c2ffb8d	2023-05-20T16:00:09	Revert "cmake: Only use relative paths for install DESTINATION option (#1405)" After rebasing I broke the initial intention of this patch, so it simply should be reverted. This reverts commit 81c6b8823c1b58d7837e827bb1098aa5f9e5956b.
5324e482	2023-05-16T21:21:48	Merge branch 'ssl-read-pull' - #1454 * ssl-read-pull: ssl: add some comments for lack of notify_close Drop unused le_ssl_ops::err_is_ok More SSL_read() to fill big buffer Make bufferevent_set_max_single_read() effect
49a7ae4c	2023-05-16T21:14:34	ssl: add some comments for lack of notify_close
e5941b2c	2023-05-16T21:16:33	Drop unused le_ssl_ops::err_is_ok It is not used anymore since errors are ignored if some progress had been done.
ef51444f	2023-05-15T10:18:38	More SSL_read() to fill big buffer Once SSL_read() only get max 16K bytes (one TLS record). In case of big buffer, should more SSL_read() to fill the buffer. Using sample https-client to measure max income MBit/s via nload tool. Note: set bufferevent_set_max_single_read() by 32K and add the chunk callback to read out each piece of data. The client sample do https request a data 900KB (the server don't use Transfer-Encoding: chunked) - With origin/master: max income is 2.26 MBit/s The chunk callback never get a piece of data > 16K. - With this PR: max income is 2.44 MBit/s The chunk callback can get some piece of data 32K or more.
4ab3242d	2023-05-15T19:57:38	Make bufferevent_set_max_single_read() effect
acfac7ae	2022-12-01T18:39:52	Make dependency paths relocatable The generated configurations for both CMake and pkg-config included absolute paths to dependencies (OpenSSL, MbedTLS). This is contrary to the general CMake advise to create relocatable packages [1]. Additionally, when building both mbedtls and libevent via CMake's FetchContent in the same project, loading the project would fail with INTERFACE_INCLUDE_DIRECTORIES property contains path: "/home/user/project/cmake-build/_deps/mbedtls-build/include" which is prefixed in the source directory. The required changes include: - Adding the outer includes only to the BUILD_INTERFACE solves the makes the CMake paths relocatable and thus solves the FetchContent problem. - Updates to libevent_*.pc.in fixes the relocatable issues for pkg-config and properly declares currently missing dependencies. - Using components for linking to OpenSSL (requiring CMake 3.4) and MbedTLS. The new MbedTLS target names now match the component names of the MbedTLS' CMake project. - Use the Threads CMake library reference instead of a direct reference to support both built-in pthread and -lpthread. v2 (azat): get back CMAKE_REQUIRED_LIBRARIES [1] https://cmake.org/cmake/help/v3.25/manual/cmake-packages.7.html#creating-relocatable-packages
81c6b882	2023-05-16T05:07:36	cmake: Only use relative paths for install DESTINATION option (#1405) As described in #1404, the explicit use of CMAKE_INSTALL_PREFIX conflicts with using command-line --prefix. This simply removes all explicit use of CMAKE_INSTALL_PREFIX. Otherwise this path will be duplicated: $ cmake -DCMAKE_BUILD_TYPE=debug -DCMAKE_EXPORT_COMPILE_COMMANDS=ON -DCMAKE_INSTALL_PREFIX=inst .. $ DESTDIR=inst ninja install ... -- Installing: inst/src/le/libevent/.cmake-debug/inst/include/event2/util.h -- Installing: inst/src/le/libevent/.cmake-debug/inst/include/event2/ws.h ... Fixes: #1404 Co-authored-by: Jeremy Murphy <jeremymu@blackmagicdesign.com>
4dee61c0	2023-05-14T22:56:02	Merge remote-tracking branch 'upstream/pr/1397' - #1397 * upstream/pr/1397: Make sure exported include dirs are correct Fix Configure_RPATH() Install LibeventConfig.cmake similar to other cmake files Use GNUInstallDirs for mapping installation directories
16be768d	2023-01-15T07:49:19	Make sure exported include dirs are correct CMake config files don't need any logic to detect the location of installed headers or DSOs, because these locations are already determined at project configuration time. They also don't need to distinguish between build and install trees, because that is already handled by the generated `LibeventTargets-*.cmake` files.
41a7393f	2022-07-10T13:48:53	Fix Configure_RPATH()
be03bf38	2021-11-08T06:47:25	Install LibeventConfig.cmake similar to other cmake files - Don't destroy cmake file between test case invocations
1f1593ff	2021-10-27T16:40:10	Use GNUInstallDirs for mapping installation directories
fe610f2c	2023-05-14T22:35:53	Fix util/mm_calloc_enomem under FreeBSD It looks like the compiler optimizes this call out with tt_assert(): (gdb) disas /m test_event_calloc_enomem Dump of assembler code for function test_event_calloc_enomem: 0x0000000000293bb0 <+0>: push %rbp 0x0000000000293bb1 <+1>: mov %rsp,%rbp 0x0000000000293bb4 <+4>: call 0x29f510 <__error@plt> 0x0000000000293bb9 <+9>: movl $0x0,(%rax) 0x0000000000293bbf <+15>: call 0x2990e0 <tinytest_set_test_failed_> 0x0000000000293bc4 <+20>: mov $0x2168e4,%edi 0x0000000000293bc9 <+25>: mov $0x220582,%esi 0x0000000000293bce <+30>: mov $0x20d893,%edx 0x0000000000293bd3 <+35>: mov $0x53a,%ecx 0x0000000000293bd8 <+40>: xor %eax,%eax 0x0000000000293bda <+42>: call 0x29f3b0 <printf@plt> 0x0000000000293bdf <+47>: mov $0x20da72,%edi 0x0000000000293be4 <+52>: mov $0x20f731,%esi 0x0000000000293be9 <+57>: xor %eax,%eax 0x0000000000293beb <+59>: pop %rbp 0x0000000000293bec <+60>: jmp 0x29f3b0 <printf@plt> While with tt_ptr_op() it does not: (gdb) disas /m test_event_calloc_enomem Dump of assembler code for function test_event_calloc_enomem: 0x0000000000293bd0 <+0>: push %rbp 0x0000000000293bd1 <+1>: mov %rsp,%rbp 0x0000000000293bd4 <+4>: push %rbx 0x0000000000293bd5 <+5>: push %rax 0x0000000000293bd6 <+6>: call 0x29f610 <__error@plt> 0x0000000000293bdb <+11>: movl $0x0,(%rax) 0x0000000000293be1 <+17>: mov $0xffffffffffffffff,%rdi 0x0000000000293be8 <+24>: mov $0xffffffffffffffff,%rsi 0x0000000000293bef <+31>: call 0x2a01c0 <calloc@plt> 0x0000000000293bf4 <+36>: test %rax,%rax 0x0000000000293bf7 <+39>: je 0x293c2b <test_event_calloc_enomem+91>
13f55523	2023-05-14T22:29:12	test: add missing include of arpa/inet.h for ntohs in regress_ws.c This will fix one warning in FreeBSD
1f006637	2023-05-14T22:03:26	Merge branch 'build/osx-fixes' * build/osx-fixes: Suppress -Wmacro-redefined for htonll/ntohll in OSX Fix -Wtautological-constant-out-of-range-compare in regress_http under OSX
6eba967e	2023-05-14T22:00:19	Suppress -Wmacro-redefined for htonll/ntohll in OSX OSX: test/regress_ws.c:61:9: warning: 'htonll' macro redefined [-Wmacro-redefined] #define htonll(x) \ ^ /Library/Developer/CommandLineTools/SDKs/MacOSX10.14.sdk/usr/include/sys/_endian.h:141:9: note: previous definition is here #define htonll(x) __DARWIN_OSSwapInt64(x) ^ test/regress_ws.c:65:9: warning: 'ntohll' macro redefined [-Wmacro-redefined] #define ntohll(x) htonll(x) ^ /Library/Developer/CommandLineTools/SDKs/MacOSX10.14.sdk/usr/include/sys/_endian.h:140:9: note: previous definition is here #define ntohll(x) __DARWIN_OSSwapInt64(x) ^
5f1fc92b	2023-05-14T21:55:43	Fix -Wtautological-constant-out-of-range-compare in regress_http under OSX compiler warning: test/regress_http.c:968:38: warning: result of comparison of constant 65536 with expression of type 'enum evhttp_cmd_type' is always true [-Wtautological-constant-out-of-range-compare] if (evhttp_request_get_command(req) != EVHTTP_REQ_CUSTOM) { ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~
d1969098	2022-12-09T13:09:44	Silence weird GCC warning about an uninitialized variable For the CMake release build with -DEVENT__ENABLE_GCC_WARNINGS=ON and -DEVENT__DISABLE_MM_REPLACEMENT=ON, GCC version 11 and 12 may complain about possibly uninitialized variable: In function ‘event_debug_assert_not_added_’, inlined from ‘event_assign’ at event.c:2184:2, inlined from ‘event_new’ at event.c:2276:6: cc1: error: ‘ev’ may be used uninitialized [-Werror=maybe-uninitialized] event.c: In function ‘event_new’: event.c:361:13: note: by argument 1 of type ‘const struct event ’ to event_debug_assert_not_added_.part.0’ declared here 361 \| static void event_debug_assert_not_added_(const struct event ev) \| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ This warning is most likely a false positive and can be silenced by explicitly disabling inlining for 'event_assign()'. Signed-off-by: Dmitry Antipov <dantipov@cloudlinux.com>
73037f88	2023-05-14T20:32:50	Ignore any archives (since you may use separate build dir for 'make dist')
e8cbe7b6	2023-05-14T20:04:34	Merge branch 'ssl/fix-partial-read' - #1451 * ssl/fix-partial-read: ssl: do not triger EOF if some data had been successfully read ssl: rename err_is_ok to handshake_is_ok (internal API)
7652cf40	2023-05-14T16:53:13	ssl: do not triger EOF if some data had been successfully read Previously in case when evbuffer_reserve_space() returns > 1, but it was able to read only 1 IO vector, it will try to read the next one, got 0 (EOF for mbedTLS or SSL_ERROR_ZERO_RETURN for OpenSSL) and will trigger EOF, while instead, it should trigger EV_READ w/o EOF and only after EOF.
6375dcb4	2023-05-14T16:45:14	ssl: rename err_is_ok to handshake_is_ok (internal API)
d06e573c	2023-05-05T15:13:05	style fix: use tab for indent
bdb343e1	2023-05-04T09:49:28	ci: use newer actions/x versions for master jobs Now that the jobs are running again, a number of deprecation warnings have surfaced https://github.com/libevent/libevent/actions/runs/4876367881: ```bash Node.js 12 actions are deprecated. Please update the following actions to use Node.js 16: actions/checkout@v2.0.0. ``` Looks like the most straightforward thing todo here is just use the newer version of the checkout action. Also move to the v1 tag for the coveralls job, rather than a pinned, much older version (the latest release is 1.2.5, https://github.com/coverallsapp/github-action/releases). Same again for actions/cache.
21173669	2023-05-04T09:38:56	ci: use OpenBSD 7.2 over 7.1 In the most recent CI run, all the OpenBSD CI jobs failed, i.e https://github.com/libevent/libevent/actions/runs/4876367885/jobs/8699759831, this seems to be due to the fact that packages for 7.1 have been removed from https://cdn.openbsd.org/pub/OpenBSD/ (only has 7.2 & 7.3): ```bash Config file: openbsd-7.1.conf https://cdn.openbsd.org/pub/OpenBSD/7.1/packages/amd64/: no such dir Can't find rsync-3.2.3p0 Couldn't install rsync-3.2.3p0 exec shell: bash run.sh showDebugInfo ``` Switch to using 7.2, which is available, so that the CI will run.
60ad22d4	2023-05-03T16:28:58	actions: use supported version of Ubuntu It looks like these jobs are failing to run, because support for ubuntu-18.04 has been removed entirely, see: https://github.com/actions/runner-images/issues/6002. Migrate to ubuntu-20.04.
75208132	2023-04-21T04:33:22	doc: minor cleanups following #1441 (#1442) Also fixes 1 broken link (apologies).
612a74c7	2023-04-17T21:19:58	Merge pull request #1441 from fanquake/autoconf_doc_updates doc: minor autoconf/formatting improvements
ac69410e	2023-04-17T14:28:43	doc: mark Autotools as deprecated in building.md Re-arrange so CMake is mentioned first. Formatting improvements.
2470b37b	2023-04-17T14:22:30	doc: move autoconf link in readme to autoconf section.
4c993a0e	2023-04-11T04:44:37	Fix typo in changelog (#1438)
f747a7b9	2023-04-04T22:19:07	Prohibit VLA in autotools too
f04d90b1	2023-04-04T22:15:35	Fix building with -Wstack-protector due to VLA and fobid them It is not a thankless task to fix such issues on and on, let's just prohibit this cases, and our build with -Werror on CI will show new issues from now on. Fixes: #1434
1878232b	2023-02-13T15:57:55	build: split kqueue warning message into cross-compile and apple This is output when compiling (natively) on macOS systems, which is confusing, because no cross-compilation is involved. Split the message into separate cases.
fc568ff0	2023-03-17T19:53:50	Deal with partial writes on SSL write SSL write may do partial writes in some cases. For example, document of mbedtls_ssl_write says: If the return value is non-negative but less than length, the function must be called again with updated arguments: buf + ret, len - ret (if ret is the return value) until it returns a value equal to the last 'len' argument. In case of partial writes, we should continue writing the same chain of buffer, not the next chain.
9203d98f	2023-03-27T04:35:00	http: style fix: use space between arguments list (#1435)
6e1826dd	2023-03-08T21:34:37	ci: fix typo in yaml for cifuzz Follow-up for: #1431
606056d6	2023-03-06T21:22:10	ci: switch to ubuntu 20.04 github action reports "internal error" for builds on ubuntu 18.04: linux-cmake-job (ubuntu-18.04, COMPILER_CLANG) This is a scheduled Ubuntu-18.04 brownout. The Ubuntu-18.04 environment is deprecated and will be removed on April 1st, 2023. For more details, see https://github.com/actions/runner-images/issues/6002 linux-cmake-job (ubuntu-18.04, COMPILER_CLANG) GitHub Actions has encountered an internal error when running your job.
99a4b1a7	2023-03-06T14:26:11	ci: set minimal permissions on GitHub Actions Change made by setting top-level read-only permisisons, and any other necessary permissions set as job-level. Closes #1421 Signed-off-by: Diogo Teles Sant'Anna <diogoteles@google.com>
6bfa5805	2023-03-05T23:59:21	http: Reduce times of checking if response has body (#1395) Use a variable 'need_body' to store the result of evhttp_response_needs_body(), then use the variable instead of call the function again.
185e2f00	2023-03-05T23:58:22	build: improve mbedtls searching on macOS with brew for cmake (#1419) This just copies the same logic used to find OpenSSL on macOS using homebrew, for finding mbedtls via brew. Without it, the build will fail out the box with a brew installed mbedtls.
4e6375e8	2023-03-05T16:56:56	Always have evutil_secure_rng_add_bytes available (#1427) When libevent doesn't provide random the arc4 function, but they come from libc, there is no need to call this function, so make it do nothing. Fixes: #1393
3a0cf34b	2023-03-04T22:29:09	ws-chat-server: fix potential resource leak
bac9d10a	2023-03-05T05:13:54	Fix potential null dereference in http-server (#1430) Co-authored-by: Azat Khuzhin <a3at.mail@gmail.com>
fa05966d	2023-03-05T05:12:04	test: fix potential null dereference in https_bind_ssl_bevcb (#1428) Co-authored-by: Azat Khuzhin <a3at.mail@gmail.com>
557990ca	2023-03-02T12:41:11	Optimize arc4random_uniform() (by syncing with OpenBSD implementation) 1. In d4de062, in Feb 2010, libevent adopted OpenBSD implementation of arc4random_uniform. 2. In https://github.com/openbsd/src/commit/728918cba93e0418bea2a73c9784f6b80c2a9dbd, in Jun 2012, OpenBSD improved their implementation to be faster, by changing arc4random_uniform() to calculate ``2**32 % upper_bound'' as ``-upper_bound % upper_bound''. Alternatively we can simply remove arc4random_uniform() since it is not used by libevent anyway, but let's just sync the header for now.
e96e98ae	2023-03-02T13:43:54	evdns: fix "Branch condition evaluates to a garbage value" in reply_parse
3bcc92cf	2023-03-02T13:59:32	Fix the value is never actually read from 'argument' in evhttp_parse_query_impl() Although the value stored to 'argument' is used in the enclosing expression, the value is never actually read from 'argument'
b84fee24	2023-03-02T14:07:44	Fix "Value stored to 'a' is never read" in SHA1Transform() Using same fix as used in android [1]. [1]: android.googlesource.com/platform/dalvik/+/android-4.4.2_r2/libdex/sha1.cpp#193
bcefdbc6	2023-02-14T09:56:03	Merge pull request #1418 from fanquake/use_fortify_source_3 build: use FORTIFY_SOURCE=3 in hardening option
e89ddd40	2023-02-13T16:06:29	build: use FORTIFY_SOURCE=3 in autotools build
38cd76f0	2023-02-13T16:05:58	build: use FORTIFY_SOURCE=3 in CMake build
28c28f07	2023-02-13T08:09:21	Merge pull request #1414 from azat/build/deprecate-autotools Deprecate autotools build
1df2a5a6	2023-02-12T17:05:20	test: enable allocator_may_return_null=1 for calloc with ENOMEM test
207ea62b	2023-02-12T16:46:40	test: handle -v as --verbose for regress
0ea20582	2023-02-12T21:39:04	test: add del_wait/del_notify tests for windows Test manually, since CI is too slow
c437b84a	2023-02-12T15:24:06	Remove extra builds for autotools on CI We have almost the same matrix for cmake and autotools, but autotools is considered to be deprecated from now on, plus our CI takes too much time, especially non-linux, since we are using public infrastucture. So let's remove extra builds.
f7e39d2e	2023-02-12T16:29:45	ci: bump cache and checkout plugins
b5a6940d	2023-02-12T16:11:02	ci: fix paths-ignore
7e6d9b0b	2023-02-12T15:20:30	.github/workflows/build.yml: remove trailing whitespaces
866b751b	2023-02-12T15:19:51	Deprecate autotools build
765fb410	2023-02-12T16:19:35	Fix compilation on non recent windows SDKs (#1399) In commit f8bb9d8 the header stringapiset.h was included, very likely because the user who made the change saw that the funciton WideCharToMultiByte is "declared" in there. That header tho is a recent addition to the windows headers added in the last years in an attempt from microsoft to split the windows.h header in multiple files, so the inclusion fails when the library is not built with the latest visual studio using the latest windows 10 sdk. That inclusion can be safely removed as in any case the function WideCharToMultiByte was already included by the windows.h header that is included few lines below.
61de8a07	2023-02-12T15:47:16	test: fix leaks in bufferevent_pair_release_lock (#1413)
a82b77bb	2023-02-12T09:56:54	Remove suppression for test_ok under TSan There is no such tests yet.
b5a5fbb8	2023-02-12T08:50:05	Merge branch 'tests-fixes' * tests-fixes: Add more ignore rules test: fix debug locks in case new lock gots old address test: suppress logs from the tests that produce them under normal circumstances test: fix TT_* flags values Suppress data race for test_ok variable Suppress data race for event_debug_created_threadable_ctx_ variable
b99106f3	2023-02-12T08:36:16	Add more ignore rules - for clangd - and compile_commands.json for it
c257e16f	2023-02-12T08:34:52	test: fix debug locks in case new lock gots old address Refs: #1407
fb900a28	2023-02-12T08:12:20	test: suppress logs from the tests that produce them under normal circumstances
1201bb85	2023-02-12T07:59:17	test: fix TT_* flags values
f0cb4b7f	2023-02-12T07:58:55	Suppress data race for test_ok variable
39be38ff	2023-02-12T07:58:29	Suppress data race for event_debug_created_threadable_ctx_ variable
f9134df7	2023-02-04T15:00:48	Add LEV_OPT_BIND_IPV4_AND_IPV6 flag (#1400) Libevent introduced the LEV_OPT_BIND_IPV6ONLY to pass to evconnlistener_new_bind to make it automatically set the underlying socket as accepting ipv6 requests. This works fine on posix compliant platforms as by the standard every new AF_INET6 socket is created as both supporting ipv6 and ipv4 connections. But on windows the default is the opposite, with the flag IPV6_V6ONLY being always enabled by default. This makes creating a listener to supports both protocols a bit more tricky as winsock doesn't allow changing this flag after evconnlistener_new_bind does all the initial setup because as stated in the docs, you can't change it after the sonnect connected, so one would have to manually create the socket beforehand and set the flag and then call evconnlistener_new with the socket itself. It would be nice to have libevent keep a consistent behaviour across the platforms in this scenario, maybe or by making it always set IPV6_V6ONLY to false unless LEV_OPT_BIND_IPV6ONLY is passed, in which case it's set to true, or add another flag to forcefully set it to false and keep the system dependent behaviour as default. So this patch add new option for libevent listeners to bind to both - LEV_OPT_BIND_IPV4_AND_IPV6
a5b0ded3	2023-02-04T14:56:53	Add config for vim/nvim
4d85d28a	2023-01-28T13:28:52	Fix pthread detection for regress tests on Android Fixes: #1403
35375101	2023-01-27T08:57:33	Fixes some new warnings under clang-15 - -Wdeprecated-non-prototype /src/le/libevent/strlcpy.c:48:1: warning: a function definition without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype] event_strlcpy_(dst, src, siz) - -Wstrict-prototypes /src/le/libevent/evthread.c:82:70: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes] struct evthread_condition_callbacks *evthread_get_condition_callbacks() - -Wunused-but-set-variable /src/le/libevent/test/regress_buffer.c:130:6: warning: variable 'n' set but not used [-Wunused-but-set-variable] int n = 0; ^
3d138bda	2023-01-27T08:51:56	Allow evdns_base_new to succeed with no nameservers configured (#1389) * evdns-no-ns: Allow evdns_base_new to succeed with no nameservers configured Replace magic numbers with consts for evdns_base_resolv_conf_parse() errors
ebd7e8d7	2023-01-27T08:44:41	Allow evdns_base_new to succeed with no nameservers configured If resolv.conf has no nameservers, evdns_base_new can still succeed with the default of using the name server from localhost matching the man page documentation for resolv.conf.

57bb630c

2023-06-20T13:49:37

Add __cplusplus in ws.h to fix compilation errors when using c++ compiler

b0194392

2023-06-08T23:25:22

wepoll: replace default malloc/free with libevent mm_ variants (#1472) This replaces malloc and free in wepoll.c with mm_malloc and mm_free. I'm using event-internal.h instead of mm-internal.h. Using only mm-internal.h in wepoll.c can cause errors regarding the export symbol macros.

45e24185

2023-06-07T22:39:46

Merge pull request #1470 from mdavidsaver/auto-detect-ssl Both cmake and autoconf are capable of automatically detecting the presence of OpenSSL and MbedTLS. However, the present build time logic doesn't do this. With cmake, my starting point is to preserve the reversed logic of `EVENT__DISABLE_OPENSSL` and `EVENT__DISABLE_MBEDTLS`, adding a third option `AUTO` as the new default. I'm following the pattern of this [post on the cmake list](https://cmake.org/pipermail/cmake/2016-October/064342.html). `OFF` and `ON` should continue with their present behaviors. With autoconf, I've tried to implement what I understand to be conventional behavior. eg. `--enable-openssl` and `--disable-openssl` should continue to have the same effect. The default if neither is passed is equivalent to the new `--enable-openssl=auto`. I've also added another commit removing what I think is an unnecessary `break` in `m4/libevent_mbedtls.m4`, which I suspect is leftover from some copy+paste from `m4/libevent_openssl.m4`. Surprisingly to me, a `break` outside of any loop does not seem to be treated as an error.

7cd51ae1

2023-06-06T12:43:02

Add CI tests which require SSL libraries

9ce6ae78

2023-06-05T18:38:22

Add option to auto-detect OpenSSL and MbedTLS

71848a23

2023-06-06T12:34:08

libevent_mbedtls.m4 remove extraneous break Maybe a leftover or copy+paste from a for loop in libevent_openssl.m4 ?

bca26524

2023-05-25T02:05:28

Create Security Policy (#1462) I've created the SECURITY.md file following a GitHub's template and considering the report vulnerability through security advisory, which is a handy new GitHub feature (but it's still in beta and has to be enabled). Closes #1461 Co-authored-by: Azat Khuzhin <a3at.mail@gmail.com>

1418e793

2023-05-25T10:37:24

build: fix some new warnings /opensource/libevent/sample/ws-chat-server.c:253:1: warning: control reaches end of non-void function [-Wreturn-type] } ^

283a371f

2023-05-23T21:46:14

cmake: log when CMAKE_DEBUG_POSTFIX/CMAKE_BUILD_TYPE is changed

2112c396

2023-05-22T08:21:01

autotools: fix generating pkg-config files (by substituting CMAKE_DEBUG_POSTFIX) Fixes: #1459

4effaee5

2023-05-22T00:01:17

cmake: Fix .pc files when building in Release mode Don't define CMAKE_DEBUG_POSTFIX as this breaks Release builds, only apply when doing debug builds.

abc114e3

2023-05-21T12:49:34

Bump default version when git tag is incorrect Fixes: #1457

1c06b68f

2023-05-21T10:09:50

Add a note about the last number in NUMERIC_VERSION

fe9dc8f6

2023-05-21T08:54:07

Merge branch 'release-2.2-pull' - 2.2.1-alpha (#1380) * release-2.2-pull: Bump version to 2.2.1 Update ChangeLog and whatsnew for 2.2.1 Update contributors (for 2.2 release)

8d1388a3

2023-05-21T08:40:48

Bump version to 2.2.1

4e19e8b4

2023-05-20T16:28:28

Update ChangeLog and whatsnew for 2.2.1

6ce568c3

2022-11-20T23:15:29

Update contributors (for 2.2 release)

13ce3045

2023-05-20T18:19:04

Merge branch 'changelog-improvements' * changelog-improvements: Generate changelog in a reverse order Add PR number into the changelog Use authors of the real patches instead of merge commits Cleanup changelog.py

1fb3e6d7

2023-05-20T17:40:01

Generate changelog in a reverse order

8b87ad48

2023-05-20T17:36:58

Add PR number into the changelog

fb2e1a69

2023-05-20T16:34:55

Use authors of the real patches instead of merge commits

c2e917d3

2023-05-20T16:29:22

Cleanup changelog.py - Use positional argument for revision range - Remove unused import - Add some todos

2c2ffb8d

2023-05-20T16:00:09

Revert "cmake: Only use relative paths for install DESTINATION option (#1405)" After rebasing I broke the initial intention of this patch, so it simply should be reverted. This reverts commit 81c6b8823c1b58d7837e827bb1098aa5f9e5956b.

5324e482

2023-05-16T21:21:48

Merge branch 'ssl-read-pull' - #1454 * ssl-read-pull: ssl: add some comments for lack of notify_close Drop unused le_ssl_ops::err_is_ok More SSL_read() to fill big buffer Make bufferevent_set_max_single_read() effect

49a7ae4c

2023-05-16T21:14:34

ssl: add some comments for lack of notify_close

e5941b2c

2023-05-16T21:16:33

Drop unused le_ssl_ops::err_is_ok It is not used anymore since errors are ignored if some progress had been done.

ef51444f

2023-05-15T10:18:38

More SSL_read() to fill big buffer Once SSL_read() only get max 16K bytes (one TLS record). In case of big buffer, should more SSL_read() to fill the buffer. Using sample https-client to measure max income MBit/s via nload tool. Note: set bufferevent_set_max_single_read() by 32K and add the chunk callback to read out each piece of data. The client sample do https request a data 900KB (the server don't use Transfer-Encoding: chunked) - With origin/master: max income is 2.26 MBit/s The chunk callback never get a piece of data > 16K. - With this PR: max income is 2.44 MBit/s The chunk callback can get some piece of data 32K or more.

4ab3242d

2023-05-15T19:57:38

Make bufferevent_set_max_single_read() effect

acfac7ae

2022-12-01T18:39:52

Make dependency paths relocatable The generated configurations for both CMake and pkg-config included absolute paths to dependencies (OpenSSL, MbedTLS). This is contrary to the general CMake advise to create relocatable packages [1]. Additionally, when building both mbedtls and libevent via CMake's FetchContent in the same project, loading the project would fail with INTERFACE_INCLUDE_DIRECTORIES property contains path: "/home/user/project/cmake-build/_deps/mbedtls-build/include" which is prefixed in the source directory. The required changes include: - Adding the outer includes only to the BUILD_INTERFACE solves the makes the CMake paths relocatable and thus solves the FetchContent problem. - Updates to libevent_*.pc.in fixes the relocatable issues for pkg-config and properly declares currently missing dependencies. - Using components for linking to OpenSSL (requiring CMake 3.4) and MbedTLS. The new MbedTLS target names now match the component names of the MbedTLS' CMake project. - Use the Threads CMake library reference instead of a direct reference to support both built-in pthread and -lpthread. v2 (azat): get back CMAKE_REQUIRED_LIBRARIES [1] https://cmake.org/cmake/help/v3.25/manual/cmake-packages.7.html#creating-relocatable-packages

81c6b882

2023-05-16T05:07:36

cmake: Only use relative paths for install DESTINATION option (#1405) As described in #1404, the explicit use of CMAKE_INSTALL_PREFIX conflicts with using command-line --prefix. This simply removes all explicit use of CMAKE_INSTALL_PREFIX. Otherwise this path will be duplicated: $ cmake -DCMAKE_BUILD_TYPE=debug -DCMAKE_EXPORT_COMPILE_COMMANDS=ON -DCMAKE_INSTALL_PREFIX=inst .. $ DESTDIR=inst ninja install ... -- Installing: inst/src/le/libevent/.cmake-debug/inst/include/event2/util.h -- Installing: inst/src/le/libevent/.cmake-debug/inst/include/event2/ws.h ... Fixes: #1404 Co-authored-by: Jeremy Murphy <jeremymu@blackmagicdesign.com>

4dee61c0

2023-05-14T22:56:02

Merge remote-tracking branch 'upstream/pr/1397' - #1397 * upstream/pr/1397: Make sure exported include dirs are correct Fix Configure_RPATH() Install LibeventConfig.cmake similar to other cmake files Use GNUInstallDirs for mapping installation directories

16be768d

2023-01-15T07:49:19

Make sure exported include dirs are correct CMake config files don't need any logic to detect the location of installed headers or DSOs, because these locations are already determined at project configuration time. They also don't need to distinguish between build and install trees, because that is already handled by the generated `LibeventTargets-*.cmake` files.

41a7393f

2022-07-10T13:48:53

Fix Configure_RPATH()

be03bf38

2021-11-08T06:47:25

Install LibeventConfig.cmake similar to other cmake files - Don't destroy cmake file between test case invocations

1f1593ff

2021-10-27T16:40:10

Use GNUInstallDirs for mapping installation directories

fe610f2c

2023-05-14T22:35:53

Fix util/mm_calloc_enomem under FreeBSD It looks like the compiler optimizes this call out with tt_assert(): (gdb) disas /m test_event_calloc_enomem Dump of assembler code for function test_event_calloc_enomem: 0x0000000000293bb0 <+0>: push %rbp 0x0000000000293bb1 <+1>: mov %rsp,%rbp 0x0000000000293bb4 <+4>: call 0x29f510 <__error@plt> 0x0000000000293bb9 <+9>: movl $0x0,(%rax) 0x0000000000293bbf <+15>: call 0x2990e0 <tinytest_set_test_failed_> 0x0000000000293bc4 <+20>: mov $0x2168e4,%edi 0x0000000000293bc9 <+25>: mov $0x220582,%esi 0x0000000000293bce <+30>: mov $0x20d893,%edx 0x0000000000293bd3 <+35>: mov $0x53a,%ecx 0x0000000000293bd8 <+40>: xor %eax,%eax 0x0000000000293bda <+42>: call 0x29f3b0 <printf@plt> 0x0000000000293bdf <+47>: mov $0x20da72,%edi 0x0000000000293be4 <+52>: mov $0x20f731,%esi 0x0000000000293be9 <+57>: xor %eax,%eax 0x0000000000293beb <+59>: pop %rbp 0x0000000000293bec <+60>: jmp 0x29f3b0 <printf@plt> While with tt_ptr_op() it does not: (gdb) disas /m test_event_calloc_enomem Dump of assembler code for function test_event_calloc_enomem: 0x0000000000293bd0 <+0>: push %rbp 0x0000000000293bd1 <+1>: mov %rsp,%rbp 0x0000000000293bd4 <+4>: push %rbx 0x0000000000293bd5 <+5>: push %rax 0x0000000000293bd6 <+6>: call 0x29f610 <__error@plt> 0x0000000000293bdb <+11>: movl $0x0,(%rax) 0x0000000000293be1 <+17>: mov $0xffffffffffffffff,%rdi 0x0000000000293be8 <+24>: mov $0xffffffffffffffff,%rsi 0x0000000000293bef <+31>: call 0x2a01c0 <calloc@plt> 0x0000000000293bf4 <+36>: test %rax,%rax 0x0000000000293bf7 <+39>: je 0x293c2b <test_event_calloc_enomem+91>

13f55523

2023-05-14T22:29:12

test: add missing include of arpa/inet.h for ntohs in regress_ws.c This will fix one warning in FreeBSD

1f006637

2023-05-14T22:03:26

Merge branch 'build/osx-fixes' * build/osx-fixes: Suppress -Wmacro-redefined for htonll/ntohll in OSX Fix -Wtautological-constant-out-of-range-compare in regress_http under OSX

6eba967e

2023-05-14T22:00:19

Suppress -Wmacro-redefined for htonll/ntohll in OSX OSX: test/regress_ws.c:61:9: warning: 'htonll' macro redefined [-Wmacro-redefined] #define htonll(x) \ ^ /Library/Developer/CommandLineTools/SDKs/MacOSX10.14.sdk/usr/include/sys/_endian.h:141:9: note: previous definition is here #define htonll(x) __DARWIN_OSSwapInt64(x) ^ test/regress_ws.c:65:9: warning: 'ntohll' macro redefined [-Wmacro-redefined] #define ntohll(x) htonll(x) ^ /Library/Developer/CommandLineTools/SDKs/MacOSX10.14.sdk/usr/include/sys/_endian.h:140:9: note: previous definition is here #define ntohll(x) __DARWIN_OSSwapInt64(x) ^

5f1fc92b

2023-05-14T21:55:43

Fix -Wtautological-constant-out-of-range-compare in regress_http under OSX compiler warning: test/regress_http.c:968:38: warning: result of comparison of constant 65536 with expression of type 'enum evhttp_cmd_type' is always true [-Wtautological-constant-out-of-range-compare] if (evhttp_request_get_command(req) != EVHTTP_REQ_CUSTOM) { ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~

d1969098

2022-12-09T13:09:44

Silence weird GCC warning about an uninitialized variable For the CMake release build with -DEVENT__ENABLE_GCC_WARNINGS=ON and -DEVENT__DISABLE_MM_REPLACEMENT=ON, GCC version 11 and 12 may complain about possibly uninitialized variable: In function ‘event_debug_assert_not_added_’, inlined from ‘event_assign’ at event.c:2184:2, inlined from ‘event_new’ at event.c:2276:6: cc1: error: ‘ev’ may be used uninitialized [-Werror=maybe-uninitialized] event.c: In function ‘event_new’: event.c:361:13: note: by argument 1 of type ‘const struct event *’ to event_debug_assert_not_added_.part.0’ declared here 361 | static void event_debug_assert_not_added_(const struct event *ev) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ This warning is most likely a false positive and can be silenced by explicitly disabling inlining for 'event_assign()'. Signed-off-by: Dmitry Antipov <dantipov@cloudlinux.com>

73037f88

2023-05-14T20:32:50

Ignore any archives (since you may use separate build dir for 'make dist')

e8cbe7b6

2023-05-14T20:04:34

Merge branch 'ssl/fix-partial-read' - #1451 * ssl/fix-partial-read: ssl: do not triger EOF if some data had been successfully read ssl: rename err_is_ok to handshake_is_ok (internal API)

7652cf40

2023-05-14T16:53:13

ssl: do not triger EOF if some data had been successfully read Previously in case when evbuffer_reserve_space() returns > 1, but it was able to read only 1 IO vector, it will try to read the next one, got 0 (EOF for mbedTLS or SSL_ERROR_ZERO_RETURN for OpenSSL) and will trigger EOF, while instead, it should trigger EV_READ w/o EOF and only after EOF.

6375dcb4

2023-05-14T16:45:14

ssl: rename err_is_ok to handshake_is_ok (internal API)

d06e573c

2023-05-05T15:13:05

style fix: use tab for indent

bdb343e1

2023-05-04T09:49:28

ci: use newer actions/x versions for master jobs Now that the jobs are running again, a number of deprecation warnings have surfaced https://github.com/libevent/libevent/actions/runs/4876367881: ```bash Node.js 12 actions are deprecated. Please update the following actions to use Node.js 16: actions/checkout@v2.0.0. ``` Looks like the most straightforward thing todo here is just use the newer version of the checkout action. Also move to the v1 tag for the coveralls job, rather than a pinned, much older version (the latest release is 1.2.5, https://github.com/coverallsapp/github-action/releases). Same again for actions/cache.

21173669

2023-05-04T09:38:56

ci: use OpenBSD 7.2 over 7.1 In the most recent CI run, all the OpenBSD CI jobs failed, i.e https://github.com/libevent/libevent/actions/runs/4876367885/jobs/8699759831, this seems to be due to the fact that packages for 7.1 have been removed from https://cdn.openbsd.org/pub/OpenBSD/ (only has 7.2 & 7.3): ```bash Config file: openbsd-7.1.conf https://cdn.openbsd.org/pub/OpenBSD/7.1/packages/amd64/: no such dir Can't find rsync-3.2.3p0 Couldn't install rsync-3.2.3p0 exec shell: bash run.sh showDebugInfo ``` Switch to using 7.2, which is available, so that the CI will run.

60ad22d4

2023-05-03T16:28:58

actions: use supported version of Ubuntu It looks like these jobs are failing to run, because support for ubuntu-18.04 has been removed entirely, see: https://github.com/actions/runner-images/issues/6002. Migrate to ubuntu-20.04.

75208132

2023-04-21T04:33:22

doc: minor cleanups following #1441 (#1442) Also fixes 1 broken link (apologies).

612a74c7

2023-04-17T21:19:58

Merge pull request #1441 from fanquake/autoconf_doc_updates doc: minor autoconf/formatting improvements

ac69410e

2023-04-17T14:28:43

doc: mark Autotools as deprecated in building.md Re-arrange so CMake is mentioned first. Formatting improvements.

2470b37b

2023-04-17T14:22:30

doc: move autoconf link in readme to autoconf section.

4c993a0e

2023-04-11T04:44:37

Fix typo in changelog (#1438)

f747a7b9

2023-04-04T22:19:07

Prohibit VLA in autotools too

f04d90b1

2023-04-04T22:15:35

Fix building with -Wstack-protector due to VLA and fobid them It is not a thankless task to fix such issues on and on, let's just prohibit this cases, and our build with -Werror on CI will show new issues from now on. Fixes: #1434

1878232b

2023-02-13T15:57:55

build: split kqueue warning message into cross-compile and apple This is output when compiling (natively) on macOS systems, which is confusing, because no cross-compilation is involved. Split the message into separate cases.

fc568ff0

2023-03-17T19:53:50

Deal with partial writes on SSL write SSL write may do partial writes in some cases. For example, document of mbedtls_ssl_write says: If the return value is non-negative but less than length, the function must be called again with updated arguments: buf + ret, len - ret (if ret is the return value) until it returns a value equal to the last 'len' argument. In case of partial writes, we should continue writing the same chain of buffer, not the next chain.

9203d98f

2023-03-27T04:35:00

http: style fix: use space between arguments list (#1435)

6e1826dd

2023-03-08T21:34:37

ci: fix typo in yaml for cifuzz Follow-up for: #1431

606056d6

2023-03-06T21:22:10

ci: switch to ubuntu 20.04 github action reports "internal error" for builds on ubuntu 18.04: linux-cmake-job (ubuntu-18.04, COMPILER_CLANG) This is a scheduled Ubuntu-18.04 brownout. The Ubuntu-18.04 environment is deprecated and will be removed on April 1st, 2023. For more details, see https://github.com/actions/runner-images/issues/6002 linux-cmake-job (ubuntu-18.04, COMPILER_CLANG) GitHub Actions has encountered an internal error when running your job.

99a4b1a7

2023-03-06T14:26:11

ci: set minimal permissions on GitHub Actions Change made by setting top-level read-only permisisons, and any other necessary permissions set as job-level. Closes #1421 Signed-off-by: Diogo Teles Sant'Anna <diogoteles@google.com>

6bfa5805

2023-03-05T23:59:21

http: Reduce times of checking if response has body (#1395) Use a variable 'need_body' to store the result of evhttp_response_needs_body(), then use the variable instead of call the function again.

185e2f00

2023-03-05T23:58:22

build: improve mbedtls searching on macOS with brew for cmake (#1419) This just copies the same logic used to find OpenSSL on macOS using homebrew, for finding mbedtls via brew. Without it, the build will fail out the box with a brew installed mbedtls.

4e6375e8

2023-03-05T16:56:56

Always have evutil_secure_rng_add_bytes available (#1427) When libevent doesn't provide random the arc4 function, but they come from libc, there is no need to call this function, so make it do nothing. Fixes: #1393

3a0cf34b

2023-03-04T22:29:09

ws-chat-server: fix potential resource leak

bac9d10a

2023-03-05T05:13:54

Fix potential null dereference in http-server (#1430) Co-authored-by: Azat Khuzhin <a3at.mail@gmail.com>

fa05966d

2023-03-05T05:12:04

test: fix potential null dereference in https_bind_ssl_bevcb (#1428) Co-authored-by: Azat Khuzhin <a3at.mail@gmail.com>

557990ca

2023-03-02T12:41:11

Optimize arc4random_uniform() (by syncing with OpenBSD implementation) 1. In d4de062, in Feb 2010, libevent adopted OpenBSD implementation of arc4random_uniform. 2. In https://github.com/openbsd/src/commit/728918cba93e0418bea2a73c9784f6b80c2a9dbd, in Jun 2012, OpenBSD improved their implementation to be faster, by changing arc4random_uniform() to calculate ``2**32 % upper_bound'' as ``-upper_bound % upper_bound''. Alternatively we can simply remove arc4random_uniform() since it is not used by libevent anyway, but let's just sync the header for now.

e96e98ae

2023-03-02T13:43:54

evdns: fix "Branch condition evaluates to a garbage value" in reply_parse

3bcc92cf

2023-03-02T13:59:32

Fix the value is never actually read from 'argument' in evhttp_parse_query_impl() Although the value stored to 'argument' is used in the enclosing expression, the value is never actually read from 'argument'

b84fee24

2023-03-02T14:07:44

Fix "Value stored to 'a' is never read" in SHA1Transform() Using same fix as used in android [1]. [1]: android.googlesource.com/platform/dalvik/+/android-4.4.2_r2/libdex/sha1.cpp#193

bcefdbc6

2023-02-14T09:56:03

Merge pull request #1418 from fanquake/use_fortify_source_3 build: use FORTIFY_SOURCE=3 in hardening option

e89ddd40

2023-02-13T16:06:29

build: use FORTIFY_SOURCE=3 in autotools build

38cd76f0

2023-02-13T16:05:58

build: use FORTIFY_SOURCE=3 in CMake build

28c28f07

2023-02-13T08:09:21

Merge pull request #1414 from azat/build/deprecate-autotools Deprecate autotools build

1df2a5a6

2023-02-12T17:05:20

test: enable allocator_may_return_null=1 for calloc with ENOMEM test

207ea62b

2023-02-12T16:46:40

test: handle -v as --verbose for regress

0ea20582

2023-02-12T21:39:04

test: add del_wait/del_notify tests for windows Test manually, since CI is too slow

c437b84a

2023-02-12T15:24:06

Remove extra builds for autotools on CI We have almost the same matrix for cmake and autotools, but autotools is considered to be deprecated from now on, plus our CI takes too much time, especially non-linux, since we are using public infrastucture. So let's remove extra builds.

f7e39d2e

2023-02-12T16:29:45

ci: bump cache and checkout plugins

b5a6940d

2023-02-12T16:11:02

ci: fix paths-ignore

7e6d9b0b

2023-02-12T15:20:30

.github/workflows/build.yml: remove trailing whitespaces

866b751b

2023-02-12T15:19:51

Deprecate autotools build

765fb410

2023-02-12T16:19:35

Fix compilation on non recent windows SDKs (#1399) In commit f8bb9d8 the header stringapiset.h was included, very likely because the user who made the change saw that the funciton WideCharToMultiByte is "declared" in there. That header tho is a recent addition to the windows headers added in the last years in an attempt from microsoft to split the windows.h header in multiple files, so the inclusion fails when the library is not built with the latest visual studio using the latest windows 10 sdk. That inclusion can be safely removed as in any case the function WideCharToMultiByte was already included by the windows.h header that is included few lines below.

61de8a07

2023-02-12T15:47:16

test: fix leaks in bufferevent_pair_release_lock (#1413)

a82b77bb

2023-02-12T09:56:54

Remove suppression for test_ok under TSan There is no such tests yet.

b5a5fbb8

2023-02-12T08:50:05

Merge branch 'tests-fixes' * tests-fixes: Add more ignore rules test: fix debug locks in case new lock gots old address test: suppress logs from the tests that produce them under normal circumstances test: fix TT_* flags values Suppress data race for test_ok variable Suppress data race for event_debug_created_threadable_ctx_ variable

b99106f3

2023-02-12T08:36:16

Add more ignore rules - for clangd - and compile_commands.json for it

c257e16f

2023-02-12T08:34:52

test: fix debug locks in case new lock gots old address Refs: #1407

fb900a28

2023-02-12T08:12:20

test: suppress logs from the tests that produce them under normal circumstances

1201bb85

2023-02-12T07:59:17

test: fix TT_* flags values

f0cb4b7f

2023-02-12T07:58:55

Suppress data race for test_ok variable

39be38ff

2023-02-12T07:58:29

Suppress data race for event_debug_created_threadable_ctx_ variable

f9134df7

2023-02-04T15:00:48

Add LEV_OPT_BIND_IPV4_AND_IPV6 flag (#1400) Libevent introduced the LEV_OPT_BIND_IPV6ONLY to pass to evconnlistener_new_bind to make it automatically set the underlying socket as accepting ipv6 requests. This works fine on posix compliant platforms as by the standard every new AF_INET6 socket is created as both supporting ipv6 and ipv4 connections. But on windows the default is the opposite, with the flag IPV6_V6ONLY being always enabled by default. This makes creating a listener to supports both protocols a bit more tricky as winsock doesn't allow changing this flag after evconnlistener_new_bind does all the initial setup because as stated in the docs, you can't change it after the sonnect connected, so one would have to manually create the socket beforehand and set the flag and then call evconnlistener_new with the socket itself. It would be nice to have libevent keep a consistent behaviour across the platforms in this scenario, maybe or by making it always set IPV6_V6ONLY to false unless LEV_OPT_BIND_IPV6ONLY is passed, in which case it's set to true, or add another flag to forcefully set it to false and keep the system dependent behaviour as default. So this patch add new option for libevent listeners to bind to both - LEV_OPT_BIND_IPV4_AND_IPV6

a5b0ded3

2023-02-04T14:56:53

Add config for vim/nvim

4d85d28a

2023-01-28T13:28:52

Fix pthread detection for regress tests on Android Fixes: #1403

35375101

2023-01-27T08:57:33

Fixes some new warnings under clang-15 - -Wdeprecated-non-prototype /src/le/libevent/strlcpy.c:48:1: warning: a function definition without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype] event_strlcpy_(dst, src, siz) - -Wstrict-prototypes /src/le/libevent/evthread.c:82:70: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes] struct evthread_condition_callbacks *evthread_get_condition_callbacks() - -Wunused-but-set-variable /src/le/libevent/test/regress_buffer.c:130:6: warning: variable 'n' set but not used [-Wunused-but-set-variable] int n = 0; ^

3d138bda

2023-01-27T08:51:56

Allow evdns_base_new to succeed with no nameservers configured (#1389) * evdns-no-ns: Allow evdns_base_new to succeed with no nameservers configured Replace magic numbers with consts for evdns_base_resolv_conf_parse() errors

ebd7e8d7

2023-01-27T08:44:41

Allow evdns_base_new to succeed with no nameservers configured If resolv.conf has no nameservers, evdns_base_new can still succeed with the default of using the name server from localhost matching the man page documentation for resolv.conf.

kc3-lang/libevent

Log