Log

Author Commit Date CI Message
Nick Mathewson 63d37bdd 2011-05-20T23:24:43 Merge remote-tracking branch 'origin/patches-2.0'
Kevin Ko 0848814a 2011-05-20T23:23:44 Fix failing assertion introducd in commit 0d6622e Patch in question: - Fix the case when failed evhttp_make_request() leaved request in the queue. - http://levent.git.sourceforge.net/git/gitweb.cgi?p=levent/libevent;a=commit;h=0d6622e The above patch introduces a failing assertion in evhttp_connection_fail(). This happens because the patch defers the assignment of the outstanding request to the evcon->requests list, while evhttp_connection_fail() assumes that the request lies in the list. One scenario in which this can happen is when the request list is empty and a connection is made to an unreachable host. The assertion will then fail after bufferevent_socket_connect() errors out (with ENETUNREACH in my case).
Nick Mathewson af5f1860 2011-05-20T23:08:25 Merge remote-tracking branch 'ellzey/feature/evhttp_parse_speedup'
Nick Mathewson cbab7dad 2011-05-20T14:21:55 Merge remote-tracking branch 'origin/patches-2.0'
Dave Hart 09d39a12 2011-05-20T14:18:08 Fix compilation with GCC 2, which had no __builtin_expect
Nick Mathewson 6b23518d 2011-05-06T11:06:11 Merge remote-tracking branch 'origin/patches-2.0'
Sebastian Hahn 66193853 2011-05-05T16:27:55 Correctly detect openssl on windows
Sebastian Hahn 5786b91e 2011-05-05T18:02:42 Fix a compile warning with zlib 1.2.4 and 1.2.5 I took this fix from Tor (commit 1a52e39c22d5, author Nick Mathewson, Copyright (c) 2007-2011, The Tor Project, Inc.) and adapted it slightly for libevent.
Mark Ellzey aee1a97d 2011-05-06T08:48:54 Performance tweak to evhttp_parse_request_line. Method parsing has been tweaked out to use a lookup table instead of multiple branching. In our testing it has increased performance by a fair bit.
Sebastian Hahn ceb03b90 2011-05-05T15:51:11 Move the win32 detection in configure.in
Sebastian Hahn 292092eb 2011-05-05T15:49:38 Use OPENSSL_LIBS in Makefile.am
Nick Mathewson 7889c43e 2011-05-04T16:23:02 Merge remote-tracking branch 'origin/patches-2.0'
Peter Rosin 7b819f2d 2011-05-04T16:37:58 Libtool brings in the dependencies of libevent_openssl.la automatically
Peter Rosin 274dd036 2011-05-04T16:34:28 libssl depends on libcrypto, not the other way around.
Nick Mathewson 96107974 2011-05-03T14:29:44 Merge remote-tracking branch 'origin/patches-2.0'
Nick Mathewson d11e9e0f 2011-05-03T14:22:48 Oops; that new unit test breaks for epoll. Fix it.
Nick Mathewson 28317a08 2011-05-03T13:54:57 Fix a warn-and-fail bug in kqueue by providing kevent() room to report errors Apparently, kevent fails gracefully if there is not enough space in its output events array to report every _event_... but it just dies and returns -1 if there is not enough space to report every _error_. There are a couple of possible fixes here. One would to handle -1 returns from kevent better by re-growing the array and retrying... but that seems a little error prone. Instead, I'm just going to say that the events array must be large enough to handle all the errors. This patch also adds a unit test designed to make sure that our many-events-out code works even if not all the events are added at once.
Nick Mathewson 22d50db8 2011-05-02T23:22:34 Merge remote-tracking branch 'origin/patches-2.0'
Nick Mathewson 9556a7d1 2011-05-02T23:22:09 Add missing words to EVLOOP_NONBLOCK documentation
Nick Mathewson 1cae2260 2011-04-27T21:28:32 Merge remote-tracking branch 'origin/patches-2.0'
Nick Mathewson e7529fa4 2011-04-27T21:28:11 Bump version to 2.0.11-stable-dev
Nick Mathewson fc9bc656 2011-04-27T20:26:38 Merge remote-tracking branch 'origin/patches-2.0'
Nick Mathewson d4d55196 2011-04-27T20:25:57 Increment version number to 2.0.11-stable
Nick Mathewson aaa80ed4 2011-04-27T20:17:34 Merge remote-tracking branch 'origin/patches-2.0'
Nick Mathewson 8255fda7 2011-04-27T20:15:20 Add more people to the acknowledgments
Nick Mathewson 6c2ef970 2011-04-27T20:07:13 Merge remote-tracking branch 'origin/patches-2.0'
Nick Mathewson d30466fc 2011-04-27T20:03:46 Changelog for 2.0.11-stable
Nick Mathewson 614b9bd1 2011-04-26T23:48:31 Merge remote-tracking branch 'origin/patches-2.0'
Nick Mathewson e49e64e7 2011-04-26T23:42:01 Fix clang warning when resetting connection This was a regression on 2.0.10-stable: clang was warning about values that were unused (because event_debug wasn't using them unless USE_DEBUG was defined). Found by Sebastian Hahn.
Nick Mathewson cea45590 2011-04-24T22:56:16 Merge remote-tracking branch 'origin/patches-2.0'
Nick Mathewson ea0d019b 2011-04-23T02:35:17 Use AM_CONDITIONAL, not AC_SUBST, to tell automake to build regress For some reason, this makes mingw much happier about building regress.exe by default. No, I'm afraid I don't know why.
Nick Mathewson 18f24ef4 2011-04-23T02:31:59 Merge remote-tracking branch 'origin/patches-2.0'
Nick Mathewson 7739c86d 2011-04-23T02:31:04 Fix msvc build: it needed to know about _EVENT_HAVE_STRUCT_SOCKADDR_STORAGE
Nick Mathewson 53d1e450 2011-04-23T01:48:11 Try to fix up CHECK_REGRESS hack to not break on win32
Nick Mathewson dd68cce4 2011-04-23T01:47:43 Add missing header for regress_http compilation on win32
Nick Mathewson 99f147d9 2011-04-23T01:47:11 Merge branch '20_iocp_conn_sockopt' into patches-2.0
Nick Mathewson 52f9baee 2011-04-22T10:54:02 call setsockopt correctly on connecting() IOCP-bufferevents so shutdown() will work
Nick Mathewson 614a1712 2011-04-22T23:46:25 Merge remote-tracking branch 'origin/patches-2.0' Conflicts: evthread.c
Sebastian Hahn 646f9feb 2011-04-23T02:22:08 Zero a struct sockaddr_in before using it Found by Dave Heart
Sebastian Hahn 744c7456 2011-04-23T02:20:59 Remote some dead code from dns-example.c Found by Dave Heart
Sebastian Hahn 93a1abb3 2011-04-11T18:26:48 Check return value of evbuffer_add_cb in tests Caught by clang's static analyzer
Sebastian Hahn 4bac793e 2011-04-11T18:03:02 Be nice and "handle" error return values in sample code Caught by clang's static analyzer
Sebastian Hahn 48c44a6d 2011-04-11T17:48:23 Refactor test_getaddrinfo_async_cancel_stress() Turns out it didn't need an event base set up. Spotted by clang's static anaylzer
Sebastian Hahn 65707d7c 2011-04-11T17:40:14 add some (void) casts for unused variables All these places already have an XXX marker, so we know we need to fix them later. Let's not clutter the static analysis results with them.
Sebastian Hahn b693c324 2011-04-11T17:32:03 Actually send NULL request in http_bad_request_test Issue caught by clang's static analyzer
Sebastian Hahn 3819b62c 2011-04-11T17:23:08 Add a forgotten return value check in the unit tests Spotted by clang's static analyzer
Sebastian Hahn b0ff7eb5 2011-04-10T14:03:39 Add an assert to appease clang's static analyzer It got confused because in EVLOCK_ASSERT_LOCKED(lock) there is an if (lock) check.
Sebastian Hahn 5208544e 2011-03-14T04:24:33 Fix possible NULL-deref in evdns_cancel_request The clang static analyzer complained that base might be dereferenced without being set, but this patch should fix another dereference issue.
Sebastian Hahn 12311ff4 2011-03-14T04:13:55 Add a forgotten NULL check to evhttp_parse_headers Issue detected by the clang static analyzer
Sebastian Hahn ad9ff583 2011-04-10T17:23:11 Fix compilation under LLVM/clang with --enable-gcc-warnings When compiling using clang (2.9 or lower) do not enable -Wnormalized=id or -Woverride-init when --enable-gcc-warnings or --enable-gcc-warnings-advisory is set as these options are unsupported. This commit is based on a patch for Tor (git commit 56bdc844ba68ac0911efc7ad3398f1eafeaaac76 by Steven Murdoch), Copyright (c) 2007-2011, The Tor Project, Inc.
Nick Mathewson 34631be0 2011-04-21T17:36:30 Merge remote-tracking branch 'origin/patches-2.0'
Nick Mathewson b4f89f00 2011-04-21T17:33:13 Fix a memory leak on win32 socket->event map. This would lose some memory every time an event_base was freed on win32. Found by Dimitre Piskyulev.
Nick Mathewson 364291e9 2011-04-21T17:11:41 Handle calloc failure in evdns. (Found by Dave Hart)
Nick Mathewson 169eca7b 2011-04-21T13:38:29 Merge remote-tracking branch 'origin/patches-2.0'
Nick Mathewson dde3b739 2011-04-21T13:30:22 Merge branch '20_evdns_circular_list_patch' into patches-2.0
Nick Mathewson 00e91b3c 2011-04-20T13:27:31 Fix a crash bug in evdns server circular list code Really, this should use a circleq. That's a change for 2.1, though.
Nick Mathewson d28fc528 2011-04-14T14:20:09 Merge remote-tracking branch 'origin/patches-2.0'
Nick Mathewson 2e9f6655 2011-04-14T14:15:13 Fix a couple of memory leaks in samples/http-server.c. Found by Dave Hart.
Nick Mathewson 3417f680 2011-04-13T11:20:30 Avoid a free(NULL) if out-of-memory in evdns_getaddrinfo. Found by Dave Hart
Nick Mathewson bfdda265 2011-04-05T17:22:36 Merge remote-tracking branch 'origin/patches-2.0'
Nick Mathewson 1a21d7b8 2011-04-05T17:21:12 Fix the check for multicast or broadcast addresses in evutil_check_interfaces First of all, it is totally okay to have an address end with .255, depending on what your netmask is, so we shouldn't reject a local address if it ends with .255. Second, our check for ending with .255 was broken. So was our check for class-d addresses. Found by Dave Hart.
Nick Mathewson d7c0ffa1 2011-04-05T17:19:00 Merge remote-tracking branch 'origin/patches-2.0'
Nick Mathewson fc7f34bd 2011-04-05T17:17:51 Merge branch '20_socktype_protocol_nomem' into patches-2.0
Nick Mathewson 637d17a1 2011-04-05T16:32:39 Check for allocation failures in apply_socktype_protocol_hack
Nick Mathewson ddcca176 2011-04-04T15:09:47 Merge remote-tracking branch 'origin/patches-2.0'
Tomash Brechko 0d6622e2 2011-03-31T19:11:10 Fix the case when failed evhttp_make_request() leaved request in the queue.
Tomash Brechko 218cf197 2011-03-24T15:52:34 Fix subtle recursion in evhttp_connection_cb_cleanup().
Tomash Brechko 272823f8 2011-03-23T12:05:33 Reset outgoing connection when read data in idle state. Imagine server side is buggy and miscalculates Content-Length: in the reply. Data arriving in idle state shouldn't make us crash, instead we can just reset the connection.
Nick Mathewson 7a91f732 2011-03-23T16:34:58 Merge remote branch 'origin/patches-2.0'
Nick Mathewson c6213591 2011-03-23T16:32:42 Add comment to configure.in to explain gc-sections test logic (Basically, we need access to conftest.err for the test to work properly.)
Dave Hart 6bb23e4b 2011-03-23T16:22:57 Fix for --gc-sections on NetBSD This patch fixes http://bugs.ntp.org/1844, works around http://gnats.netbsd.org/cgi-bin/query-pr-single.pl?number=40401, by improving the test for support of --gc-sections to run a program which reads a file using stdio built with --gc-sections, instead of simply link the binary. This catches the buggy linker as the garbage collection removes a tag NetBSD uses to distinguish its own elf binaries from Linux ones, causing it to treat conftest as a Linux binary and run it with the wrong syscall table.
Dave Hart b5a1f9f7 2011-03-23T16:22:24 Fix make distcheck & installation of libevent 1 headers libevent/Makefile.am corrects a typo (thanks to Harlan for spotting it once we realized make distcheck was broken when building the libevent tearoff). The result was the include/ev*.h were not distributed nor installed whether or not --disable-libevent-install was used. This was introduced with the final round (3/3) of --disable-libevent-install patch from me.
Nick Mathewson 4ab2a89d 2011-03-12T12:12:35 Merge remote branch 'origin/patches-2.0'
Christophe Fillot 4b8f02f1 2011-03-12T12:08:19 Fix incorrect assertions and possible use-after-free in evrpc_free() Original description: The following patch fixes incorrect assertions in evrpc_free(): evrpc_unregister_rpc() and evrpc_remove_hook() return 0 for success. Also, in evrpc_unregister_rpc(), it is better to free RPC structure at the end: evrpc_free() uses rpc->uri as "name" parameter when calling evrpc_unregister_rpc(), then rpc->uri is freed, but we have "registered_uri = evrpc_construct_uri(name)". So at this time "name" is invalid.
Nick Mathewson f28084dd 2011-03-07T23:18:07 munge the debug_lock signature before freeing it: it might help us catch use-after-free
Dave Hart b4a29c0a 2011-03-07T23:08:42 Add a magic number to debug_locks to better catch lock-coding errors. Original description by Dave Hart: [This patch contains] the addition of a signature field to debug_lock initialized by the alloc routine and verified by the rest, to catch invalid lock pointers sooner. That helped me track down a nasty problem I had before adding the time.h include to libevent-internal.h, where different .c files had different ideas of whether event_base had a tod_tv_cache member depending on which included time.h before libevent-internal.h.
Nick Mathewson 2a83ecc8 2011-03-07T23:01:54 In the 2.1 branch, let's try out lazy gettimeofday/clock_gettime comparison For now, we'll only check for gettimeofday jumps once every 5 seconds. Let's see how that works. This reverts commit 5209fadfd07af3f3379ac607582c37933b33e044.
Nick Mathewson 4560b31b 2011-03-07T23:00:45 Merge remote branch 'origin/patches-2.0' Conflicts: event-internal.h
Nick Mathewson 5209fadf 2011-03-07T22:59:19 Disable lazy gettimeofday/clock_gettime comparison for now
Nick Mathewson 9193dc4e 2011-03-07T22:45:10 Merge branch '20_timescale' into patches-2.0
Nick Mathewson c5389594 2011-03-07T21:59:47 Merge remote branch 'origin/patches-2.0'
Nick Mathewson c8baac90 2011-03-07T21:55:47 Followup for Tomash Brechko's http patch This patch makes bufferevent_disable_hard() non-public, and adds a comment about what it's for and why it's used.
Tomash Brechko 5dc56628 2011-02-24T12:30:40 Workaround libevent bug https://sourceforge.net/tracker/index.php?func=detail&aid=3078187&group_id=50884&atid=461324 The problem is that bufferevent_disable() doesn't disable EV_WRITE when 'connecting' flag is set. However from evhttp_connection_reset() we want to disable EV_WRITE for sure (we are closing the socket next). So we add bufferevent_disable_hard(), which acts like bufferevent_disable(), but resets 'connecting' flag before the call to the actual handler. TODO: bufferevent_disable_hard() shouldn't be public, remove it from event2/bufferevent.h.
Nick Mathewson a459ef70 2011-03-03T15:34:22 Have event_base_gettimeofday_cached() always return wall-clock time Based on code by Dave Hart
Nick Mathewson 74bf57a6 2011-03-03T12:58:06 Merge remote-tracking branch 'origin/patches-2.0'
Dave Hart ab008c7d 2011-03-03T12:57:17 Make --no-libevent-install apply to event1 headers too
Nick Mathewson 83fb674a 2011-02-25T10:42:58 Merge remote branch 'origin/patches-2.0'
Dave Hart b5ab9555 2011-02-25T10:35:12 Make --no-libevent-install apply to headers too
Nick Mathewson 975eacad 2011-02-23T11:25:09 Merge remote branch 'origin/patches-2.0'
Sebastian Hahn 3f79a3a0 2011-02-23T09:19:08 Continue AM_CFLAGS to AM_CPPFLAGS correction 9c469db300e1b270a93c6b04c1709ac0f7751136 had started with the conversion but left out another instance of incorrectly used AM_CFLAGS. Dave Hart provided the suggestion for this fix.
Nick Mathewson e2e3c322 2011-02-22T18:55:05 Merge remote branch 'origin/patches-2.0'
Nick Mathewson 5dc200b7 2011-02-22T18:53:55 Merge branch '20_uri_nonconformant' into patches-2.0
Constantine Verutin 6350e6c4 2011-02-22T17:52:50 Add new evhttp_{connection_}set_timeout_tv() functions to set finger-grained http timeouts
Nick Mathewson a11c30b5 2011-02-22T17:41:27 Merge remote branch 'origin/patches-2.0' This branch is the big one that merges all the ntp folks' changes Conflicts: configure.in
Nick Mathewson 2fba21d8 2011-02-22T16:20:42 Make -ffunction-sections off-by-default in 2.0.x I don't see how this can burn anybody, but I don't want to take chances: new build options are something that should be done in an alpha. To turn -ffunction-sections on, pass --enable-function-sections to configure.
Nick Mathewson 7d913f4c 2011-02-22T16:14:16 Remove nonfunctional enable_libevent_(install|regress)_def variables
Nick Mathewson 15b2408c 2011-02-22T16:13:49 Use $(), not @@, for LIBEVENT_GC_SECTIONS
Nick Mathewson f95bafb6 2011-02-22T00:34:49 Be explicit about how long event loops run in event.h documentation
Nick Mathewson 039b9bd0 2011-02-22T00:31:56 Use %s with printf in test.sh
Dave Hart 9c469db3 2011-02-13T02:27:42 Correct an AM_CFLAGS to an AM_CPPFLAGS in test/Makefile.am