kc3-lang/libevent

---

Log

Author	Commit	Date	CI	Message
	918e9c5e	2010-01-23T16:38:36		Fix a number of warnings from gcc -pedantic
	e2ca403f	2010-01-23T16:23:45		Make it compile under gcc --std=c89.
	ff3f6cd4	2010-01-22T16:14:49		Check more internal event_add() calls for failure Most of these should be unable to fail, since adding a timeout generally always works. Still, it's better not to try to be "too smart for our own good here." There are some remaining event_add() calls that I didn't add checks for; I've marked those with "XXXX" comments.
	7296971b	2009-12-29T16:38:03		Detect setenv/unsetenv; skip main/base_environ test if we can't fake them. Previously, we assumed that we would have setenv/unsetenv everywhere but WIN32, where we could fake them with putenv. This isn't so: some other non-windows systems lack setenv/unsetenv, and some of them lack putenv too. The first part of the solution, then, is to detect setenv/unsetenv/ putenv from configure.in, and to fake setenv/unsetenv with putenv whenever we have the latter but not one of the former. But what should we do when we don't even have putenv? We could do elaborate tricks to manipulate the environ pointer, but since we're only doing this for the unit tests, let's just skip the one test in question that uses setenv/unsetenv.
	97a8c790	2010-01-22T00:34:21		Fix compilation of rate-limit code when threading support is disabled
	26e1b6f2	2010-01-21T01:51:40		Remove some commented-out code in evutil
	8d4aaf90	2010-01-20T12:56:54		Don't use a bind address for nameservers on loopback If the user sets a bind address to use for nameservers, and a nameserver happens to be on 127.0.0.1, the nameserver will generally fail. This patch alters this behavior so that the bind address is only applied when the nameserver is on a non-loopback address.
	06839503	2010-01-19T14:01:36		Functions to access more fields of struct event. Once event_assign() or event_new() had been called, there was no way to get at a copy of the event's callback, callback argument, or configured events. This patch adds an accessor function for each, and an all-fields accessor for code that wants to re-assign one field of an event. This patch also adds a function to return sizeof(struct event), so that code with intense RAM needs can still retain ABI compatibility between versions of Libevent without having to heap-allocate every struct event individually. The code here was first proposed by Pavel Pisa.
	70670067	2010-01-19T13:55:53		Add a LICENSE file so people can find our license easily For what it's worth, we are aware that "Copyright $YEAR $NAME" is sufficient notice of copyright on software under US law and Internationally, and saying Copyright (c) $YEAR $NAME is a bit nutty. The character sequence (c) has never been ruled to have the same force in US law as the actual copyright symbol, and that neither of these US-specific symbols adds anything of value beyond saying "Copyright" since the Berne convention took effect in the US back in 1989. Similarly, saying "all rights reserved" doesn't do anything magical unless your software goes in a time-warp back to when the Buenos Aires Convention was the general rule. (And what will they run it on back then?) And what would even lead you to say "All Rights Reserved" when you're explicitly granting most of those rights to anybody receiving the work in accordance with the 3-clause BSD license? But still the FOSS community retains these ritual notations out of a kind of cargo-cult lawyering. Who knows? Perhaps one day, if we write our copyright notices ineptly enough, John Frum will come and give us a DFSG-compatible license that everybody can get behind. (Also, I am not a lawyer. The above should not be taken as legal advice. -- Nick)
	4b9f307d	2010-01-15T10:26:25		Add a forgotten header (changelist-internal.h)
	85464579	2010-01-14T23:28:16		Merge commit 'niels/http_dns'
	78a50fe0	2010-01-14T17:39:54		forgot to add void to test function
	26714ca1	2010-01-14T17:05:00		add a test for evhttp_connection_base_new with a dns_base
	b8226390	2010-01-14T16:53:25		move dns utility functions into a separate file so that we can use them for http testing
	5032e526	2010-01-14T15:42:07		do not use a function to assign the evdns base; instead assign it via evhttp_connection_base_new() which is a new function introduced in 2.0
	3225dfb9	2010-01-14T17:04:08		Remove kqueue->pend_changes. Since we're no longer writing directly to it from add/del, we don't need to worry about it changing as kq_dispatch releases the lock. We would make it a local variable, except that we wouldn't want to malloc and free it all the time.
	45e5ae37	2010-01-14T16:31:05		Make kqueue use changelists. This fixes a bug in kqueue identified by Charles Kerr and various Transmission users, where adding and deleting an event in succession would make the event get reported, even if we didn't actually want to see it. Of course, this also makes the array of changes passed to kevent smaller, which could help performance.
	27308aae	2010-01-14T16:30:40		Changelist code to defer event changes until just before dispatch This is necessary or useful for a few reasons: 1) Sometimes applications will add and delete the same event more than once between calls to dispatch. Processing these changes immediately is needless, and potentially expensive (especially if we're on a system that makes one syscall per changed event). Yes, this actually happens in practice for nonpathological code, such as in cases where the user's callback conditionally re-adds a non-persistent event, or where draining a buffer turns off writing and invokes a user callback which adds more data which in turn re-enabled writing. 2) Sometimes we can coalesce multiple changes on the same fd into a single syscall if we know about them in advance. For example, epoll can do an add and a delete at the same time, but only if we have found out about both of them before we tell epoll. 3) Sometimes adding an event that we immediately delete can cause unintended consequences: in kqueue, this makes pending events get reported spuriously.
	c698b77d	2009-12-30T00:11:27		Allow http connections to use evdns for hostname looksups. This was as simple as using bufferevent_connect_hostname instead of calling connect() ourself, which already knows how to use an evdns_base if it gets one. Untangling the bind code might be a little trickier.
	a334b31c	2010-01-14T14:46:16		More unit tests for getaddrinfo_async: v4timeout and cancel. One covers the case where the v4 request times out but the v6 request doesn't. The other makes sure that cancelling a request actually works.
	94131e92	2010-01-12T15:58:36		Fix test.sh on shells without echo -n Some systems have a version of /bin/sh whose builtin echo doesn't support the -n option used in test/test.sh. /bin/echo, however, usually does. This patch makes us use /bin/echo for echo -n whenever it is present. Also, our use of echo -n really only made sense when suppressing all test output. Since test output isn't suppressed when logging to a file, this pach makes us stop using echo -n when logging to a file.
	b9f43b23	2010-01-11T20:47:36		Add a comment on evthread_enable_lock_debuging.
	6cc79c6b	2010-01-11T19:04:11		Add unit-test for bad_request bug fixed in 1.4 recently. This is a partial forward-port from 4fd2dd9d83a000b6. There's no need to forward-port the bugfix, since the test passes with http.c as-is. I believe we fixed this while we were porting evhttp to bufferevent. --nickm
	510ab6bc	2009-12-30T19:24:39		Comestic changes in evconnlistener_new(), new_accepting_socket(), accepted_socket_invoke_user_cb() and iocp_listener_enable().
	fec66f96	2009-12-30T19:22:23		Improved error handling in evconnlistener_new_async(). Also keeping the fd open because it is not opened by this function, so the caller is responsible for closing it. Additionally, since evconnlistener_new_bind() creates a socket and passes it to the function above, it required error checking to close the same socket.
	4367a33a	2009-12-30T19:09:14		Fixed a fd leak in start_accepting(), plus cosmetic changes
	2f33e00a	2010-01-01T04:13:05		Fixed a memory leak on windows threads implementation. The CRITICAL_SECTION was not being free'd in evthread_win32_lock_free().
	66c02c78	2010-01-08T04:02:19		Look at the proper /etc/hosts file on windows. This is harder than it might initially seem, since the proper filename depends on what the admin has decided to call the windows system directory, which for all we know might be Q:\tralfamidore\slartibartfast. And of course, this being windows, there are twelve ways to do it, where you can pick a nice one or a portable one, but not a really nice portable one.
	72dd6667	2009-12-07T17:21:41		evdns_getaddrinfo() now supports the /etc/hosts file. The regular blocking evutil_getaddrinfo() already supported /etc/hosts by falling back to getaddrinfo() or gethostbyname(). But evdns_getaddrinfo() had no such facility. Now it does. The data structure here isn't very clever. I guess people with huge /etc/hosts files will either need to get out of the 1980s, or submit a patch to this code so that it uses a hashtable instead of a linked list. Includes basic unit tests.
	0f7144fd	2009-12-07T17:21:13		Refactor code from evdns into a new internal "read a file" function.
	eaaf27f1	2010-01-06T18:41:46		Enable branch-prediction hints with EVUTIL_UNLIKELY. This had been accidentally disabled. Since it seems to work with GCC, I'm turning it back on when GCC is present.
	29151e65	2010-01-06T18:42:59		Fix byte counts when mixing deferred and non-deferred evbuffer callbacks. This patch finishes 390e0561, which was somehow committed in a half-finished state. It solves a failing unit test on windows.
	ba2945f9	2010-01-06T17:59:44		Merge branch 'ratelimit' Conflicts: bufferevent_async.c
	0546ce11	2009-12-30T05:03:54		Eradicated the last free() call. Let mm_free() take care of deallocation.
	165d30e3	2009-12-30T14:29:56		Fix compilation of rate-limiting code on win32.
	885b4273	2009-12-30T13:50:52		Fix test-ratelim compilation on Linux. I'd forgotten to include time.h, and to link against libm.
	78ed0972	2009-12-30T11:58:36		Never believe that we have pthreads on win32, even if gcc thinks we do. Apparently some newer versions of mingw provide a fake pthreads api to let applications work even if they don't know about windows threading. That's nice, but we aren't one of those.
	2e8eeea3	2009-12-29T19:50:03		Fix crash bugs when a bufferevent's eventcb is not set. In many places throughout the code, we called _bufferevent_run_eventcb without checking whether the eventcb was actually set. This would work fine when the bufferevent's callbacks were deferred, but otherwise the code would segfault. Strangely, we always remembered to check before calling the _bufferevent_run_{read,write}cb functions. To prevent similar errors in the future, all of _buferevent_run_{read,write,event}cb now check to make sure the callback is actually set before invoking or deferring the callback. This patch also removes the now-redundant checks for {read,write}cb.
	0b151a9f	2009-12-29T18:11:52		Whitespace fixes in test.sh
	7dfbe94a	2009-12-29T18:07:51		Allow test.sh to be run as ./test/test.sh
	c382de64	2009-12-29T17:59:55		Allow the user to redirect the verbose output of test/test.sh to a file By default, the test.sh script still suppresses the output of all the tests it invokes. Now, however, you can have that output written to a file specified in the TEST_OUTPUT_FILE shell variable.
	1e56a32d	2009-12-29T16:04:16		Make the initial nameserver probe timeout configurable. When we decide that a nameserver is down, we stop sending queries to it, except to periodically probe it to see if it has come back up. Our previous probe sechedule was an ad-hoc and hard-wired "10 seconds, one minute, 5 minues, 15 minutes, 1 hour, 1 hour, 1 hour...". There was nothing wrong with having it be ad-hoc, but making it hard-wired served no good purpose. Now the user can set the initial timeout via a new "initial-probe-timeout:" option; future timeouts back off by a factor of 3 on every failure to a maximum of 1 hour. As a side-benefit, this lets us cut the runtime of the dns/retry test from about 40 seconds to about 3 seconds. Faster unit tests are always a good thing.
	ee4953f8	2009-12-29T16:03:30		Fix the code that allowed DNS options to not end with : We tried to fix this in 0.2.0.3-alpha, but our fix was buggy.
	d0939d2b	2009-12-29T16:21:26		Introduced evutil_make_socket_closeonexec() to preserve fd flags for F_SETFD. Use this to eliminate the various macros that called F_SETFD throughout the code.
	4df7dbcb	2009-12-29T16:19:24		Adjusted fcntl() retval comparison on evutil_make_socket_nonblocking(). Apparently, a successful return value on F_SETFL is "anything but -1".
	82743794	2009-12-24T17:47:14		Do not make bufferevent_setfd implicitly disable EV_READ and EV_WRITE. This obviates the need for BEV_SUSPEND_CONNECTING, and good riddance.
	f0c0124e	2009-12-23T07:54:13		Testing code for bufferevent rate-limiting. This is not part of the regression tests, since running it necessarily takes a while. There is a new test-ratelim test; run it with '-h' for an argument to see its options.
	737c9cd8	2009-11-27T13:16:54		Rate-limiting for bufferevents; group and individual limits are supported. The fairness algorithms are not the best, not every bufferevent type is supported, and some of the locking tricks here are simply absurd. Still, this code should be a good first step.
	47854a80	2009-12-28T01:40:37		Expose our cached gettimeofday value with a new interface I've got a two use case that wants this for a fairly sensible purpose: one external and on internal.
	5a43df82	2009-12-28T16:03:47		Improve readability of evutil_unparse_protoname()
	0d64051f	2009-12-28T16:01:59		Fix a bogus free in evutil_new_addrinfo()
	24fb502f	2009-12-28T16:01:12		Fix an fd leak in evconnlistener_new_bind().
	4c8b7cdc	2009-12-28T16:00:05		Make evutil_make_socket_nonblocking() leave any other flags alone. Fixes bug 2922121
	fee2c779	2009-12-28T15:53:01		Fix compilation of devpoll.c by adding missing thread includes. (Bug 2922156)
	a47d88d7	2009-12-23T07:53:19		Replace some cases of uint32_t with ev_uint32_t. Spotted by Roman Puls.
	4a5b5343	2009-12-23T07:48:43		Do not ignore bufferevent_enable(EV_READ) before bufferevent_connect(). Previously, we weren't remembering that we wanted to re-add the read event once the connect was finished. Now we are.
	390e0561	2009-12-22T15:52:02		Fix up behavior of never-defered callbacks a little
	5846bf6c	2009-12-22T15:51:39		Simplify the read high-watermark checking.
	c69d5a5d	2009-12-22T12:03:46		Remove the contents of WIN32-Prj as unmaintained. Makefile.nmake is now the preferred way to build with MSVC; the project files haven't worked properly in ages.
	292467c0	2009-12-22T00:58:52		Use evutil_socket_t, not int, when logging socket errors.
	c51bb3c3	2009-12-21T16:36:40		Fix a few locking issues on windows.
	5a112d3c	2009-12-18T23:37:50		Set all instances of the version number correctly. Note that we've made two subtle mistakes: we are supposed to suffix any non-released version with "-dev", and we're supposed to use the last byte of the numeric version to indicate whether we have done this. For example, when 2.0.4-alpha is released, its numeric versin will be 0x 02 00 04 00. As soon as we tag it, we will change the version in the git repository to 2.0.4-alpha-dev, whose numeric version will be 0x 02 00 04 01 or something.
	67995270	2009-12-18T17:04:37		Drop install-sh from our git repo: a mismatched version could break "make dist"
	a773df54	2009-12-18T16:24:41		Fix a segfault when freeing SSL bufferevents in an unusual order Have container bufferevents hold a reference to their underlying bufferevents. (Commit message and minor revisions by nickm.)
	a6adeca7	2009-12-17T12:38:46		Fix a segfault when writing a very fragmented evbuffer onto an SSL Fixes bug 2916328.
	f6430ac1	2009-12-08T17:02:24		Update sample/signal-test.c to use newer APIs and not leak.
	ea6b1df2	2009-12-08T15:38:34		Only define _GNU_SOURCE if it is not already defined.
	70cdfe49	2009-12-06T02:59:19		Fix compile on Snow Leopard with gcc warnings enabled
	7ae94450	2009-12-04T16:37:43		Fix a snow leopard compile warning in the unit tests. Reported by Sebastian Hahn.
	0d744aa1	2009-11-23T18:34:32		Refactor our 'suspend operation' logic on bufferevents. There are lots of things we do internally in bufferevents to indicate "the user would like this operation to happen, but we aren't going to try until some other condition goes away." Our logic here has gotten entirely too complicated. This patch tries to fix that by adding the idea of 'suspend flags' for read and write. To say "don't bother reading or writing until condition X no longer holds," bufferevent_suspend_read/write(bev, BEV_SUSPEND_X). When X no longer holds, call bufferevent_unsuspend_read/write(bev, BEV_SUSPEND_X). Right now, only the read-watermark logic uses this.
	438f9ed2	2009-11-23T15:53:24		Add the abilitity to mark some buffer callbacks as never-deferred.
	689fc091	2009-11-28T11:31:39		New EVTHREAD_TRY_LOCK function to try to grab a lock.
	2b7abf03	2009-12-04T13:49:27		Merge commit 'niels/dnscrash'
	6c7c5799	2009-12-04T10:44:46		Fix a crash when reading badly formatted resolve.conf; from Yasuoka Masahiko
	b62d979b	2009-12-02T01:24:37		Update nmake makefile to build evthread.c
	31687b4d	2009-12-02T01:22:07		Fix regress_iocp.c usage of old lock allocation macros.
	bd6f1bab	2009-12-02T01:15:15		Fix up evthread compilation on windows
	56771a3e	2009-11-29T10:20:46		Valgrind fix: Clear struct kevent before checking for OSX bug. William's original commit message: Valgrind complains on startup because kq_init passes to kevent only a partially initialized structure. The code doesn't expect kevent to look at .fflags, .udata, or .data, I suppose, because it merely tickles the kernel looking for an error response. But perhaps that's unwarranted chuminess (notwithstanding that it's checking for an OS X bug), and needless noise nonetheless.
	0cd3bb9f	2009-11-27T17:22:19		Improved optional lock debugging. There were a couple of places in the code where we manually kept lock counts to make sure we never accessed resources without holding a lock, and that we never released a lock we didn't have. The lock-debugging code already puts counts on _every_ lock when lock debugging is enabled, so there is no need to keep these counts around otherwise. This patch rewrites the ASSERT_FOO_LOCKED macros to all use a common EVLOCK_ASSERT_LOCKED(). We also teach the lock debugging code to keep track of who exactly holds each lock, so that EVLOCK_ASSERT_LOCKED() means "locked by this thread."
	2df1f82b	2009-11-27T16:02:49		Fix an evdns lock violation. Original message: evdns contains a bug related to thread lock. enable thread lock by evthread_use_pthreads() will cause successive evdns_base_resolve_ipv4() (and other resolve functions i think) to hang on EVDNS_LOCK(base) after one or several successful call to evdns_base_resolve_ipv4().
	da1718b2	2009-11-27T16:00:59		Fix a locking bug in event_base_loop() We previously were releasing the lock when we exited the main loop in some ways, but not in others.
	d84d8385	2009-11-27T15:24:32		Fix two use-after-free bugs in unit tests spoted by lock debugging
	76cd2b70	2009-11-27T16:44:47		Stop passing EVTHREAD_READ and EVTHREAD_WRITE to non-rw locks. Previously, our default lock model kind of assumed that every lock was potentially a read-write lock. This was a poor choice, since read-write locks are far more expensive than regular locks, and so the lock API should only use them when we can actually take advantage of them. Neither our pthreads or win32 lock implementation provided rw locks. Now that we have a way (not currently used!) to indicate that we really want a read-write lock, we shouldn't actually say "lock this for reading" or "lock this for writing" unless we mean it.
	347952ff	2009-11-27T15:20:43		Revise the locking API: deprecate the old locking callbacks and add trylock. Previously, there was no good way to request different kinds of lock (say, read/write vs writeonly or recursive vs nonrecursive), or for a lock function to signal failure (which would be important for a trylock mode). This patch revises the lock API to be a bit more useful. The older lock calls are still supported for now. We also add a debugging mode to catch common errors in using the locking APIs.
	e1ffbb82	2009-11-21T01:11:49		Fix memory-leak of signal handler array with kqueue. It turns out that kqueue_dealloc wasn't calling evsig_dealloc() (because it doesn't use the main signal handler logic) so the sh_old array was leaking. This patch also introduces a fix in evsig_dealloc() where we set the sh_old array to NULL when we free it, so that main/fork can pass.
	07e9e9b4	2009-11-20T16:50:55		Parenthesize macro arguments more aggressively
	f32b5750	2009-11-20T16:38:01		Add a warning about the use of event_initialized.
	91fe23fc	2009-11-20T15:46:04		Tolerate code that returns from a fatal_cb. Also, replace more abort() calls with EVUTIL_ASSERT() or event_errx.
	94d00651	2009-11-20T12:56:29		Add stub header for 2.0.4-alpha changelog.
	0af10d56	2009-11-20T12:46:00		Add more people who wrote patches to the acknowledgments The names came from grepping ChangeLog for 'patch/code from/by'.
	0b427268	2009-11-20T12:37:47		Improve the README with more information and links. (Also, try to test out the new commit script.)
	ba340714	2009-11-20T12:17:14		Add a .gitignore file. .gitignore plays the same role in Git as the svn:ignore property does in subversion.
	505040a2	2009-11-20T00:18:35		call it 2.0.3-alpha svn:r1556
	f1691539	2009-11-19T23:08:50		Remove most calls to event_err() in http and deal with memory errors instead svn:r1555
	986500de	2009-11-19T22:02:33		nick found a race condition in the pthreads test case svn:r1554
	b8f222e0	2009-11-19T21:14:31		On FreeBSD and other OSes, connect can return ECONREFUSED immediately; instead of failing the function call, pretend with faileld in the callback. svn:r1553
	bdfe72f3	2009-11-19T00:21:48		Documentation adjustments svn:r1552
	7511b6a9	2009-11-19T00:21:38		Fix a spelling error and remove some dead code svn:r1551
	f070a4ae	2009-11-18T23:18:55		Do the proper hack for the (Open)BSD getaddrinfo quirk. From evutil.c: Some older BSDs (like OpenBSD up to 4.6) used to believe that giving a numeric port without giving an ai_socktype was verboten. We test for this so we can apply an appropriate workaround. If it turns out that the bug is present, then: - If nodename==NULL and servname is numeric, we build an answer ourselves using evutil_getaddrinfo_common(). - If nodename!=NULL and servname is numeric, then we set servname=NULL when calling getaddrinfo, and post-process the result to set the ports on it. We test for this bug at runtime, since otherwise we can't have the same binary run on multiple BSD versions. svn:r1550
	07ce7f99	2009-11-18T21:17:00		Make our failing-connection bufferevent test more tolerant. I thought we had a way to do connect() that would never fail immediately, but always wait for a moment before failing. It turns out that on FreeBSD it can fail immediately. This is not FreeBSD's fault, or even a real bug anywhere but in the unit test. svn:r1549