-
Show log
Commit
-
Hash : e86af4b7
Author :
Date : 2012-04-09T10:46:32
Change evutil_weakrand_() to avoid platform random() This change allows us to avoid perturbing the platform's random(), and to avoid hitting locks on random() in the platform's libc. evutil_weakrand_() is, well, weak, so we choose here an algorithm that favors speed over a number of other possibly desirable properties. We're using a linear congruential generator, and taking our parameters from those shared by the OpenBSD random() implementation, and Glibc's fastest random() implementation. The low bits of a LCG of modulus 2^32 are (notoriously) less random than the higher bits. So to generate a random value in a range, using the % operator is no good; we ought to divide. We add an evutil_weakrand_range_() function to do that. This code also changes the interface of evutil_weakrand_() so that it now manipulates an explicit seed, rather than having the seed in a static variable. This change enables us to use existing locks to achieve thread-safety, rather than having to rely on an additional lock. (Patch by Nicholas Marriott; commit message by Nick Mathewson.)
-
Files
- Makefile.am
- Makefile.nmake
- bench.c
- bench_cascade.c
- bench_http.c
- bench_httpclient.c
- check-dumpevents.py
- regress.c
- regress.h
- regress.rpc
- regress_buffer.c
- regress_bufferevent.c
- regress_dns.c
- regress_et.c
- regress_http.c
- regress_iocp.c
- regress_listener.c
- regress_main.c
- regress_minheap.c
- regress_rpc.c
- regress_ssl.c
- regress_testutils.c
- regress_testutils.h
- regress_thread.c
- regress_util.c
- regress_zlib.c
- rpcgen_wrapper.sh
- test-changelist.c
- test-dumpevents.c
- test-eof.c
- test-fdleak.c
- test-init.c
- test-ratelim.c
- test-ratelim.sh
- test-time.c
- test-weof.c
- test.sh
- tinytest.c
- tinytest.h
- tinytest_demo.c
- tinytest_local.h
- tinytest_macros.h
-
Properties
