Commit 482cf1e12828d273842dfd2b24a6f6c02b0b54ab
2018-09-23T10:26:47
explicit condition
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128
diff --git a/bn_mp_complement.c b/bn_mp_complement.c
index fae3a59..9dfddc3 100644
--- a/bn_mp_complement.c
+++ b/bn_mp_complement.c
@@ -17,7 +17,7 @@
int mp_complement(const mp_int *a, mp_int *b)
{
int res = mp_neg(a, b);
- return res == MP_OKAY ? mp_sub_d(b, 1uL, b) : res;
+ return (res == MP_OKAY) ? mp_sub_d(b, 1uL, b) : res;
}
#endif
diff --git a/bn_mp_tc_and.c b/bn_mp_tc_and.c
index 2969116..02e43ac 100644
--- a/bn_mp_tc_and.c
+++ b/bn_mp_tc_and.c
@@ -20,7 +20,7 @@ int mp_tc_and(const mp_int *a, const mp_int *b, mp_int *c)
int as = mp_isneg(a), bs = mp_isneg(b), s = 0;
mp_int *mx = NULL, _mx, acpy, bcpy;
- if (as || bs) {
+ if ((as != MP_NO) || (bs != MP_NO)) {
bits = MAX(mp_count_bits(a), mp_count_bits(b));
res = mp_init_set_int(&_mx, 1uL);
if (res != MP_OKAY) {
@@ -33,7 +33,7 @@ int mp_tc_and(const mp_int *a, const mp_int *b, mp_int *c)
goto end;
}
- if (as) {
+ if (as != MP_NO) {
res = mp_init(&acpy);
if (res != MP_OKAY) {
goto end;
@@ -46,7 +46,7 @@ int mp_tc_and(const mp_int *a, const mp_int *b, mp_int *c)
}
a = &acpy;
}
- if (bs) {
+ if (bs != MP_NO) {
res = mp_init(&bcpy);
if (res != MP_OKAY) {
goto end;
diff --git a/bn_mp_tc_div_2d.c b/bn_mp_tc_div_2d.c
index 88aa2f8..3c617ef 100644
--- a/bn_mp_tc_div_2d.c
+++ b/bn_mp_tc_div_2d.c
@@ -17,7 +17,7 @@
int mp_tc_div_2d(const mp_int *a, int b, mp_int *c)
{
int res;
- if (!mp_isneg(a)) {
+ if (mp_isneg(a) == MP_NO) {
return mp_div_2d(a, b, c, NULL);
}
@@ -27,7 +27,7 @@ int mp_tc_div_2d(const mp_int *a, int b, mp_int *c)
}
res = mp_div_2d(c, b, c, NULL);
- return res == MP_OKAY ? mp_sub_d(c, 1uL, c) : res;
+ return (res == MP_OKAY) ? mp_sub_d(c, 1uL, c) : res;
}
#endif
diff --git a/bn_mp_tc_or.c b/bn_mp_tc_or.c
index d3f1100..549a328 100644
--- a/bn_mp_tc_or.c
+++ b/bn_mp_tc_or.c
@@ -20,7 +20,7 @@ int mp_tc_or(const mp_int *a, const mp_int *b, mp_int *c)
int as = mp_isneg(a), bs = mp_isneg(b), s = 0;
mp_int *mx = NULL, _mx, acpy, bcpy;
- if (as || bs) {
+ if ((as != MP_NO) || (bs != MP_NO)) {
bits = MAX(mp_count_bits(a), mp_count_bits(b));
res = mp_init_set_int(&_mx, 1uL);
if (res != MP_OKAY) {
@@ -33,7 +33,7 @@ int mp_tc_or(const mp_int *a, const mp_int *b, mp_int *c)
goto end;
}
- if (as) {
+ if (as != MP_NO) {
res = mp_init(&acpy);
if (res != MP_OKAY) {
goto end;
@@ -46,7 +46,7 @@ int mp_tc_or(const mp_int *a, const mp_int *b, mp_int *c)
}
a = &acpy;
}
- if (bs) {
+ if (bs != MP_NO) {
res = mp_init(&bcpy);
if (res != MP_OKAY) {
goto end;
diff --git a/bn_mp_tc_xor.c b/bn_mp_tc_xor.c
index e1de859..771cfd5 100644
--- a/bn_mp_tc_xor.c
+++ b/bn_mp_tc_xor.c
@@ -20,7 +20,7 @@ int mp_tc_xor(const mp_int *a, const mp_int *b, mp_int *c)
int as = mp_isneg(a), bs = mp_isneg(b), s = 0;
mp_int *mx = NULL, _mx, acpy, bcpy;
- if (as || bs) {
+ if ((as != MP_NO) || (bs != MP_NO)) {
bits = MAX(mp_count_bits(a), mp_count_bits(b));
res = mp_init_set_int(&_mx, 1uL);
if (res != MP_OKAY) {
@@ -33,7 +33,7 @@ int mp_tc_xor(const mp_int *a, const mp_int *b, mp_int *c)
goto end;
}
- if (as) {
+ if (as != MP_NO) {
res = mp_init(&acpy);
if (res != MP_OKAY) {
goto end;
@@ -46,7 +46,7 @@ int mp_tc_xor(const mp_int *a, const mp_int *b, mp_int *c)
}
a = &acpy;
}
- if (bs) {
+ if (bs != MP_NO) {
res = mp_init(&bcpy);
if (res != MP_OKAY) {
goto end;