Commit 712919f3378446296ebda65f42579da0248f24a0

Daniel Mendler 2019-05-24T12:17:13

[WIP] start to make dep.pl part of helper.pl

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
diff --git a/dep.pl b/dep.pl
deleted file mode 100755
index ceef32d..0000000
--- a/dep.pl
+++ /dev/null
@@ -1,169 +0,0 @@
-#!/usr/bin/perl
-#
-# Walk through source, add labels and make classes
-#
-use strict;
-use warnings;
-
-my %deplist;
-
-#open class file and write preamble
-open(my $class, '>', 'tommath_class.h') or die "Couldn't open tommath_class.h for writing\n";
-print {$class} << 'EOS';
-/* LibTomMath, multiple-precision integer library -- Tom St Denis */
-/* SPDX-License-Identifier: Unlicense */
-
-#if !(defined(LTM1) && defined(LTM2) && defined(LTM3))
-#if defined(LTM2)
-#   define LTM3
-#endif
-#if defined(LTM1)
-#   define LTM2
-#endif
-#define LTM1
-#if defined(LTM_ALL)
-EOS
-
-foreach my $filename (glob 'bn*.c') {
-   my $define = $filename;
-
-   print "Processing $filename\n";
-
-   # convert filename to upper case so we can use it as a define
-   $define =~ tr/[a-z]/[A-Z]/;
-   $define =~ tr/\./_/;
-   print {$class} << "EOS";
-#   define $define
-EOS
-
-   # now copy text and apply #ifdef as required
-   my $apply = 0;
-   open(my $src, '<', $filename);
-   open(my $out, '>', 'tmp');
-
-   # first line will be the #ifdef
-   my $line = <$src>;
-   if ($line =~ /include/) {
-      print {$out} $line;
-   } else {
-      print {$out} << "EOS";
-#include "tommath_private.h"
-#ifdef $define
-/* LibTomMath, multiple-precision integer library -- Tom St Denis */
-/* SPDX-License-Identifier: Unlicense */
-$line
-EOS
-      $apply = 1;
-   }
-   while (<$src>) {
-      if (!($_ =~ /tommath\.h/)) {
-         print {$out} $_;
-      }
-   }
-   if ($apply == 1) {
-      print {$out} << 'EOS';
-#endif
-EOS
-   }
-   close $src;
-   close $out;
-
-   unlink $filename;
-   rename 'tmp', $filename;
-}
-print {$class} << 'EOS';
-#endif
-EOS
-
-# now do classes
-
-foreach my $filename (glob 'bn*.c') {
-   open(my $src, '<', $filename) or die "Can't open source file!\n";
-   read $src, my $content, -s $src;
-   close $src;
-
-   # convert filename to upper case so we can use it as a define
-   $filename =~ tr/[a-z]/[A-Z]/;
-   $filename =~ tr/\./_/;
-
-   print {$class} << "EOS";
-#if defined($filename)
-EOS
-   my $list = $filename;
-
-   # strip comments
-   $content =~ s{/\*.*?\*/}{}gs;
-
-   # scan for mp_* and make classes
-   foreach my $line (split /\n/, $content) {
-      while ($line =~ /(fast_)?(s_)?mp\_[a-z_0-9]*(?=\()|(?<=\()mp\_[a-z_0-9]*(?=,)/g) {
-          my $a = $&;
-          next if $a eq "mp_err";
-          $a =~ tr/[a-z]/[A-Z]/;
-          $a = 'BN_' . $a . '_C';
-          if (!($list =~ /$a/)) {
-             print {$class} << "EOS";
-#   define $a
-EOS
-          }
-          $list = $list . ',' . $a;
-      }
-   }
-   $deplist{$filename} = $list;
-
-   print {$class} << 'EOS';
-#endif
-
-EOS
-}
-
-print {$class} << 'EOS';
-#ifdef LTM3
-#   define LTM_LAST
-#endif
-
-#include "tommath_superclass.h"
-#include "tommath_class.h"
-#else
-#   define LTM_LAST
-#endif
-EOS
-close $class;
-
-#now let's make a cool call graph...
-
-open(my $out, '>', 'callgraph.txt');
-my $indent = 0;
-my $list;
-foreach (sort keys %deplist) {
-   $list = '';
-   draw_func($deplist{$_});
-   print {$out} "\n\n";
-}
-close $out;
-
-sub draw_func
-{
-   my @funcs = split ',', $_[0];
-   # try this if you want to have a look at a minimized version of the callgraph without all the trivial functions
-   #if ($list =~ /$funcs[0]/ || $funcs[0] =~ /BN_MP_(ADD|SUB|CLEAR|CLEAR_\S+|DIV|MUL|COPY|ZERO|GROW|CLAMP|INIT|INIT_\S+|SET|ABS|CMP|CMP_D|EXCH)_C/) {
-   if ($list =~ /$funcs[0]/) {
-      return;
-   } else {
-      $list = $list . $funcs[0];
-   }
-   if ($indent == 0) {
-   } elsif ($indent >= 1) {
-      print {$out} '|   ' x ($indent - 1) . '+--->';
-   }
-   print {$out} $funcs[0] . "\n";
-   shift @funcs;
-   my $temp = $list;
-   foreach my $i (@funcs) {
-      ++$indent;
-      draw_func($deplist{$i}) if exists $deplist{$i};
-      --$indent;
-   }
-   $list = $temp;
-   return;
-}
diff --git a/helper-dep.pl b/helper-dep.pl
new file mode 100644
index 0000000..ceef32d
--- /dev/null
+++ b/helper-dep.pl
@@ -0,0 +1,169 @@
+#!/usr/bin/perl
+#
+# Walk through source, add labels and make classes
+#
+use strict;
+use warnings;
+
+my %deplist;
+
+#open class file and write preamble
+open(my $class, '>', 'tommath_class.h') or die "Couldn't open tommath_class.h for writing\n";
+print {$class} << 'EOS';
+/* LibTomMath, multiple-precision integer library -- Tom St Denis */
+/* SPDX-License-Identifier: Unlicense */
+
+#if !(defined(LTM1) && defined(LTM2) && defined(LTM3))
+#if defined(LTM2)
+#   define LTM3
+#endif
+#if defined(LTM1)
+#   define LTM2
+#endif
+#define LTM1
+#if defined(LTM_ALL)
+EOS
+
+foreach my $filename (glob 'bn*.c') {
+   my $define = $filename;
+
+   print "Processing $filename\n";
+
+   # convert filename to upper case so we can use it as a define
+   $define =~ tr/[a-z]/[A-Z]/;
+   $define =~ tr/\./_/;
+   print {$class} << "EOS";
+#   define $define
+EOS
+
+   # now copy text and apply #ifdef as required
+   my $apply = 0;
+   open(my $src, '<', $filename);
+   open(my $out, '>', 'tmp');
+
+   # first line will be the #ifdef
+   my $line = <$src>;
+   if ($line =~ /include/) {
+      print {$out} $line;
+   } else {
+      print {$out} << "EOS";
+#include "tommath_private.h"
+#ifdef $define
+/* LibTomMath, multiple-precision integer library -- Tom St Denis */
+/* SPDX-License-Identifier: Unlicense */
+$line
+EOS
+      $apply = 1;
+   }
+   while (<$src>) {
+      if (!($_ =~ /tommath\.h/)) {
+         print {$out} $_;
+      }
+   }
+   if ($apply == 1) {
+      print {$out} << 'EOS';
+#endif
+EOS
+   }
+   close $src;
+   close $out;
+
+   unlink $filename;
+   rename 'tmp', $filename;
+}
+print {$class} << 'EOS';
+#endif
+EOS
+
+# now do classes
+
+foreach my $filename (glob 'bn*.c') {
+   open(my $src, '<', $filename) or die "Can't open source file!\n";
+   read $src, my $content, -s $src;
+   close $src;
+
+   # convert filename to upper case so we can use it as a define
+   $filename =~ tr/[a-z]/[A-Z]/;
+   $filename =~ tr/\./_/;
+
+   print {$class} << "EOS";
+#if defined($filename)
+EOS
+   my $list = $filename;
+
+   # strip comments
+   $content =~ s{/\*.*?\*/}{}gs;
+
+   # scan for mp_* and make classes
+   foreach my $line (split /\n/, $content) {
+      while ($line =~ /(fast_)?(s_)?mp\_[a-z_0-9]*(?=\()|(?<=\()mp\_[a-z_0-9]*(?=,)/g) {
+          my $a = $&;
+          next if $a eq "mp_err";
+          $a =~ tr/[a-z]/[A-Z]/;
+          $a = 'BN_' . $a . '_C';
+          if (!($list =~ /$a/)) {
+             print {$class} << "EOS";
+#   define $a
+EOS
+          }
+          $list = $list . ',' . $a;
+      }
+   }
+   $deplist{$filename} = $list;
+
+   print {$class} << 'EOS';
+#endif
+
+EOS
+}
+
+print {$class} << 'EOS';
+#ifdef LTM3
+#   define LTM_LAST
+#endif
+
+#include "tommath_superclass.h"
+#include "tommath_class.h"
+#else
+#   define LTM_LAST
+#endif
+EOS
+close $class;
+
+#now let's make a cool call graph...
+
+open(my $out, '>', 'callgraph.txt');
+my $indent = 0;
+my $list;
+foreach (sort keys %deplist) {
+   $list = '';
+   draw_func($deplist{$_});
+   print {$out} "\n\n";
+}
+close $out;
+
+sub draw_func
+{
+   my @funcs = split ',', $_[0];
+   # try this if you want to have a look at a minimized version of the callgraph without all the trivial functions
+   #if ($list =~ /$funcs[0]/ || $funcs[0] =~ /BN_MP_(ADD|SUB|CLEAR|CLEAR_\S+|DIV|MUL|COPY|ZERO|GROW|CLAMP|INIT|INIT_\S+|SET|ABS|CMP|CMP_D|EXCH)_C/) {
+   if ($list =~ /$funcs[0]/) {
+      return;
+   } else {
+      $list = $list . $funcs[0];
+   }
+   if ($indent == 0) {
+   } elsif ($indent >= 1) {
+      print {$out} '|   ' x ($indent - 1) . '+--->';
+   }
+   print {$out} $funcs[0] . "\n";
+   shift @funcs;
+   my $temp = $list;
+   foreach my $i (@funcs) {
+      ++$indent;
+      draw_func($deplist{$i}) if exists $deplist{$i};
+      --$indent;
+   }
+   $list = $temp;
+   return;
+}
diff --git a/helper.pl b/helper.pl
index 4aac574..9543598 100755
--- a/helper.pl
+++ b/helper.pl
@@ -275,6 +275,11 @@ sub process_makefiles {
   }
 }
 
+sub update_dep {
+    system("perl helper-dep.pl");
+    return $? != 0;
+}
+
 sub die_usage {
   die <<"MARKER";
 usage: $0 -s   OR   $0 --check-source
@@ -300,6 +305,7 @@ $failure ||= check_comments()     if $check_all || $check_comments;
 $failure ||= check_doc()          if $check_doc; # temporarily excluded from --check-all
 $failure ||= process_makefiles(0) if $check_all || $check_makefiles;
 $failure ||= process_makefiles(1) if $update_makefiles;
+$failure ||= update_dep()         if $update_makefiles;
 
 die_usage unless defined $failure;
 exit $failure ? 1 : 0;
diff --git a/makefile b/makefile
index 4f40991..74c557c 100644
--- a/makefile
+++ b/makefile
@@ -149,8 +149,7 @@ zipup: clean astyle new_file manual poster docs
 	gpg -b -a ltm-$(VERSION).zip
 
 new_file:
-	perl helper.pl --update-makefiles || exit 1
-	perl dep.pl
+	perl helper.pl --update-makefiles
 
 perlcritic:
 	perlcritic *.pl doc/*.pl
diff --git a/testme.sh b/testme.sh
index f34d96f..0e035ce 100755
--- a/testme.sh
+++ b/testme.sh
@@ -295,9 +295,10 @@ if [[ "$CHECK_FORMAT" == "1" ]]
 then
   make astyle
   _check_git "make astyle"
-  make new_file
-  _check_git "make format"
-  perl helper.pl -a
+  perl helper.pl --update-makefiles
+  _check_git "helper.pl --update-makefiles"
+  perl helper.pl --check-all
+  _check_git "helper.pl --check-all"
   exit $?
 fi