Remove xkbcomp/misc.c The KeyName functions are more appropriate in keycodes.c. The ProcessIncludeFile can go to path.c along with the other functions dealing with includes. Signed-off-by: Ran Benita <ran234@gmail.com>
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333
diff --git a/Makefile.am b/Makefile.am
index 1235510..48bccca 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -46,7 +46,6 @@ libxkbcommon_la_SOURCES = \
src/xkbcomp/expr.h \
src/xkbcomp/keycodes.c \
src/xkbcomp/keytypes.c \
- src/xkbcomp/misc.c \
src/xkbcomp/parser.y \
src/xkbcomp/parseutils.c \
src/xkbcomp/parseutils.h \
diff --git a/src/xkbcomp/keycodes.c b/src/xkbcomp/keycodes.c
index 59cc444..208764a 100644
--- a/src/xkbcomp/keycodes.c
+++ b/src/xkbcomp/keycodes.c
@@ -1004,3 +1004,55 @@ err_info:
ClearKeyNamesInfo(&info);
return false;
}
+
+/**
+ * Find the key with the given name.
+ *
+ * @param keymap The keymap to search in.
+ * @param name The 4-letter name of the key as a long.
+ * @param use_aliases true if the key aliases should be searched too.
+ * @param start_from Keycode to start searching from.
+ *
+ * @return the key if it is found, NULL otherwise.
+ */
+struct xkb_key *
+FindNamedKey(struct xkb_keymap *keymap, unsigned long name,
+ bool use_aliases, xkb_keycode_t start_from)
+{
+ struct xkb_key *key;
+
+ if (start_from < keymap->min_key_code)
+ start_from = keymap->min_key_code;
+ else if (start_from > keymap->max_key_code)
+ return NULL;
+
+ xkb_foreach_key_from(key, keymap, start_from)
+ if (KeyNameToLong(key->name) == name)
+ return key;
+
+ if (use_aliases) {
+ unsigned long new_name;
+ if (FindKeyNameForAlias(keymap, name, &new_name))
+ return FindNamedKey(keymap, new_name, false, 0);
+ }
+
+ return NULL;
+}
+
+bool
+FindKeyNameForAlias(struct xkb_keymap *keymap, unsigned long lname,
+ unsigned long *real_name)
+{
+ char name[XkbKeyNameLength];
+ struct xkb_key_alias *a;
+
+ LongToKeyName(lname, name);
+ darray_foreach(a, keymap->key_aliases) {
+ if (strncmp(name, a->alias, XkbKeyNameLength) == 0) {
+ *real_name = KeyNameToLong(a->real);
+ return true;
+ }
+ }
+
+ return false;
+}
diff --git a/src/xkbcomp/misc.c b/src/xkbcomp/misc.c
deleted file mode 100644
index 011a2be..0000000
--- a/src/xkbcomp/misc.c
+++ /dev/null
@@ -1,160 +0,0 @@
-/************************************************************
- * Copyright (c) 1994 by Silicon Graphics Computer Systems, Inc.
- *
- * Permission to use, copy, modify, and distribute this
- * software and its documentation for any purpose and without
- * fee is hereby granted, provided that the above copyright
- * notice appear in all copies and that both that copyright
- * notice and this permission notice appear in supporting
- * documentation, and that the name of Silicon Graphics not be
- * used in advertising or publicity pertaining to distribution
- * of the software without specific prior written permission.
- * Silicon Graphics makes no representation about the suitability
- * of this software for any purpose. It is provided "as is"
- * without any express or implied warranty.
- *
- * SILICON GRAPHICS DISCLAIMS ALL WARRANTIES WITH REGARD TO THIS
- * SOFTWARE, INCLUDING ALL IMPLIED WARRANTIES OF MERCHANTABILITY
- * AND FITNESS FOR A PARTICULAR PURPOSE. IN NO EVENT SHALL SILICON
- * GRAPHICS BE LIABLE FOR ANY SPECIAL, INDIRECT OR CONSEQUENTIAL
- * DAMAGES OR ANY DAMAGES WHATSOEVER RESULTING FROM LOSS OF USE,
- * DATA OR PROFITS, WHETHER IN AN ACTION OF CONTRACT, NEGLIGENCE
- * OR OTHER TORTIOUS ACTION, ARISING OUT OF OR IN CONNECTION WITH
- * THE USE OR PERFORMANCE OF THIS SOFTWARE.
- *
- ********************************************************/
-
-#include "xkbcomp-priv.h"
-#include "path.h"
-#include "parseutils.h"
-
-/**
- * Open the file given in the include statement and parse it's content.
- * If the statement defines a specific map to use, this map is returned in
- * file_rtrn. Otherwise, the default map is returned.
- *
- * @param ctx The ctx containing include paths
- * @param stmt The include statement, specifying the file name to look for.
- * @param file_type Type of file (FILE_TYPE_KEYCODES, etc.)
- * @param file_rtrn Returns the key map to be used.
- * @param merge_rtrn Always returns stmt->merge.
- *
- * @return true on success or false otherwise.
- */
-bool
-ProcessIncludeFile(struct xkb_context *ctx,
- IncludeStmt * stmt,
- enum xkb_file_type file_type,
- XkbFile ** file_rtrn, enum merge_mode *merge_rtrn)
-{
- FILE *file;
- XkbFile *rtrn, *mapToUse, *next;
-
- file = XkbFindFileInPath(ctx, stmt->file, file_type, NULL);
- if (file == NULL) {
- log_err(ctx, "Can't find file \"%s\" for %s include\n", stmt->file,
- XkbDirectoryForInclude(file_type));
- return false;
- }
-
- if (!XKBParseFile(ctx, file, stmt->file, &rtrn)) {
- log_err(ctx, "Error interpreting include file \"%s\"\n", stmt->file);
- fclose(file);
- return false;
- }
- fclose(file);
-
- mapToUse = rtrn;
- if (stmt->map != NULL) {
- while (mapToUse)
- {
- next = (XkbFile *) mapToUse->common.next;
- mapToUse->common.next = NULL;
- if (streq(mapToUse->name, stmt->map) &&
- mapToUse->file_type == file_type) {
- FreeXKBFile(next);
- break;
- }
- else {
- FreeXKBFile(mapToUse);
- }
- mapToUse = next;
- }
- if (!mapToUse) {
- log_err(ctx, "No %s named \"%s\" in the include file \"%s\"\n",
- FileTypeText(file_type), stmt->map, stmt->file);
- return false;
- }
- }
- else if (rtrn->common.next) {
- log_lvl(ctx, 5,
- "No map in include statement, but \"%s\" contains several; "
- "Using first defined map, \"%s\"\n",
- stmt->file, rtrn->name);
- }
- if (mapToUse->file_type != file_type) {
- log_err(ctx,
- "Include file wrong type (expected %s, got %s); "
- "Include file \"%s\" ignored\n",
- FileTypeText(file_type), FileTypeText(mapToUse->file_type),
- stmt->file);
- return false;
- }
- /* FIXME: we have to check recursive includes here (or somewhere) */
-
- *file_rtrn = mapToUse;
- *merge_rtrn = stmt->merge;
- return true;
-}
-
-/**
- * Find the key with the given name.
- *
- * @param keymap The keymap to search in.
- * @param name The 4-letter name of the key as a long.
- * @param use_aliases true if the key aliases should be searched too.
- * @param start_from Keycode to start searching from.
- *
- * @return the key if it is found, NULL otherwise.
- */
-struct xkb_key *
-FindNamedKey(struct xkb_keymap *keymap, unsigned long name,
- bool use_aliases, xkb_keycode_t start_from)
-{
- struct xkb_key *key;
-
- if (start_from < keymap->min_key_code)
- start_from = keymap->min_key_code;
- else if (start_from > keymap->max_key_code)
- return NULL;
-
- xkb_foreach_key_from(key, keymap, start_from)
- if (KeyNameToLong(key->name) == name)
- return key;
-
- if (use_aliases) {
- unsigned long new_name;
- if (FindKeyNameForAlias(keymap, name, &new_name))
- return FindNamedKey(keymap, new_name, false, 0);
- }
-
- return NULL;
-}
-
-bool
-FindKeyNameForAlias(struct xkb_keymap *keymap, unsigned long lname,
- unsigned long *real_name)
-{
- char name[XkbKeyNameLength];
- struct xkb_key_alias *a;
-
- LongToKeyName(lname, name);
- darray_foreach(a, keymap->key_aliases) {
- if (strncmp(name, a->alias, XkbKeyNameLength) == 0) {
- *real_name = KeyNameToLong(a->real);
- return true;
- }
- }
-
- return false;
-}
diff --git a/src/xkbcomp/path.c b/src/xkbcomp/path.c
index 0ecdd7f..5089f2c 100644
--- a/src/xkbcomp/path.c
+++ b/src/xkbcomp/path.c
@@ -28,6 +28,7 @@
#include <limits.h>
#include "path.h"
+#include "parseutils.h"
/**
* Extract the first token from an include statement.
@@ -199,3 +200,82 @@ XkbFindFileInPath(struct xkb_context *ctx, const char *name,
*pathRtrn = strdup(buf);
return file;
}
+
+/**
+ * Open the file given in the include statement and parse it's content.
+ * If the statement defines a specific map to use, this map is returned in
+ * file_rtrn. Otherwise, the default map is returned.
+ *
+ * @param ctx The ctx containing include paths
+ * @param stmt The include statement, specifying the file name to look for.
+ * @param file_type Type of file (FILE_TYPE_KEYCODES, etc.)
+ * @param file_rtrn Returns the key map to be used.
+ * @param merge_rtrn Always returns stmt->merge.
+ *
+ * @return true on success or false otherwise.
+ */
+bool
+ProcessIncludeFile(struct xkb_context *ctx,
+ IncludeStmt * stmt,
+ enum xkb_file_type file_type,
+ XkbFile ** file_rtrn, enum merge_mode *merge_rtrn)
+{
+ FILE *file;
+ XkbFile *rtrn, *mapToUse, *next;
+
+ file = XkbFindFileInPath(ctx, stmt->file, file_type, NULL);
+ if (file == NULL) {
+ log_err(ctx, "Can't find file \"%s\" for %s include\n", stmt->file,
+ XkbDirectoryForInclude(file_type));
+ return false;
+ }
+
+ if (!XKBParseFile(ctx, file, stmt->file, &rtrn)) {
+ log_err(ctx, "Error interpreting include file \"%s\"\n", stmt->file);
+ fclose(file);
+ return false;
+ }
+ fclose(file);
+
+ mapToUse = rtrn;
+ if (stmt->map != NULL) {
+ while (mapToUse)
+ {
+ next = (XkbFile *) mapToUse->common.next;
+ mapToUse->common.next = NULL;
+ if (streq(mapToUse->name, stmt->map) &&
+ mapToUse->file_type == file_type) {
+ FreeXKBFile(next);
+ break;
+ }
+ else {
+ FreeXKBFile(mapToUse);
+ }
+ mapToUse = next;
+ }
+ if (!mapToUse) {
+ log_err(ctx, "No %s named \"%s\" in the include file \"%s\"\n",
+ FileTypeText(file_type), stmt->map, stmt->file);
+ return false;
+ }
+ }
+ else if (rtrn->common.next) {
+ log_lvl(ctx, 5,
+ "No map in include statement, but \"%s\" contains several; "
+ "Using first defined map, \"%s\"\n",
+ stmt->file, rtrn->name);
+ }
+ if (mapToUse->file_type != file_type) {
+ log_err(ctx,
+ "Include file wrong type (expected %s, got %s); "
+ "Include file \"%s\" ignored\n",
+ FileTypeText(file_type), FileTypeText(mapToUse->file_type),
+ stmt->file);
+ return false;
+ }
+ /* FIXME: we have to check recursive includes here (or somewhere) */
+
+ *file_rtrn = mapToUse;
+ *merge_rtrn = stmt->merge;
+ return true;
+}