Commit 5d821aed9bfda167761e5535006f380f5e60ba9d
2017-04-11T20:19:15
test/x11comp: be a bit more careful with kill() We did it correctly but better be safe and appease clang. Signed-off-by: Ran Benita <ran234@gmail.com>
diff --git a/test/x11comp.c b/test/x11comp.c
index 6df861a..3811e7a 100644
--- a/test/x11comp.c
+++ b/test/x11comp.c
@@ -45,7 +45,7 @@ main(void)
char *original, *dump;
char *envp[] = { NULL };
char *xvfb_argv[] = { "Xvfb", display, NULL };
- pid_t xvfb_pid;
+ pid_t xvfb_pid = 0;
char *xkbcomp_argv[] = { "xkbcomp", "-I", NULL /* xkb_path */, display,
NULL };
pid_t xkbcomp_pid;
@@ -159,7 +159,8 @@ err_dump:
err_xcb:
xcb_disconnect(conn);
err_xvfd:
- kill(xvfb_pid, SIGTERM);
+ if (xvfb_pid > 0)
+ kill(xvfb_pid, SIGTERM);
err_ctx:
xkb_context_unref(ctx);
return ret;