-
Show log
Commit
-
Hash : 5ef19bcf
Author :
Date : 2025-02-13T17:58:21
xkbcomp: Fix incorrect memory comparison Spotted by clang-tidy: ``` ../src/keymap-priv.c:146:16: warning: comparing object representation of type 'union xkb_action' which does not have a unique object representation; consider comparing the members of the object manually [bugprone-suspicious-memory-comparison] ```` Indeed, from “EXP42-C. Do not compare padding data”[^1]: > unnamed members of objects of structure and union type do not participate > in initialization. Unnamed members of structure objects have indeterminate > representation even after initialization. Fixed by using a dedicated comparison function for `union xkb_action`. [^1]: https://wiki.sei.cmu.edu/confluence/display/c/EXP42-C.+Do+not+compare+padding+data
-
Files
- atom.c
- atom.h
- compose/
- context-priv.c
- context.c
- context.h
- darray.h
- keymap-priv.c
- keymap.c
- keymap.h
- keysym-case-mappings.c
- keysym-utf.c
- keysym.c
- keysym.h
- keysym.h.jinja
- ks_tables.h
- messages-codes.h
- messages-codes.h.jinja
- registry.c
- scanner-utils.c
- scanner-utils.h
- state.c
- text.c
- text.h
- utf8-decoding.c
- utf8-decoding.h
- utf8.c
- utf8.h
- util-list.c
- util-list.h
- util-mem.h
- utils-paths.c
- utils-paths.h
- utils.c
- utils.h
- x11/
- xkbcomp/
