• Show log

    Commit

  • Hash : 99e29de2
    Author : Rob Bradford
    Date : 2011-10-27T14:30:21

    xkbcomp: Copy the string into the buffer rather than updating pointer
    
    Avoids assigning the global pointer to a value that may only have a stack
    lifetime:
    
    Fixes valgrind warnings such as:
    
    ==24795== Invalid read of size 1
    ==24795==    at 0x4A06E9A: strcpy (mc_replace_strmem.c:311)
    ==24795==    by 0x4E54D68: ProcessIncludeFile (misc.c:73)
    ==24795==    by 0x4E59726: HandleIncludeSymbols.constprop.3 (symbols.c:829)
    ==24795==    by 0x4E59D8E: HandleSymbolsFile (symbols.c:1673)
    ==24795==    by 0x4E5A068: CompileSymbols (symbols.c:2211)
    ==24795==    by 0x4E51A61: CompileKeymap (keymap.c:155)
    ==24795==    by 0x4E5B410: xkb_compile_keymap_from_components (xkbcomp.c:236)
    ==24795==    by 0x4E5B587: xkb_compile_keymap_from_rules (xkbcomp.c:161)
    ==24795==    by 0x405ED2: display_create (window.c:2007)
    ==24795==    by 0x403732: main (desktop-shell.c:320)
    ==24795==  Address 0x7fefff0a0 is just below the stack ptr.  To suppress, use:
    --workaround-gcc296-bugs=yes
    ==24795==
    ==24795== Source and destination overlap in strcpy(0x7fefff430, 0x7fefff430)
    ==24795==    at 0x4A06F3D: strcpy (mc_replace_strmem.c:311)
    ==24795==    by 0x4E54D68: ProcessIncludeFile (misc.c:73)
    ==24795==    by 0x4E59726: HandleIncludeSymbols.constprop.3 (symbols.c:829)
    ==24795==    by 0x4E59D8E: HandleSymbolsFile (symbols.c:1673)
    ==24795==    by 0x4E5A068: CompileSymbols (symbols.c:2211)
    ==24795==    by 0x4E51A61: CompileKeymap (keymap.c:155)
    ==24795==    by 0x4E5B410: xkb_compile_keymap_from_components (xkbcomp.c:236)
    ==24795==    by 0x4E5B587: xkb_compile_keymap_from_rules (xkbcomp.c:161)
    ==24795==    by 0x405ED2: display_create (window.c:2007)
    ==24795==    by 0x403732: main (desktop-shell.c:320)
    

  • Properties

  • Git HTTP https://git.kmx.io/kc3-lang/libxkbcommon.git
    Git SSH git@git.kmx.io:kc3-lang/libxkbcommon.git
    Public access ? public
    Description

    keymap handling library for toolkits and window systems

    Users
    kc3_lang_org thodg_w www_kmx_io thodg_l thodg thodg_m
    Tags

  • README

  • All questions regarding this software should be directed at the
    Xorg mailing list:
    
            http://lists.freedesktop.org/mailman/listinfo/xorg
    
    Please submit bug reports to the Xorg bugzilla:
    
            https://bugs.freedesktop.org/enter_bug.cgi?product=xorg
    
    The master development code repository can be found at:
    
            git://anongit.freedesktop.org/git/xorg/lib/libxkbcommon
    
            http://cgit.freedesktop.org/xorg/lib/libxkbcommon
    
    For patch submission instructions, see:
    
    	http://www.x.org/wiki/Development/Documentation/SubmittingPatches
    
    For more information on the git code manager, see:
    
            http://wiki.x.org/wiki/GitPage