xinclude.c


Log

Author Commit Date CI Message
William M. Brack 4d59e22a 2004-03-08T14:42:31 enhanced to assure that if xpointer is called for a document, the * xinclude.c: enhanced to assure that if xpointer is called for a document, the XML_PARSE_NOENT flag is set before parsing the included document so that entities will automatically get taken care of. * xpointer.c: corrected code so that, if an XML_ENTITY_REF node is encountered, it will log it and not crash (bug 135713)
William M. Brack a11e483e 2004-03-07T11:03:43 modified to make sub-includes inherit the parse flags from the parent * xinclude.c: modified to make sub-includes inherit the parse flags from the parent document (bug 132597)
Daniel Veillard f54cd533 2004-02-25T11:52:31 fixing compilation and link option when configuring with --without-valid * debugXML.c relaxng.c valid.c xinclude.c xmllint.c xmlreader.c: fixing compilation and link option when configuring with --without-valid should fix #135309 Daniel
Daniel Veillard 5bb9ccd5 2004-02-09T12:39:02 remove the warning on the 2001 namespace remove some warnings when * xinclude.c: remove the warning on the 2001 namespace * parser.c parserInternals.c xpath.c: remove some warnings when compiling with MSVC6 * nanohttp.c: applied a patch when using _WINSOCKAPI_ Daniel
William M. Brack 95af594b 2004-02-08T04:12:49 added a small hack to fix interference between my fixes for bugs 132585 * xinclude.c: added a small hack to fix interference between my fixes for bugs 132585 and 132588. * python/libxml.c: fixed problem with serialization of namespace reported on the mailing list by Anthony Carrico
William M. Brack 6bdacd7a 2004-02-07T08:53:23 fixed problem with function xmlXIncludeCopyRange (bug 133686). * xinclude.c: fixed problem with function xmlXIncludeCopyRange (bug 133686).
William M. Brack 6b1a28d3 2004-02-06T11:24:44 changed coding to output good XIncludes when one or more bad ones are * xinclude.c: changed coding to output good XIncludes when one or more bad ones are present (bug 132588)
William M. Brack ef245fda 2004-02-06T09:33:59 corrected handling of empty fallback condition (bug 132585) * xinclude.c: corrected handling of empty fallback condition (bug 132585)
William M. Brack b2d25dd7 2004-02-04T00:51:21 fixed problem regarding freeing of dictionary when there are errors within * xinclude.c: fixed problem regarding freeing of dictionary when there are errors within an XInclude file (bug 133106). Thanks to Oleg Paraschenko for the assistance.
Daniel Veillard 03c2f0a4 2004-01-25T19:54:59 fixing #130453 XInclude element with no href attribute fully integrating * xinclude.c: fixing #130453 XInclude element with no href attribute * relaxng.c rngparser.c include/libxml2/relaxng.h: fully integrating the compact syntax will require more work, postponed for the 2.6.5 release. Daniel
Daniel Veillard 4773df2a 2004-01-23T13:15:13 added io1.c an example ox xmlIO usage and io1.res test result, fixed a * doc/examples/*: added io1.c an example ox xmlIO usage and io1.res test result, fixed a awful lot of memory leaks showing up in testWriter.c, changed the examples and the Makefiles to test memory leaks. * xmlwriter.c: fixed a memory leak * Makefile.am: run the doc/examples regression tests as part of make tests * xpath.c include/libxml/xpath.h: added xmlXPathCtxtCompile() to compile an XPath expression within a context, currently the goal is to be able to reuse the XSLT stylesheet dictionnary, but this opens the door to others possible optimizations. * dict.c include/libxml/dict.h: added xmlDictCreateSub() which allows to build a new dictionnary based on another read-only dictionnary. This is needed for XSLT to keep the stylesheet dictionnary read-only while being able to reuse the strings for the transformation dictionnary. * xinclude.c: fixed a dictionnar reference counting problem occuring when document parsing failed. * testSAX.c: adding option --repeat for timing 100times the parsing * doc/* : rebuilt all the docs Daniel
William M. Brack aae10527 2004-01-02T14:59:41 fixed problem with "recursive" include (fallback contains another include * xinclude.c: fixed problem with "recursive" include (fallback contains another include - Bug 129969)
William M. Brack 1ff4213e 2003-12-31T14:05:15 fixed problem caused by wrong dictionary reference count, reported on the * xinclude.c: fixed problem caused by wrong dictionary reference count, reported on the list by Christopher Grayce.
William M. Brack f7eb794c 2003-12-31T07:59:17 fixed problem pointed out by Stéphane Bidoul on the list. completed * python/generator.py, python/libxml2class.txt: fixed problem pointed out by Stéphane Bidoul on the list. * xinclude.c, xpointer.c, xpath.c, include/libxml/xpointer.h: completed modifications required to fix Bug 129967 (at last!). Now wait to see how long before further trouble...
William M. Brack 72ee48d5 2003-12-30T08:30:19 Fixed memory leak reported by Dave Beckett Removed spurious comment * parser.c, xmlmemory.c, include/libxml/xmlmemory.h: Fixed memory leak reported by Dave Beckett * xmlschemas.c: Removed spurious comment reported on the mailing list * xinclude.c, xpath.c, xpointer.c, libxml/include/xpointer.h: Further work on Bug 129967 concerning xpointer range handling and range-to function; much better, but still not complete
Daniel Veillard b98d082e 2003-12-24T11:06:25 XInclude xpointer support was broken with the new namespace. Fixes #129932 * xinclude.c result/XInclude/nodes2.*: XInclude xpointer support was broken with the new namespace. Fixes #129932 Daniel
Daniel Veillard 2d2f1552 2003-12-21T23:36:39 fixed a serious problem in XInclude #129021 Daniel * xinclude.c: fixed a serious problem in XInclude #129021 Daniel
Daniel Veillard e74d2e1c 2003-12-09T11:35:37 augmented the XInclude API to be able to pass XML parser flags down to the * xinclude.c xmllint.c xmlreader.c include/libxml/xinclude.h include/libxml/xmlerror.h: augmented the XInclude API to be able to pass XML parser flags down to the Inclusion process. Also resynchronized with the Last Call W3C Working Draft 10 November 2003 for the xpointer attribute. * Makefile.am test/XInclude/docs/nodes[23].xml result/XInclude/*: augmented the tests for the new namespace and testing the xpointer attribute, changed the way error messages are tested * doc/*: regenerated the documentation Daniel
Daniel Veillard b5fa0208 2003-12-08T17:41:29 filter warning messages if the global setting blocks them updated the * error.c: filter warning messages if the global setting blocks them * xinclude.c xmlreader.c include/libxml/xinclude.h include/libxml/xmlerror.h: updated the change of namespace at the XInclude level, raise a warning if the old one is found, and some cleanup Daniel
Daniel Veillard a152c4d6 2003-11-19T16:24:26 fix an error message added tree2 example from Lucas Brasilino Daniel * xinclude.c: fix an error message * doc/examples/*: added tree2 example from Lucas Brasilino Daniel
Daniel Veillard 798ae543 2003-11-03T17:13:52 fixed bug #125812, about XPointer in XInclude failing but not returning an * xinclude.c: fixed bug #125812, about XPointer in XInclude failing but not returning an error. Daniel
Daniel Veillard 7899c5c5 2003-11-03T12:31:38 adding XInclude support to the reader interface. Lot of testing of the * xinclude.c xmlreader.c include/libxml/xinclude.h: adding XInclude support to the reader interface. Lot of testing of the walker, various bug fixes. * xmllint.c: added --walker and made sure --xinclude --stream --debug works as expected * Makefile.am result/dtd11.rdr result/ent6.rdr test/dtd11 test/ent6 result/XInclude/*.rdr: added regression tests for the walker and XInclude xmlReader support, had to slightly change a couple of tests because the walker can't distinguish <foo/> from <foo></foo> Daniel
Daniel Veillard 659e71ec 2003-10-10T14:10:40 Setting up the framework for structured error reporting, touches a lot of * HTMLparser.c c14n.c catalog.c error.c globals.c parser.c parserInternals.c relaxng.c valid.c xinclude.c xmlIO.c xmlregexp.c xmlschemas.c xpath.c xpointer.c include/libxml/globals.h include/libxml/parser.h include/libxml/valid.h include/libxml/xmlerror.h: Setting up the framework for structured error reporting, touches a lot of modules, but little code now the error handling trail has been cleaned up. Daniel
Daniel Veillard 69d2c171 2003-10-09T11:46:07 comment fix migrating the catalog code to the new infrastructure Daniel * xinclude.c: comment fix * catalog.c include/libxml/xmlerror.h: migrating the catalog code to the new infrastructure Daniel
Daniel Veillard cd6ff282 2003-10-08T22:38:13 final error handling cleanup converted XInclude to the new error handling * xmlIO.c: final error handling cleanup * xinclude.c error.c: converted XInclude to the new error handling * include/libxml/xmlerror.h: added XInclude errors Daniel
Daniel Veillard 10acc2f3 2003-09-01T20:59:40 patch from Mark Vakoc that allows compiling with XInclude but without * xinclude.c: patch from Mark Vakoc that allows compiling with XInclude but without XPointer support. Daniel
Daniel Veillard 9848532c 2003-08-14T15:44:40 get rid of some compilation warnings. fix the performance problem reported * DOCBparser.c globals.c include/libxml/xmlmemory.h: get rid of some compilation warnings. * xinclude.c: fix the performance problem reported by Kevin Ruscoe plus some cleanup and better error reporting. Daniel
William M. Brack 78637da0 2003-07-31T14:47:38 fixing bug 118559
Daniel Veillard 8edf1c5c 2003-07-22T20:52:14 added a new API xmlXIncludeProcessTree() to process XInclude only on a * xinclude.c include/libxml/xinclude.h: added a new API xmlXIncludeProcessTree() to process XInclude only on a subtree this should fix bug #115385 Daniel
Daniel Veillard ffe4f5ec 2003-07-06T17:35:43 fixed bug #116095 removing the error message when reapplying XInclude to a * xinclude.c: fixed bug #116095 removing the error message when reapplying XInclude to a document. Daniel
Daniel Veillard a507fbf3 2003-03-31T16:09:37 try to work on bug #109225 and provide better error reports. this change * relaxng.c: try to work on bug #109225 and provide better error reports. * result/relaxng/* : this change the output of a number of tests * xinclude.c: fixing the parsed entity redefinition problem raised on the list. * test/schemas/date_0.xsd: updated the date test c.f. E2-12 Daniel
Daniel Veillard b6c7f415 2003-03-29T16:41:55 forgot to apply one check from #106931 patch more work on XML Schemas * xinclude.c: forgot to apply one check from #106931 patch * xmlschemastypes.c: more work on XML Schemas datatypes Daniel
Daniel Veillard d9b72839 2003-03-27T14:24:00 should fix #109327 errors on memory accesses Daniel * xinclude.c: should fix #109327 errors on memory accesses Daniel
Daniel Veillard 2406abda 2003-02-24T18:16:47 Fixes bug #106931 in XInclude entities merging. Daniel * xinclude.c: Fixes bug #106931 in XInclude entities merging. Daniel
Daniel Veillard f4b4f988 2003-02-13T11:02:08 added TODO for the DTD compatibility spec more bug fixes driven by the * relaxng.c: added TODO for the DTD compatibility spec * xinclude.c: more bug fixes driven by the testsuite Daniel
Daniel Veillard d581b7ed 2003-02-11T18:03:05 Work on the W3C/NIST regression tests for XInclude, improved the script, * check-xinclude-test-suite.py xinclude.c: Work on the W3C/NIST regression tests for XInclude, improved the script, improving XInclude error reporting mechanism Daniel
Daniel Veillard 97fd5670 2003-02-07T13:01:54 applied another bug fix from Sean Chittenden Daniel * xinclude.c: applied another bug fix from Sean Chittenden Daniel
Daniel Veillard 4287c57a 2003-02-04T22:48:53 fixing bug #105137 about entities declaration needing to be copied to the * xinclude.c: fixing bug #105137 about entities declaration needing to be copied to the including document. Daniel
Daniel Veillard 0650345d 2002-12-13T10:42:08 fallback was only copying the first child not the full child list of the * xinclude.c: fallback was only copying the first child not the full child list of the fallback element, closes #89684 as reopened by Bernd Kuemmerlen Daniel
Daniel Veillard d076a20e 2002-11-20T13:28:31 fixed #99082 for xi:include encoding="..." support on text includes. added * xinclude.c parserInternals.c encoding.c: fixed #99082 for xi:include encoding="..." support on text includes. * result/XInclude/tstencoding.xml test/XInclude/docs/tstencoding.xml test/XInclude/ents/isolatin.txt : added a specific regression test * python/generator.py python/libxml2class.txt: fixed the generator the new set of comments generated for doc/libxml2-api.xml were breaking the python generation. Daniel
Daniel Veillard dda8f1ba 2002-09-26T09:47:36 make sure ATTRIBUTE_UNUSED is always put after the attribute declaration, * xinclude.c xmlschemas.c xmlschemastypes.c xpath.c: make sure ATTRIBUTE_UNUSED is always put after the attribute declaration, not before Daniel
Daniel Veillard 118aed78 2002-09-24T14:13:13 fixed the data callback on transition functionality which was broken when * xmlregexp.c: fixed the data callback on transition functionality which was broken when using the compact form * result/schemas/*: updated the results, less verbose, all tests pass like before * DOCBparser.c testAutomata.c testC14N.c testSchemas.c testThreads.c testXPath.c valid.c xinclude.c xmllint.c xmlregexp.c xmlschemas.c xmlschemastypes.c xpath.c python/libxml.c: removed a bunch of annoying warnings * xpath.c: try to provide better error report when possible Daniel
Daniel Veillard bbc72c3a 2002-09-05T10:52:10 reimplemented a large part of the XInclude processor, trying to minimize * xinclude.c: reimplemented a large part of the XInclude processor, trying to minimize resources used, James Henstridge provided a huge test case which was exhibiting severe memory consumption problems. Daniel
Daniel Veillard c4bad4a7 2002-08-14T14:45:25 oops I was missing the xml:base fixup too this adds xml:base attributes to * xinclude.c: oops I was missing the xml:base fixup too * result/XInclude/*.xml: this adds xml:base attributes to most results of the tests Daniel
Daniel Veillard e3b7d9a1 2002-08-14T14:11:30 quick but apparently working implementation of xi:fallback, should close * xinclude.c: quick but apparently working implementation of xi:fallback, should close bug #89684 * Makefile.am test/XInclude/docs/fallback.xml result/XInclude/fallback.xml: added a basic test for fallback, and run with --nowarning to avoid a spurious warning * configure.in: applied patch from Frederic Crozat for python bindings on AMD 64bits machines. Daniel
Daniel Veillard 58e44c9d 2002-08-02T22:19:49 adding a new API for Christian Glahn: xmlParseBalancedChunkMemoryRecover * parser.c include/libxml/parser.h: adding a new API for Christian Glahn: xmlParseBalancedChunkMemoryRecover * valid.c: patch from Rick Jones for some grammar cleanup in validation messages * result/VC/* result/valid/*: this slightly change some of the regression tests outputs Daniel
Daniel Veillard 34ce8bec 2002-03-18T19:37:11 preparing 2.4.18 updated and rebuilt the web site implement the new * configure.in: preparing 2.4.18 * doc/*: updated and rebuilt the web site * *.c libxml.h: implement the new IN_LIBXML scheme discussed with the Windows and Cygwin maintainers. * parser.c: humm, changed the way the SAX parser work when xmlSubstituteEntitiesDefault(1) is set, it will then do the entity registration and loading by itself in case the user provided SAX getEntity() returns NULL. * testSAX.c: added --noent to test the behaviour. Daniel
Daniel Veillard c5f05ada 2002-02-10T11:57:22 fix #68882, cleanup the XInclude copying of node, merge back IDs in the * tree.c valid.c xinclude.c: fix #68882, cleanup the XInclude copying of node, merge back IDs in the target document. * result/XInclude/docids.xml test/XInclude/docs/docids.xml test/XInclude/ents/ids.xml: test case * result/VC/ElementValid4: output changed due to a typo fix Daniel
Daniel Veillard cbaf3995 2001-12-31T16:16:02 applied 42 documentation patches from Charlie Bozeman. Regenerated the * *.c include/libxml/*.h doc/html/*: applied 42 documentation patches from Charlie Bozeman. Regenerated the HTML docs. Daniel
Daniel Veillard 3c01b1d8 2001-10-17T15:58:35 - include/libxml/globals.h include/libxml/threads.h threads.c testThreads.c: far more testing, cleaning up bugs - *.c : make sure globals.h is always included. Daniel
Daniel Veillard c5d64345 2001-06-24T12:13:24 Summer's cleanup, a really big one: * AUTHORS: added William and Bjorn * include/libxml/*.h *.c README doc/*.html etc.: changed old email to daniel@veillard.com hopefully I won't have to do this again * doc/Makefile.am doc/html/*.html: cleanup makefile, checked that docs can be rebuilt cleanly now * include/libxml/xml*version.h*: removed include/libxml/xmlversion.h from CVs it's generated, added include/libxml/xmlwin32version.h also generated but which should change far less frequently. * catalog.c nanoftp.c: made sure to include libxml.h not libxml/xmlversion.h directly * include/libxml/*.h: include xmlwin32version.h instead of xmlversion.h when compiling on WIN32 and MSC Daniel
Daniel Veillard 017b108f 2001-06-21T11:20:21 - Makefile.am: cleanup when --without-debug is specified - xinclude.c xpath.c xpathInternals.h xpointer.c: cleanup w.r.t. --without-debug and other include points - catalog.h testCatalog.c: a bit of cleanup and prepare for XML Catalogs - configure.in entities.h tree.h HTMLparser.c: removed --without-corba, made the _private field mandatory Daniel
Daniel Veillard 39196eba 2001-06-19T18:09:42 - tree.c xinclude.c xpointer.c: bug #56402 exposed a number of weakness in the node copy the XPointer and the XInclude implementations. Serious cleanup. Daniel
Daniel Veillard 4497e698 2001-06-09T14:19:02 - xinclude.c: Raphael Hertzog had a trouble with DTD nodes being processed, applied his patch - tree.c: fixed a bug raised in xmlStaticCopyNodeList() Daniel
Daniel Veillard d16df9f6 2001-05-23T13:44:21 - xinclude.c: fixed XInclude recursive behaviour bug #54678 - result/XInclude/recursive.xml test/XInclude/docs/recursive.xml test/XInclude/ents/inc.txt test/XInclude/ents/sub-inc.ent: added specific regression test - parser.h: preparing for the XSLT mode where DTD inherited attributes are added to the tree. Daniel
Daniel Veillard bbd22458 2001-05-23T12:02:27 - xinclude.[ch]: Updated the namespace for the Last Call version - result/XInclude/include test/XInclude/include: updated the testsuite accordingly Daniel
Bjorn Reese 70a9da54 2001-04-21T16:57:29 trio upgrade and integration
Daniel Veillard 92ad2104 2001-03-27T12:47:33 Spring cleanup ...: - configure.in Makefile.am config.h.in Spring cleanup ...: - configure.in Makefile.am config.h.in xmlversion.h.in: detect if we need string functions - trio.[ch] strio.[ch]: embedded the Trio-0.23 string functions to be able to use them where needed. Applied some changes to reduce name linking pollution and compile in only what's needed. - HTMLtree.c debugXML.c entities.c error.c nanoftp.c valid.c xlink.c xmlversion.h.in xpath.c: got rid of the #ifdef for the string manipulation functions - xmlmemory.[ch]: removed DEBUG_MEMORY_FREED and added it automatically to the free() function of xmlmemory.c - entities.c HTMLtree.c parserInternals.c tree.c uri.c valid.c xinclude.c xmlIO.c xpath.c xpointer.c: removed the MEM_CLEANUP usage. Daniel
Daniel Veillard 56a4cb8c 2001-03-24T17:00:36 Huge cleanup, I switched to compile with -Wall -g -O -ansi -pedantic -W -Wunused -Wimplicit -Wreturn-type -Wswitch -Wcomment -Wtrigraphs -Wformat -Wchar-subscripts -Wuninitialized -Wparentheses -Wshadow -Wpointer-arith -Wcast-align -Wwrite-strings -Waggregate-return -Wstrict-prototypes -Wmissing-prototypes -Wnested-externs -Winline - HTMLparser.[ch] HTMLtree.c SAX.c debugXML.c encoding.[ch] encoding.h entities.c error.c list.[ch] nanoftp.c nanohttp.c parser.[ch] parserInternals.[ch] testHTML.c testSAX.c testURI.c testXPath.c tree.[ch] uri.c valid.[ch] xinclude.c xmlIO.[ch] xmllint.c xmlmemory.c xpath.c xpathInternals.h xpointer.[ch] example/gjobread.c: Cleanup, staticfied a number of non-exported functions, detected and cleaned up a dozen of problem found this way, avoided a lot of public function name/typedef/system names clashes - doc/xml.html: updated - configure.in: switched private flags to the really pedantic ones. Daniel
Daniel Veillard edac3c90 2001-02-26T01:36:19 - xinclude.c: fixed a problem building on Mac Daniel
Daniel Veillard 48b2f896 2001-02-25T16:11:03 Okay time to improve performances, gprof session: before real 0m2.483s (2.3.2 release yesterday) current real 0m1.763s when parsing (with tree build/freeing) db10000.xml from XSLTMark: - xmlmemory.h HTMLparser.c HTMLtree.c entities.c parser.c xpath.c xpointer.c tree.c uri.c valid.c xinclude.c xmlIO.c: avoiding memcpy in production builds MEM_CLEANUP macro use - parser.[ch] parserInternals.c: optimizations of the tightest internal loops inside the parser. Better checking of I/O flushing/loading conditions - xmllint.c : added --timing Daniel
Owen Taylor 3473f88a 2001-02-23T17:55:21 Revert directory structure changes
CET 2001 Tomasz Kłoczko 64636e7f 2001-02-23T01:37:32 moved to libxml directory - this allow simplify automake/autoconf. Now Thu Feb 23 02:03:56 CET 2001 Tomasz Kłoczko <kloczek@pld.org.pl> * *.c *.h libxml files: moved to libxml directory - this allow simplify automake/autoconf. Now isn't neccessary hack on am/ac level for make and remove libxml symlink (modified for this also configure.in and main Makefile.am). Now automake abilities are used in best way (like in many other projects with libraries). * include/win32config.h: moved to libxml directory (now include directory isn't neccessary). * Makefile.am, examples/Makefile.am, libxml/Makefile.am: added empty DEFS and in INCLUDES rest only -I$(top_builddir) - this allow minimize parameters count passed to libtool script (now compilation is also slyghtly more quiet). * configure.in: simplifies libzdetestion - prepare separated variables for keep libz name and path to libz header files isn't realy neccessary (if someone have libz installed in non standard prefix path to header files ald library can be passed as: $ CFALGS="-I</libz.h/path>" LDFLAGS="-L</libz/path>" ./configure * autogen.sh: check now for libxml/entities.h. After above building libxml pass correctly and also pass "make install DESTDIR=</install/prefix>" from tar ball generated by "make dist". Seems ac/am reorganization is finished. This changes not touches any other things on *.{c,h} files level.
Daniel Veillard bf43275d 2000-11-12T15:56:56 Bug fixes new Xinclude tests: - nanoftp.c: fixed gcc 2.95 new warnings - SAX.c: fixed a stupid bug - tree.c: fixed a formatting problem when round-tripping from/to memory - xinclude.c: chased memleak, fixed a base problem - xpointer.c: added xmlXPtrBuildRangeNodeList(), finished ? xmlXPtrBuildNodeList() - TODO: updated - Makefile.am test/XInclude/docs test/XInclude/ents result/XInclude: adding a first small set of regression tests for XInclude Daniel
Daniel Veillard c2def84b 2000-11-07T14:21:01 Various patches and bug fixes, and XInclude progresses: - nanohttp.[ch]: applied Wayne Davison patches to access the WWW-Authorization header. - parser.c: Closed Bug#30847: Problems when switching encoding in short files by applying Simon Berg's patch. - valid.c: fixed a validation problem - hash.c parser.h parserInternals.h testHTML.c testSAX.c tree.h xmlerror.h xmlmemory.h xmlversion.h.in: applied a DLL patch from Wayne Davison - xpointer.[ch]: added first version of xmlXPtrBuildNodeList() need to be extended to non full nodes selections. - xinclude.c: starts to work decently Daniel
Daniel Veillard 9e8bfae5 2000-11-06T16:43:11 XInclude and other stuff while travelling. Contributed patches: - tree.[ch] xinclude.[ch] xmllint.c configure.in valid.c debugXML.c xmlversion.h.in: Started adding XInclude support, this is a new xmllint option - tree.c xpath.c: applied TOM patches for XPath - xpointer.c: fixed a couple of errors. - uri.c: added an escaping function needed for xinclude - testXPath.c hash.c HTMLtree.c: minor cleanups raised by new warning from RH70 gcc's version Daniel