Commit 62c3c66f1734effca70487d2e312da0f4c13cadc

Paul Sheppard 2012-06-27T08:18:12

Merge branch 'master' of git://github.com/ckolivas/cgminer.git

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
diff --git a/api.c b/api.c
index ff26e54..ac5b9a6 100644
--- a/api.c
+++ b/api.c
@@ -1174,10 +1174,12 @@ static void pgaenable(__maybe_unused SOCKETTYPE c, char *param, bool isjson)
 		return;
 	}
 
+#if 0 /* A DISABLED device wont change status FIXME: should disabling make it WELL? */
 	if (cgpu->status != LIFE_WELL) {
 		strcpy(io_buffer, message(MSG_PGAUNW, id, NULL, isjson));
 		return;
 	}
+#endif
 
 	for (i = 0; i < mining_threads; i++) {
 		pga = thr_info[i].cgpu->device_id;
diff --git a/cgminer.c b/cgminer.c
index 9b77d69..8b7de73 100644
--- a/cgminer.c
+++ b/cgminer.c
@@ -2165,7 +2165,10 @@ static bool stale_work(struct work *work, bool share)
 		return false;
 
 	if (share) {
-		if (work->rolltime)
+		/* Technically the rolltime should be correct but some pools
+		 * advertise a broken expire= that is lower than a meaningful
+		 * scantime */
+		if (work->rolltime > opt_scantime)
 			work_expiry = work->rolltime;
 		else
 			work_expiry = opt_expiry;
@@ -3641,9 +3644,11 @@ static inline bool should_roll(struct work *work)
 	return false;
 }
 
+/* Limit rolls to 7000 to not beyond 2 hours in the future where bitcoind will
+ * reject blocks as invalid. */
 static inline bool can_roll(struct work *work)
 {
-	return (work->pool && !stale_work(work, false) && work->rolltime && !work->clone);
+	return (work->pool && work->rolltime && !work->clone && work->rolls < 7000);
 }
 
 static void roll_work(struct work *work)
diff --git a/miner.php b/miner.php
index 7c4d889..1c64e5a 100644
--- a/miner.php
+++ b/miner.php
@@ -4,6 +4,7 @@ session_start();
 global $miner, $port, $readonly, $notify, $rigs, $socktimeoutsec;
 global $checklastshare, $hidefields;
 global $ignorerefresh, $changerefresh, $autorefresh;
+global $allowcustompages, $customsummarypages;
 #
 # Don't touch these 2 - see $rigs below
 $miner = null;
@@ -59,6 +60,32 @@ $ignorerefresh = false;
 $changerefresh = true;
 $autorefresh = 0;
 #
+# Should we allow custom pages?
+# (or just completely ignore then and don't display the buttons)
+$allowcustompages = true;
+#
+# OK this is a bit more complex item: Custom Summary Pages
+# A custom summary page in an array of 'section' => array('FieldA','FieldB'...)
+# This makes up what is displayed with each 'section' separately as a table
+# - empty tables are not shown
+# - empty columns (an unknown field) are not shown
+# - and missing field data shows as blank
+# There is a second array, listing fields to be totaled for each section
+# see the example below (if there is no matching data, no total will show)
+$mobilepage = array(
+ 'SUMMARY' => array('Elapsed', 'MHS av', 'Found Blocks', 'Accepted', 'Rejected', 'Utility'),
+ 'GPU' => array('GPU', 'Status', 'MHS av', 'Accepted', 'Rejected', 'Utility'),
+ 'PGA' => array('ID', 'Name', 'Status', 'MHS av', 'Accepted', 'Rejected', 'Utility'),
+ 'POOL' => array('POOL', 'Status', 'Accepted', 'Rejected', 'Last Share Time'));
+$mobilesum = array(
+ 'SUMMARY' => array('MHS av' => 1, 'Found Blocks' => 1, 'Accepted' => 1, 'Rejected' => 1, 'Utility' => 1),
+ 'GPU' => array('MHS av' => 1, 'Accepted' => 1, 'Rejected' => 1, 'Utility' => 1),
+ 'PGA' => array('MHS av' => 1, 'Accepted' => 1, 'Rejected' => 1, 'Utility' => 1),
+ 'POOL' => array('Accepted' => 1, 'Rejected' => 1));
+#
+# customsummarypages is an array of these Custom Summary Pages
+$customsummarypages = array('Mobile' => array($mobilepage, $mobilesum));
+#
 $here = $_SERVER['PHP_SELF'];
 #
 global $tablebegin, $tableend, $warnfont, $warnoff, $dfmt;
@@ -90,26 +117,30 @@ $showndate = false;
 global $rigerror;
 $rigerror = array();
 #
-function htmlhead($checkapi, $rig)
+function htmlhead($checkapi, $rig, $pg = null)
 {
  global $miner_font_family, $miner_font_size;
  global $error, $readonly, $here;
  global $ignorerefresh, $autorefresh;
 
- $paramrig = '';
+ $extraparams = '';
  if ($rig != null && $rig != '')
-	$paramrig = "&rig=$rig";
+	$extraparams = "&rig=$rig";
+ else
+	if ($pg != null && $pg != '')
+		$extraparams = "&pg=$pg";
 
  if ($ignorerefresh == true || $autorefresh == 0)
 	$refreshmeta = '';
  else
  {
-	$url = "$here?ref=$autorefresh$paramrig";
+	$url = "$here?ref=$autorefresh$extraparams";
 	$refreshmeta = "\n<meta http-equiv='refresh' content='$autorefresh;url=$url'>";
  }
 
  if ($readonly === false && $checkapi === true)
  {
+	$error = null;
 	$access = api('privileged');
 	if ($error != null
 	||  !isset($access['STATUS']['STATUS'])
@@ -134,7 +165,7 @@ td.lst { color:blue; $miner_font background:#ffffdd }
 function pr(a,m){if(m!=null){if(!confirm(m+'?'))return}window.location='$here?ref=$autorefresh'+a}\n";
 
 if ($ignorerefresh == false)
- echo "function prr(a){if(a){v=document.getElementById('refval').value}else{v=0}window.location='$here?ref='+v+'$paramrig'}\n";
+ echo "function prr(a){if(a){v=document.getElementById('refval').value}else{v=0}window.location='$here?ref='+v+'$extraparams'}\n";
 
  if ($readonly === false && $checkapi === true)
  {
@@ -150,17 +181,20 @@ function prs2(a,n,r){var v=document.getElementById('gi'+n).value;var c=a.substr(
 <?php
 }
 #
-global $error;
+global $haderror, $error;
+$haderror = false;
 $error = null;
 #
 function getsock($addr, $port)
 {
- global $error, $socktimeoutsec;
+ global $haderror, $error, $socktimeoutsec;
 
+ $error = null;
  $socket = null;
  $socket = socket_create(AF_INET, SOCK_STREAM, SOL_TCP);
  if ($socket === false || $socket === null)
  {
+	$haderror = true;
 	$error = socket_strerror(socket_last_error());
 	$msg = "socket create(TCP) failed";
 	$error = "ERR: $msg '$error'\n";
@@ -175,6 +209,7 @@ function getsock($addr, $port)
  $res = socket_connect($socket, $addr, $port);
  if ($res === false)
  {
+	$haderror = true;
 	$error = socket_strerror(socket_last_error());
 	$msg = "socket connect($addr,$port) failed";
 	$error = "ERR: $msg '$error'\n";
@@ -201,6 +236,7 @@ function readsockline($socket)
 #
 function api($cmd)
 {
+ global $haderror, $error;
  global $miner, $port, $hidefields;
 
  $socket = getsock($miner, $port);
@@ -212,6 +248,7 @@ function api($cmd)
 
 	if (strlen($line) == 0)
 	{
+		$haderror = true;
 		$error = "WARN: '$cmd' returned nothing\n";
 		return $line;
 	}
@@ -519,7 +556,7 @@ $poolcmd = array(	'Switch to'	=> 'switchpool',
 			'Enable'	=> 'enablepool',
 			'Disable'	=> 'disablepool' );
 #
-function showhead($cmd, $item, $values)
+function showhead($cmd, $values, $justnames = false)
 {
  global $poolcmd, $readonly;
 
@@ -532,7 +569,7 @@ function showhead($cmd, $item, $values)
 	echo "<td valign=bottom class=h>$name</td>";
  }
 
- if ($cmd == 'pools' && $readonly === false)
+ if ($justnames === false && $cmd == 'pools' && $readonly === false)
 	foreach ($poolcmd as $name => $pcmd)
 		echo "<td valign=bottom class=h>$name</td>";
 
@@ -588,7 +625,7 @@ function details($cmd, $list, $rig)
 	if ($sectionname != $section)
 	{
 		echo $tableend.$tablebegin;
-		showhead($cmd, $item, $values);
+		showhead($cmd, $values);
 		$section = $sectionname;
 	}
 
@@ -796,7 +833,7 @@ function doforeach($cmd, $des, $sum, $head, $datetime)
 	echo $tableend.$tablebegin;
 
 	$dthead = array('' => 1, 'STATUS' => 1, 'Description' => 1, 'When' => 1, 'API' => 1, 'CGMiner' => 1);
-	showhead('', null, $dthead);
+	showhead('', $dthead);
 
 	foreach ($anss as $rig => $ans)
 	{
@@ -865,7 +902,7 @@ function doforeach($cmd, $des, $sum, $head, $datetime)
  if ($sum != null)
 	$anss['total']['total'] = $total;
 
- showhead('', null, $header);
+ showhead('', $header);
 
  $section = '';
 
@@ -924,26 +961,38 @@ function refreshbuttons()
  if ($ignorerefresh == false && $changerefresh == true)
  {
 	echo '&nbsp;&nbsp;&nbsp;&nbsp;';
-	echo "<input type=button value='Refresh:' onclick='prr(true)'>";
+	echo "<input type=button value='Auto Refresh:' onclick='prr(true)'>";
 	echo "<input type=text name='refval' id='refval' size=2 value='$autorefresh'>";
 	echo "<input type=button value='Off' onclick='prr(false)'>";
  }
 }
 #
-function doOne($rig, $preprocess)
+function pagetop($rig, $pg)
 {
- global $error, $readonly, $notify, $rigs;
-
- htmlhead(true, $rig);
+ global $readonly, $rigs;
+ global $allowcustompages, $customsummarypages;
 
- $error = null;
+ if ($rig === null)
+ {
+	if ($pg === null)
+		$refresh = '';
+	else
+		$refresh = "&pg=$pg";
+ }
+ else
+	$refresh = "&rig=$rig";
 
- echo "<tr><td><table cellpadding=0 cellspacing=0 border=0><tr><td>";
- echo "<input type=button value='Refresh' onclick='pr(\"&rig=$rig\",null)'></td>";
+ echo '<tr><td><table cellpadding=0 cellspacing=0 border=0><tr><td nowrap>';
+ echo "<input type=button value='Refresh' onclick='pr(\"$refresh\",null)'>&nbsp;";
  if (count($rigs) > 1)
-	echo "<td><input type=button value='Summary' onclick='pr(\"\",null)'></td>";
- echo "<td width=100%>&nbsp;</td><td nowrap>";
- if ($readonly === false)
+	echo "<input type=button value='Summary' onclick='pr(\"\",null)'>&nbsp;";
+
+ if ($allowcustompages === true)
+	foreach ($customsummarypages as $pagename => $data)
+		echo "<input type=button value='$pagename' onclick='pr(\"&pg=$pagename\",null)'>&nbsp;";
+
+ echo '</td><td width=100%>&nbsp;</td><td nowrap>';
+ if ($rig !== null && $readonly === false)
  {
 	$rg = '';
 	if (count($rigs) > 1)
@@ -953,6 +1002,15 @@ function doOne($rig, $preprocess)
  }
  refreshbuttons();
  echo "</td></tr></table></td></tr>";
+}
+#
+function doOne($rig, $preprocess)
+{
+ global $haderror, $readonly, $notify, $rigs;
+
+ htmlhead(true, $rig);
+
+ pagetop($rig, null);
 
  if ($preprocess != null)
 	process(array($preprocess => $preprocess), $rig);
@@ -968,16 +1026,226 @@ function doOne($rig, $preprocess)
 
  process($cmds, $rig);
 
- if ($error == null && $readonly === false)
+ if ($haderror == false && $readonly === false)
 	processgpus($rig);
 }
 #
+global $sectionmap;
+# map sections to their api command
+$sectionmap = array(
+	'SUMMARY' => 'summary',
+	'POOL' => 'pools',
+	'GPU' => 'devs',
+	'PGA' => 'devs',
+	'NOTIFY' => 'notify',
+	'CONFIG' => 'config');
+#
+function customset($showfields, $sum, $section, $num, $result, $total)
+{
+ foreach ($result as $sec => $row)
+ {
+	$secname = preg_replace('/\d/', '', $sec);
+
+	if ($sec != 'total')
+	{
+		if ($secname != $section)
+			continue;
+	}
+
+	echo '<tr>';
+
+	$when = 0;
+	if (isset($result['STATUS']['When']))
+		$when = $result['STATUS']['When'];
+
+	if ($sec === 'total')
+		$class = ' class=tot';
+	else
+		$class = '';
+
+	echo "<td align=middle$class>$num</td>";
+
+	foreach ($showfields as $name => $one)
+	{
+		if (isset($row[$name]))
+		{
+			$value = $row[$name];
+
+			if (isset($sum[$secname][$name]))
+			{
+				if (isset($total[$name]))
+					$total[$name] += $value;
+				else
+					$total[$name] = $value;
+			}
+		}
+		else
+		{
+			if ($sec == 'total' && isset($total[$name]))
+				$value = $total[$name];
+			else
+				$value = null;
+		}
+
+		list($showvalue, $class) = fmt($section, $name, $value, $when, $row);
+
+		if ($sec === 'total' and $class == '')
+			$class = ' class=tot';
+
+
+		echo "<td$class align=right>$showvalue</td>";
+	}
+
+	echo '</tr>';
+ }
+ return $total;
+}
+#
+function processcustompage($pagename, $sections, $sum)
+{
+ global $sectionmap;
+ global $miner, $port;
+ global $rigs, $error;
+ global $warnfont, $warnoff;
+ global $tablebegin, $tableend, $dfmt;
+ global $readonly, $showndate;
+
+ $cmds = array();
+ $errors = array();
+ foreach ($sections as $section => $fields)
+ {
+	if (isset($sectionmap[$section]))
+	{
+		$cmd = $sectionmap[$section];
+		if (!isset($cmds[$cmd]))
+			$cmds[$cmd] = 1;
+	}
+	else
+		$errors[] = "Error: unknown section '$section' in custom summary page '$pagename'";
+ }
+
+ $results = array();
+ foreach ($rigs as $num => $rig)
+ {
+	$parts = explode(':', $rig, 2);
+	if (count($parts) == 2)
+	{
+		$miner = $parts[0];
+		$port = $parts[1];
+
+		foreach ($cmds as $cmd => $one)
+		{
+			$process = api($cmd);
+
+			if ($error != null)
+			{
+				$errors[] = "Error getting $cmd for $rig $warnfont$error$warnoff";
+				break;
+			}
+			else
+				$results[$cmd][$num] = $process;
+		}
+	}
+ }
+
+ if (count($results) > 0)
+ {
+	$first = true;
+	foreach ($sections as $section => $fields)
+	{
+		if (isset($results[$sectionmap[$section]]))
+		{
+			$rigresults = $results[$sectionmap[$section]];
+			$showfields = array();
+			foreach ($fields as $field)
+				foreach ($rigresults as $result)
+					foreach ($result as $sec => $row)
+					{
+						$secname = preg_replace('/\d/', '', $sec);
+						if ($secname == $section && isset($row[$field]))
+							$showfields[$field] = 1;
+					}
+
+			if (count($showfields) > 0)
+			{
+				if ($first === false)
+					echo '<tr><td>&nbsp;</td></tr>';
+
+				echo $tablebegin;
+
+				showhead('', array('Rig'=>1)+$showfields, true);
+
+				$total = array();
+				$add = array('total' => array());
+
+				foreach ($rigresults as $num => $result)
+				{
+					$rg = "<input type=button value='$num' onclick='pr(\"&rig=$num\",null)'>";
+					$total = customset($showfields, $sum, $section, $rg, $result, $total);
+				}
+
+				if (count($total) > 0)
+					customset($showfields, $sum, $section, '&Sigma;', $add, $total);
+
+				$first = false;
+
+				echo $tableend;
+			}
+		}
+	}
+ }
+
+ if (count($errors) > 0)
+ {
+	if (count($results) > 0)
+		echo '<tr><td>&nbsp;</td></tr>';
+
+	foreach ($errors as $err)
+		echo "<tr><td colspan=100>$err</td></tr>";
+ }
+}
+#
+function showcustompage($pagename)
+{
+ global $customsummarypages;
+
+ htmlhead(false, null, $pagename);
+
+ pagetop(null, $pagename);
+
+ if (!isset($customsummarypages[$pagename]))
+ {
+	echo "<tr><td colspan=100>Unknown custom summary page '$pagename'</td></tr>";
+	return;
+ }
+
+ if (count($customsummarypages[$pagename]) != 2)
+ {
+	echo "<tr><td colspan=100>Invalid custom summary page '$pagename' (".count($customsummarypages[$pagename]).")</td></tr>";
+	return;
+ }
+
+ $page = $customsummarypages[$pagename][0];
+ $sum = $customsummarypages[$pagename][1];
+ if ($sum === null)
+	$sum = array();
+
+ if (count($page) <= 1)
+ {
+	echo "<tr><td colspan=100>Invalid custom summary page '$pagename' no content </td></tr>";
+	return;
+ }
+
+ processcustompage($pagename, $page, $sum);
+}
+#
 function display()
 {
  global $tablebegin, $tableend;
  global $miner, $port;
- global $error, $readonly, $notify, $rigs;
+ global $readonly, $notify, $rigs;
  global $ignorerefresh, $autorefresh;
+ global $allowcustompages;
 
  if ($ignorerefresh == false)
  {
@@ -1021,6 +1289,16 @@ function display()
 	return;
  }
 
+ if ($allowcustompages === true)
+ {
+	$pg = trim(getparam('pg', true));
+	if ($pg != null && $pg != '')
+	{
+		showcustompage($pg);
+		return;
+	}
+ }
+
  if (count($rigs) == 1)
  {
 	$parts = explode(':', $rigs[0], 2);
@@ -1055,11 +1333,7 @@ function display()
 
  htmlhead(false, null);
 
- echo "<tr><td><table cellpadding=0 cellspacing=0 border=0><tr><td>";
- echo "<input type=button value='Refresh' onclick='pr(\"\",null)'>";
- echo "<td width=100%>&nbsp;</td><td nowrap>";
- refreshbuttons();
- echo "</td></tr></table></td></tr>";
+ pagetop(null, null);
 
  if ($preprocess != null)
 	process(array($preprocess => $preprocess), $rig);