Merge remote-tracking branch 'upstream/master' into merge_385
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730
diff --git a/Makefile.am b/Makefile.am
index b2d72f9..2311ead 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -1,12 +1,12 @@
ACLOCAL_AMFLAGS = -I m4
-JANSSON_INCLUDES= -I$(top_builddir)/compat/jansson-2.5/src -I$(top_srcdir)/compat/jansson-2.5/src
+JANSSON_CPPFLAGS= -I$(top_builddir)/compat/jansson-2.5/src -I$(top_srcdir)/compat/jansson-2.5/src
if WANT_USBUTILS
-USBUTILS_INCLUDES = -I$(top_builddir)/compat/libusb-1.0/libusb -I$(top_srcdir)/compat/libusb-1.0/libusb
+USBUTILS_CPPFLAGS = -I$(top_builddir)/compat/libusb-1.0/libusb -I$(top_srcdir)/compat/libusb-1.0/libusb
else
-USBUTILS_INCLUDES =
+USBUTILS_CPPFLAGS =
endif
EXTRA_DIST = example.conf linux-usb-cgminer \
@@ -18,7 +18,7 @@ EXTRA_DIST = example.conf linux-usb-cgminer \
SUBDIRS = lib compat ccan
-INCLUDES = $(PTHREAD_FLAGS) -fno-strict-aliasing $(JANSSON_INCLUDES) $(USBUTILS_INCLUDES)
+cgminer_CPPFLAGS = $(PTHREAD_FLAGS) -fno-strict-aliasing $(JANSSON_CPPFLAGS) $(USBUTILS_CPPFLAGS)
bin_PROGRAMS = cgminer
@@ -28,10 +28,10 @@ cgminer_LDADD = $(DLOPEN_FLAGS) @LIBCURL_LIBS@ @JANSSON_LIBS@ @PTHREAD_LIBS@ \
@LIBUSB_LIBS@ @MM_LIBS@ @RT_LIBS@ \
@MATH_LIBS@ lib/libgnu.a ccan/libccan.a
-if HAVE_WINDOWS
-cgminer_CPPFLAGS = -I$(top_builddir)/lib -I$(top_srcdir)/lib
-else
-cgminer_CPPFLAGS = -I$(top_builddir)/lib -I$(top_srcdir)/lib @LIBCURL_CFLAGS@
+cgminer_CPPFLAGS += -I$(top_builddir)/lib -I$(top_srcdir)/lib
+
+if !HAVE_WINDOWS
+cgminer_CPPFLAGS += @LIBCURL_CFLAGS@
endif
# common sources
diff --git a/NEWS b/NEWS
index 353bd63..10f2b23 100644
--- a/NEWS
+++ b/NEWS
@@ -1,3 +1,33 @@
+Version 3.8.5 - 10th December 2013
+
+- Increase the BFLSC overtemp to 75 for fanspeed to maximum.
+- Set bflsc cutoff temperature to 85 degrees and throttle 3 degrees below the
+cutoff temperature.
+- Only set LIBUSB_TRANSFER_ADD_ZERO_PACKET for libusb versions we know include
+support for.
+- Provide a helper function that can reset cgsems to zero.
+- Add to cgminer_CPPFLAGS instead of redefining them.
+- Attempt a libusb reset device on usb devices that have stopped responding.
+- Replace deprecated use of INCLUDES with _CPPFLAGS.
+- Remove more unused GPU code.
+- Attempt USB device resets on usb read/write errors that will normally cause
+the device to drop out.
+- Quieten down jansson component of build.
+- Cache the bool value for usb1.1 in _usb_write
+- Initialise usb locks within usbutils.c instead of exporting them.
+- Imitate a transaction translator for all usb1.1 device writes to compensate
+for variable quality hubs and operating system support.
+- Rationalise variables passed to usb_bulk_transfer.
+- Unlink files opened as semaphores on releasing them.
+- Remove user configuration flag from pll bypass enabling in hashfast driver.
+- Provide an hfa-dfu-boot option for resetting hashfast devices for
+reprogramming.
+- Fixed one byte stack overflow in mcast recvfrom.
+- Having changed C_MAX means we don't calloc enough for usb stats, off by one.
+- Don't free the info struct on hashfast shutdown since it's still accessed
+after a device is removed.
+
+
Version 3.8.4 - 1st December 2013
- Deprecate the usb usecps function and just split up transfers equal to the
diff --git a/cgminer.c b/cgminer.c
index 10c6aa1..de5ae82 100644
--- a/cgminer.c
+++ b/cgminer.c
@@ -1108,14 +1108,6 @@ static struct opt_table opt_config_table[] = {
OPT_WITH_ARG("--api-port",
set_int_1_to_65535, opt_show_intval, &opt_api_port,
"Port number of miner API"),
-#ifdef HAVE_ADL
- OPT_WITHOUT_ARG("--auto-fan",
- opt_set_bool, &opt_autofan,
- "Automatically adjust all GPU fan speeds to maintain a target temperature"),
- OPT_WITHOUT_ARG("--auto-gpu",
- opt_set_bool, &opt_autoengine,
- "Automatically adjust all GPU engine clock speeds to maintain a target temperature"),
-#endif
OPT_WITHOUT_ARG("--balance",
set_balance, &pool_strategy,
"Change multipool strategy from failover to even share balance"),
@@ -1246,14 +1238,6 @@ static struct opt_table opt_config_table[] = {
OPT_WITHOUT_ARG("--net-delay",
opt_set_bool, &opt_delaynet,
"Impose small delays in networking to not overload slow routers"),
- OPT_WITHOUT_ARG("--no-adl",
- opt_set_bool, &opt_noadl,
-#ifdef HAVE_ADL
- "Disable the ATI display library used for monitoring and setting GPU parameters"
-#else
- opt_hidden
-#endif
- ),
OPT_WITHOUT_ARG("--no-pool-disable",
opt_set_invbool, &opt_disable_pool,
opt_hidden),
@@ -1324,22 +1308,11 @@ static struct opt_table opt_config_table[] = {
opt_set_bool, &use_syslog,
"Use system log for output messages (default: standard error)"),
#endif
-#if defined(HAVE_ADL) || defined(USE_BITFORCE) || defined(USE_MODMINER) || defined(USE_BFLSC)
+#if defined(USE_BITFORCE) || defined(USE_MODMINER) || defined(USE_BFLSC)
OPT_WITH_ARG("--temp-cutoff",
set_temp_cutoff, opt_show_intval, &opt_cutofftemp,
"Temperature where a device will be automatically disabled, one value or comma separated list"),
#endif
-#ifdef HAVE_ADL
- OPT_WITH_ARG("--temp-hysteresis",
- set_int_1_to_10, opt_show_intval, &opt_hysteresis,
- "Set how much the temperature can fluctuate outside limits when automanaging speeds"),
- OPT_WITH_ARG("--temp-overheat",
- set_temp_overheat, opt_show_intval, &opt_overheattemp,
- "Overheat temperature when automatically managing fan and GPU speeds, one value or comma separated list"),
- OPT_WITH_ARG("--temp-target",
- set_temp_target, opt_show_intval, &opt_targettemp,
- "Target temperature when automatically managing fan and GPU speeds, one value or comma separated list"),
-#endif
OPT_WITHOUT_ARG("--text-only|-T",
opt_set_invbool, &use_curses,
#ifdef HAVE_CURSES
@@ -1348,11 +1321,6 @@ static struct opt_table opt_config_table[] = {
opt_hidden
#endif
),
-#ifdef USE_SCRYPT
- OPT_WITH_ARG("--thread-concurrency",
- set_thread_concurrency, NULL, NULL,
- "Set GPU thread concurrency for scrypt mining, comma separated"),
-#endif
OPT_WITH_ARG("--url|-o",
set_url, NULL, NULL,
"URL for bitcoin JSON-RPC server"),
@@ -6853,6 +6821,11 @@ static void *longpoll_thread(void __maybe_unused *userdata)
void reinit_device(struct cgpu_info *cgpu)
{
+#ifdef USE_USBUTILS
+ /* Attempt a usb device reset if the device has gone sick */
+ if (cgpu->usbdev && cgpu->usbdev->handle)
+ libusb_reset_device(cgpu->usbdev->handle);
+#endif
cgpu->drv->reinit_device(cgpu);
}
@@ -7077,19 +7050,6 @@ static void *watchdog_thread(void __maybe_unused *userdata)
denable = &cgpu->deven;
snprintf(dev_str, sizeof(dev_str), "%s%d", cgpu->drv->name, gpu);
-#ifdef HAVE_ADL
- if (adl_active && cgpu->has_adl)
- gpu_autotune(gpu, denable);
- if (opt_debug && cgpu->has_adl) {
- int engineclock = 0, memclock = 0, activity = 0, fanspeed = 0, fanpercent = 0, powertune = 0;
- float temp = 0, vddc = 0;
-
- if (gpu_stats(gpu, &temp, &engineclock, &memclock, &vddc, &activity, &fanspeed, &fanpercent, &powertune))
- applog(LOG_DEBUG, "%.1f C F: %d%%(%dRPM) E: %dMHz M: %dMhz V: %.3fV A: %d%% P: %d%%",
- temp, fanpercent, fanspeed, engineclock, memclock, vddc, activity, powertune);
- }
-#endif
-
/* Thread is waiting on getwork or disabled */
if (thr->getwork || *denable == DEV_DISABLED)
continue;
@@ -7106,12 +7066,6 @@ static void *watchdog_thread(void __maybe_unused *userdata)
cgtime(&thr->sick);
dev_error(cgpu, REASON_DEV_SICK_IDLE_60);
-#ifdef HAVE_ADL
- if (adl_active && cgpu->has_adl && gpu_activity(gpu) > 50) {
- applog(LOG_ERR, "GPU still showing activity suggesting a hard hang.");
- applog(LOG_ERR, "Will not attempt to auto-restart it.");
- } else
-#endif
if (opt_restart) {
applog(LOG_ERR, "%s: Attempting to restart", dev_str);
reinit_device(cgpu);
@@ -7126,11 +7080,6 @@ static void *watchdog_thread(void __maybe_unused *userdata)
(cgpu->status == LIFE_SICK || cgpu->status == LIFE_DEAD)) {
/* Attempt to restart a GPU that's sick or dead once every minute */
cgtime(&thr->sick);
-#ifdef HAVE_ADL
- if (adl_active && cgpu->has_adl && gpu_activity(gpu) > 50) {
- /* Again do not attempt to restart a device that may have hard hung */
- } else
-#endif
if (opt_restart)
reinit_device(cgpu);
}
diff --git a/compat/jansson-2.5/configure.ac b/compat/jansson-2.5/configure.ac
index d089fdb..a16327e 100644
--- a/compat/jansson-2.5/configure.ac
+++ b/compat/jansson-2.5/configure.ac
@@ -4,6 +4,7 @@ AC_INIT([jansson], [2.5], [petri@digip.org])
AC_CONFIG_MACRO_DIR([m4])
AM_INIT_AUTOMAKE([1.10 foreign])
+m4_ifdef([AM_SILENT_RULES], [AM_SILENT_RULES([yes])])
AC_CONFIG_SRCDIR([src/value.c])
AC_CONFIG_HEADERS([config.h])
diff --git a/configure.ac b/configure.ac
index 4056f0f..644f946 100644
--- a/configure.ac
+++ b/configure.ac
@@ -2,7 +2,7 @@
##--##--##--##--##--##--##--##--##--##--##--##--##--##--##--##--##
m4_define([v_maj], [3])
m4_define([v_min], [8])
-m4_define([v_mic], [4])
+m4_define([v_mic], [5])
##--##--##--##--##--##--##--##--##--##--##--##--##--##--##--##--##
m4_define([v_ver], [v_maj.v_min.v_mic])
m4_define([lt_rev], m4_eval(v_maj + v_min))
@@ -403,13 +403,6 @@ fi
AC_DEFINE_UNQUOTED([CGMINER_PREFIX], ["$prefix/bin"], [Path to cgminer install])
-AC_DEFINE_UNQUOTED([PHATK_KERNNAME], ["phatk121016"], [Filename for phatk kernel])
-AC_DEFINE_UNQUOTED([POCLBM_KERNNAME], ["poclbm130302"], [Filename for poclbm kernel])
-AC_DEFINE_UNQUOTED([DIAKGCN_KERNNAME], ["diakgcn121016"], [Filename for diakgcn kernel])
-AC_DEFINE_UNQUOTED([DIABLO_KERNNAME], ["diablo130302"], [Filename for diablo kernel])
-AC_DEFINE_UNQUOTED([SCRYPT_KERNNAME], ["scrypt130511"], [Filename for scrypt kernel])
-
-
AC_SUBST(JANSSON_LIBS)
AC_SUBST(PTHREAD_FLAGS)
AC_SUBST(DLOPEN_FLAGS)
@@ -420,7 +413,6 @@ AC_SUBST(WS2_LIBS)
AC_SUBST(MM_LIBS)
AC_SUBST(MATH_LIBS)
AC_SUBST(RT_LIBS)
-AC_SUBST(ADL_CPPFLAGS)
AC_CONFIG_FILES([
Makefile
diff --git a/driver-bflsc.c b/driver-bflsc.c
index ea82951..c47afc3 100644
--- a/driver-bflsc.c
+++ b/driver-bflsc.c
@@ -1007,6 +1007,36 @@ static void bflsc_flash_led(struct cgpu_info *bflsc, int dev)
return;
}
+/* Flush and stop all work if the device reaches the thermal cutoff temp, or
+ * temporarily stop queueing work if it's in the throttling range. */
+static void bflsc_manage_temp(struct cgpu_info *bflsc, struct bflsc_dev *sc_dev,
+ int dev, float temp)
+{
+ bflsc->temp = temp;
+ if (bflsc->cutofftemp > 0) {
+ int cutoff = bflsc->cutofftemp;
+ int throttle = cutoff - BFLSC_TEMP_THROTTLE;
+ int recover = cutoff - BFLSC_TEMP_RECOVER;
+
+ if (sc_dev->overheat) {
+ if (temp < recover)
+ sc_dev->overheat = false;
+ } else if (temp > throttle) {
+ sc_dev->overheat = true;
+ if (temp > cutoff) {
+ applog(LOG_WARNING, "%s%i: temp (%.1f) hit thermal cutoff limit %d, stopping work!",
+ bflsc->drv->name, bflsc->device_id, temp, cutoff);
+ dev_error(bflsc, REASON_DEV_THERMAL_CUTOFF);
+ flush_one_dev(bflsc, dev);
+
+ } else {
+ applog(LOG_NOTICE, "%s%i: temp (%.1f) hit thermal throttle limit %d, throttling",
+ bflsc->drv->name, bflsc->device_id, temp, throttle);
+ }
+ }
+ }
+}
+
static bool bflsc_get_temp(struct cgpu_info *bflsc, int dev)
{
struct bflsc_info *sc_info = (struct bflsc_info *)(bflsc->device_data);
@@ -1200,20 +1230,7 @@ static bool bflsc_get_temp(struct cgpu_info *bflsc, int dev)
if (temp < temp2)
temp = temp2;
- bflsc->temp = temp;
-
- if (bflsc->cutofftemp > 0 && temp >= bflsc->cutofftemp) {
- applog(LOG_WARNING, "%s%i:%s temp (%.1f) hit thermal cutoff limit %d, stopping work!",
- bflsc->drv->name, bflsc->device_id, xlink,
- temp, bflsc->cutofftemp);
- dev_error(bflsc, REASON_DEV_THERMAL_CUTOFF);
- sc_dev->overheat = true;
- flush_one_dev(bflsc, dev);
- return false;
- }
-
- if (bflsc->cutofftemp > 0 && temp < (bflsc->cutofftemp - BFLSC_TEMP_RECOVER))
- sc_dev->overheat = false;
+ bflsc_manage_temp(bflsc, sc_dev, dev, temp);
}
return true;
@@ -1814,7 +1831,7 @@ static int64_t bflsc_scanwork(struct thr_info *thr)
return ret;
}
-#define BFLSC_OVER_TEMP 60
+#define BFLSC_OVER_TEMP 75
/* Set the fanspeed to auto for any valid value <= BFLSC_OVER_TEMP,
* or max for any value > BFLSC_OVER_TEMP or if we don't know the temperature. */
diff --git a/driver-bflsc.h b/driver-bflsc.h
index b1d65fa..f3b5ea1 100644
--- a/driver-bflsc.h
+++ b/driver-bflsc.h
@@ -348,8 +348,10 @@ struct SaveString {
#define BFLSC_QUE_WATERMARK_V2 32
#define BFLSC_QUE_LOW_V2 16
-#define BFLSC_TEMP_OVERHEAT 90
-// Must drop this far below cutoff before resuming work
+#define BFLSC_TEMP_OVERHEAT 85
+// Will start throttling this much below overheat
+#define BFLSC_TEMP_THROTTLE 3
+// Must drop this far below overheat before resuming work
#define BFLSC_TEMP_RECOVER 5
// If initialisation fails the first time,
diff --git a/miner.h b/miner.h
index d67a955..a5f0ddd 100644
--- a/miner.h
+++ b/miner.h
@@ -115,10 +115,6 @@ static inline int fsync (int fd)
#endif
-#ifdef HAVE_ADL
- #include "ADL_SDK/adl_sdk.h"
-#endif
-
#ifdef USE_USBUTILS
#include <libusb.h>
#endif
@@ -286,44 +282,6 @@ struct strategies {
struct cgpu_info;
-#ifdef HAVE_ADL
-struct gpu_adl {
- ADLTemperature lpTemperature;
- int iAdapterIndex;
- int lpAdapterID;
- int iBusNumber;
- char strAdapterName[256];
-
- ADLPMActivity lpActivity;
- ADLODParameters lpOdParameters;
- ADLODPerformanceLevels *DefPerfLev;
- ADLFanSpeedInfo lpFanSpeedInfo;
- ADLFanSpeedValue lpFanSpeedValue;
- ADLFanSpeedValue DefFanSpeedValue;
-
- int iEngineClock;
- int iMemoryClock;
- int iVddc;
- int iPercentage;
-
- bool autofan;
- bool autoengine;
- bool managed; /* Were the values ever changed on this card */
-
- int lastengine;
- int lasttemp;
- int targetfan;
- int targettemp;
- int overtemp;
- int minspeed;
- int maxspeed;
-
- int gpu;
- bool has_fanspeed;
- struct gpu_adl *twin;
-};
-#endif
-
extern void blank_get_statline_before(char *buf, size_t bufsiz, struct cgpu_info __maybe_unused *cgpu);
struct api_data;
@@ -391,15 +349,6 @@ enum dev_enable {
DEV_RECOVER,
};
-enum cl_kernels {
- KL_NONE,
- KL_POCLBM,
- KL_PHATK,
- KL_DIAKGCN,
- KL_DIABLO,
- KL_SCRYPT,
-};
-
enum dev_reason {
REASON_THREAD_FAIL_INIT,
REASON_THREAD_ZERO_HASH,
@@ -996,7 +945,6 @@ extern bool opt_api_listen;
extern bool opt_api_network;
extern bool opt_delaynet;
extern bool opt_restart;
-extern bool opt_nogpu;
extern char *opt_icarus_options;
extern char *opt_icarus_timing;
extern bool opt_worktime;
@@ -1071,14 +1019,6 @@ extern void kill_work(void);
extern void reinit_device(struct cgpu_info *cgpu);
-#ifdef HAVE_ADL
-extern bool gpu_stats(int gpu, float *temp, int *engineclock, int *memclock, float *vddc, int *activity, int *fanspeed, int *fanpercent, int *powertune);
-extern int set_fanspeed(int gpu, int iFanSpeed);
-extern int set_vddc(int gpu, float fVddc);
-extern int set_engineclock(int gpu, int iEngineClock);
-extern int set_memoryclock(int gpu, int iMemoryClock);
-#endif
-
extern void api(int thr_id);
extern struct pool *current_pool(void);
@@ -1090,31 +1030,8 @@ extern void adjust_quota_gcd(void);
extern struct pool *add_pool(void);
extern bool add_pool_details(struct pool *pool, bool live, char *url, char *user, char *pass);
-#define MAX_GPUDEVICES 16
#define MAX_DEVICES 4096
-#define MIN_SHA_INTENSITY -10
-#define MIN_SHA_INTENSITY_STR "-10"
-#define MAX_SHA_INTENSITY 14
-#define MAX_SHA_INTENSITY_STR "14"
-#define MIN_SCRYPT_INTENSITY 8
-#define MIN_SCRYPT_INTENSITY_STR "8"
-#define MAX_SCRYPT_INTENSITY 20
-#define MAX_SCRYPT_INTENSITY_STR "20"
-#ifdef USE_SCRYPT
-#define MIN_INTENSITY (opt_scrypt ? MIN_SCRYPT_INTENSITY : MIN_SHA_INTENSITY)
-#define MIN_INTENSITY_STR (opt_scrypt ? MIN_SCRYPT_INTENSITY_STR : MIN_SHA_INTENSITY_STR)
-#define MAX_INTENSITY (opt_scrypt ? MAX_SCRYPT_INTENSITY : MAX_SHA_INTENSITY)
-#define MAX_INTENSITY_STR (opt_scrypt ? MAX_SCRYPT_INTENSITY_STR : MAX_SHA_INTENSITY_STR)
-#define MAX_GPU_INTENSITY MAX_SCRYPT_INTENSITY
-#else
-#define MIN_INTENSITY MIN_SHA_INTENSITY
-#define MIN_INTENSITY_STR MIN_SHA_INTENSITY_STR
-#define MAX_INTENSITY MAX_SHA_INTENSITY
-#define MAX_INTENSITY_STR MAX_SHA_INTENSITY_STR
-#define MAX_GPU_INTENSITY MAX_SHA_INTENSITY
-#endif
-
extern bool hotplug_mode;
extern int hotplug_time;
extern struct list_head scan_devices;
@@ -1125,13 +1042,6 @@ extern bool use_syslog;
extern bool opt_quiet;
extern struct thr_info *control_thr;
extern struct thr_info **mining_thr;
-extern struct cgpu_info gpus[MAX_GPUDEVICES];
-extern int gpu_threads;
-#ifdef USE_SCRYPT
-extern bool opt_scrypt;
-#else
-#define opt_scrypt (0)
-#endif
extern double total_secs;
extern int mining_threads;
extern int total_devices;
@@ -1329,9 +1239,7 @@ struct work {
unsigned char target[32];
unsigned char hash[32];
-#ifdef USE_SCRYPT
unsigned char device_target[32];
-#endif
double device_diff;
uint64_t share_diff;
diff --git a/usbutils.c b/usbutils.c
index 6aa3551..5011b9d 100644
--- a/usbutils.c
+++ b/usbutils.c
@@ -21,6 +21,7 @@
static pthread_mutex_t cgusb_lock;
static pthread_mutex_t cgusbres_lock;
static cglock_t cgusb_fd_lock;
+static cgtimer_t usb11_cgt;
#define NODEV(err) ((err) != LIBUSB_SUCCESS && (err) != LIBUSB_ERROR_TIMEOUT)
@@ -2445,17 +2446,22 @@ static int callback_wait(struct usb_transfer *ut, int *transferred, unsigned int
}
static int usb_submit_transfer(struct usb_transfer *ut, struct libusb_transfer *transfer,
- bool cancellable)
+ bool cancellable, bool tt)
{
int err;
INIT_LIST_HEAD(&ut->list);
cg_wlock(&cgusb_fd_lock);
+ /* Imitate a transaction translator for writes to usb1.1 devices */
+ if (tt)
+ cgsleep_ms_r(&usb11_cgt, 1);
err = libusb_submit_transfer(transfer);
if (likely(!err))
ut->cancellable = cancellable;
list_add(&ut->list, &ut_list);
+ if (tt)
+ cgtimer_time(&usb11_cgt);
cg_wunlock(&cgusb_fd_lock);
return err;
@@ -2465,7 +2471,7 @@ static int
usb_bulk_transfer(struct cgpu_info *cgpu, struct cg_usb_device *usbdev, int intinfo,
int epinfo, unsigned char *data, int length, int *transferred,
unsigned int timeout, __maybe_unused int mode, enum usb_cmds cmd,
- __maybe_unused int seq, bool cancellable)
+ __maybe_unused int seq, bool cancellable, bool tt)
{
int bulk_timeout, callback_timeout = timeout, pipe_retries = 0;
struct libusb_device_handle *dev_handle = usbdev->handle;
@@ -2499,7 +2505,11 @@ pipe_retry:
if ((endpoint & LIBUSB_ENDPOINT_DIR_MASK) == LIBUSB_ENDPOINT_OUT) {
memcpy(buf, data, length);
+#ifndef HAVE_LIBUSB
+ /* Older versions may not have this feature so only enable it
+ * when we know we're compiling with included static libusb */
ut.transfer->flags |= LIBUSB_TRANSFER_ADD_ZERO_PACKET;
+#endif
#ifdef WIN32
/* Writes on windows really don't like to be cancelled, but
* are prone to timeouts under heavy USB traffic, so make this
@@ -2514,7 +2524,7 @@ pipe_retry:
libusb_fill_bulk_transfer(ut.transfer, dev_handle, endpoint, buf, length,
transfer_callback, &ut, bulk_timeout);
STATS_TIMEVAL(&tv_start);
- err = usb_submit_transfer(&ut, ut.transfer, cancellable);
+ err = usb_submit_transfer(&ut, ut.transfer, cancellable, tt);
errn = errno;
if (!err)
err = callback_wait(&ut, transferred, callback_timeout);
@@ -2612,7 +2622,7 @@ int _usb_read(struct cgpu_info *cgpu, int intinfo, int epinfo, char *buf, size_t
while (bufleft > 0 && !eom) {
err = usb_bulk_transfer(cgpu, usbdev, intinfo, epinfo, ptr, usbbufread,
&got, timeout, MODE_BULK_READ, cmd,
- first ? SEQ0 : SEQ1, cancellable);
+ first ? SEQ0 : SEQ1, cancellable, false);
cgtime(&tv_finish);
ptr[got] = '\0';
@@ -2635,6 +2645,18 @@ int _usb_read(struct cgpu_info *cgpu, int intinfo, int epinfo, char *buf, size_t
if (end != NULL)
eom = strstr((const char *)usbbuf, end);
+ /* Attempt a usb reset for an error that will otherwise cause
+ * this device to drop out provided we know the device still
+ * might exist. */
+ if (err && err != LIBUSB_ERROR_TIMEOUT) {
+ applog(LOG_WARNING, "%s %i %s usb read err:(%d) %s", cgpu->drv->name,
+ cgpu->device_id, usb_cmdname(cmd), err, libusb_error_name(err));
+ if (err != LIBUSB_ERROR_NO_DEVICE) {
+ err = libusb_reset_device(usbdev->handle);
+ applog(LOG_WARNING, "%s %i attempted reset got err:(%d) %s",
+ cgpu->drv->name, cgpu->device_id, err, libusb_error_name(err));
+ }
+ }
if (err || readonce)
break;
@@ -2674,12 +2696,6 @@ int _usb_read(struct cgpu_info *cgpu, int intinfo, int epinfo, char *buf, size_t
*processed = tot;
memcpy((char *)buf, (const char *)usbbuf, (tot < (int)bufsiz) ? tot + 1 : (int)bufsiz);
- if (err && err != LIBUSB_ERROR_TIMEOUT) {
- applog(LOG_WARNING, "%s %i %s usb read err:(%d) %s", cgpu->drv->name, cgpu->device_id, usb_cmdname(cmd),
- err, libusb_error_name(err));
- if (cgpu->usbinfo.continuous_ioerr_count > USB_RETRY_MAX)
- err = LIBUSB_ERROR_OTHER;
- }
out_noerrmsg:
if (NODEV(err)) {
cg_ruwlock(&cgpu->usbinfo.devlock);
@@ -2740,7 +2756,7 @@ int _usb_write(struct cgpu_info *cgpu, int intinfo, int epinfo, char *buf, size_
}
err = usb_bulk_transfer(cgpu, usbdev, intinfo, epinfo, (unsigned char *)buf,
tosend, &sent, timeout, MODE_BULK_WRITE,
- cmd, first ? SEQ0 : SEQ1, false);
+ cmd, first ? SEQ0 : SEQ1, false, usb11);
cgtime(&tv_finish);
USBDEBUG("USB debug: @_usb_write(%s (nodev=%s)) err=%d%s sent=%d", cgpu->drv->name, bool_str(cgpu->usbinfo.nodev), err, isnodev(err), sent);
@@ -2749,6 +2765,17 @@ int _usb_write(struct cgpu_info *cgpu, int intinfo, int epinfo, char *buf, size_
tot += sent;
+ /* Unlike reads, even a timeout error is unrecoverable on
+ * writes. */
+ if (err) {
+ applog(LOG_WARNING, "%s %i %s usb write err:(%d) %s", cgpu->drv->name,
+ cgpu->device_id, usb_cmdname(cmd), err, libusb_error_name(err));
+ if (err != LIBUSB_ERROR_NO_DEVICE) {
+ err = libusb_reset_device(usbdev->handle);
+ applog(LOG_WARNING, "%s %i attempted reset got err:(%d) %s",
+ cgpu->drv->name, cgpu->device_id, err, libusb_error_name(err));
+ }
+ }
if (err)
break;
@@ -2766,12 +2793,6 @@ int _usb_write(struct cgpu_info *cgpu, int intinfo, int epinfo, char *buf, size_
*processed = tot;
- if (err) {
- applog(LOG_WARNING, "%s %i %s usb write err:(%d) %s", cgpu->drv->name, cgpu->device_id, usb_cmdname(cmd),
- err, libusb_error_name(err));
- if (cgpu->usbinfo.continuous_ioerr_count > USB_RETRY_MAX)
- err = LIBUSB_ERROR_OTHER;
- }
out_noerrmsg:
if (NODEV(err)) {
cg_ruwlock(&cgpu->usbinfo.devlock);
@@ -2793,6 +2814,7 @@ static int usb_control_transfer(struct cgpu_info *cgpu, libusb_device_handle *de
struct usb_transfer ut;
unsigned char buf[70];
int err, transferred;
+ bool tt = false;
if (unlikely(cgpu->shutdown))
return libusb_control_transfer(dev_handle, bmRequestType, bRequest, wValue, wIndex, buffer, wLength, timeout);
@@ -2800,11 +2822,14 @@ static int usb_control_transfer(struct cgpu_info *cgpu, libusb_device_handle *de
init_usb_transfer(&ut);
libusb_fill_control_setup(buf, bmRequestType, bRequest, wValue,
wIndex, wLength);
- if ((bmRequestType & LIBUSB_ENDPOINT_DIR_MASK) == LIBUSB_ENDPOINT_OUT)
+ if ((bmRequestType & LIBUSB_ENDPOINT_DIR_MASK) == LIBUSB_ENDPOINT_OUT) {
memcpy(buf + LIBUSB_CONTROL_SETUP_SIZE, buffer, wLength);
+ if (cgpu->usbdev->descriptor->bcdUSB < 0x0200)
+ tt = true;
+ }
libusb_fill_control_transfer(ut.transfer, dev_handle, buf, transfer_callback,
&ut, 0);
- err = usb_submit_transfer(&ut, ut.transfer, false);
+ err = usb_submit_transfer(&ut, ut.transfer, false, tt);
if (!err)
err = callback_wait(&ut, &transferred, timeout);
if (err == LIBUSB_SUCCESS && transferred) {
diff --git a/util.c b/util.c
index 0e9670c..4e292d4 100644
--- a/util.c
+++ b/util.c
@@ -2601,6 +2601,25 @@ int _cgsem_mswait(cgsem_t *cgsem, int ms, const char *file, const char *func, co
/* We don't reach here */
return 0;
}
+
+/* Reset semaphore count back to zero */
+void cgsem_reset(cgsem_t *cgsem)
+{
+ int ret, fd;
+ fd_set rd;
+ char buf;
+
+ fd = cgsem->pipefd[0];
+ FD_ZERO(&rd);
+ FD_SET(fd, &rd);
+ do {
+ struct timeval timeout = {0, 0};
+
+ ret = select(fd + 1, &rd, NULL, NULL, &timeout);
+ if (ret > 0)
+ ret = read(fd, &buf, 1);
+ } while (ret > 0);
+}
#else
void _cgsem_init(cgsem_t *cgsem, const char *file, const char *func, const int line)
{
@@ -2641,6 +2660,15 @@ int _cgsem_mswait(cgsem_t *cgsem, int ms, const char *file, const char *func, co
return 0;
}
+void cgsem_reset(cgsem_t *cgsem)
+{
+ int ret;
+
+ do {
+ ret = sem_trywait(cgsem);
+ } while (!ret);
+}
+
void cgsem_destroy(cgsem_t *cgsem)
{
sem_destroy(cgsem);
diff --git a/util.h b/util.h
index d359656..90b1ca9 100644
--- a/util.h
+++ b/util.h
@@ -138,6 +138,7 @@ void _cgsem_init(cgsem_t *cgsem, const char *file, const char *func, const int l
void _cgsem_post(cgsem_t *cgsem, const char *file, const char *func, const int line);
void _cgsem_wait(cgsem_t *cgsem, const char *file, const char *func, const int line);
int _cgsem_mswait(cgsem_t *cgsem, int ms, const char *file, const char *func, const int line);
+void cgsem_reset(cgsem_t *cgsem);
void cgsem_destroy(cgsem_t *cgsem);
bool cg_completion_timeout(void *fn, void *fnarg, int timeout);