Commit 9ccfcee6dce1a3d46ec9bc2bf71ca7c5076f2038

Con Kolivas 2012-10-12T14:55:52

Prevent overflows of the port char array in extract_sockaddr.

1
2
3
4
5
6
7
8
9
10
11
12
13
diff --git a/util.c b/util.c
index 91a6718..2fb8667 100644
--- a/util.c
+++ b/util.c
@@ -832,7 +832,7 @@ bool extract_sockaddr(struct pool *pool, char *url)
 	sprintf(url_address, "%.*s", url_len, url_begin);
 
 	if (port_len)
-		sprintf(port, "%.*s", port_len, port_start);
+		snprintf(port, 5, "%.*s", port_len, port_start);
 	else
 		strcpy(port, "80");