Make scrypt submission use the submit_nonce code, with nonces matching endianness.
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72
diff --git a/driver-cpu.c b/driver-cpu.c
index 6e563c5..2f72abc 100644
--- a/driver-cpu.c
+++ b/driver-cpu.c
@@ -75,7 +75,6 @@ static inline void affine_to_cpu(int __maybe_unused id, int __maybe_unused cpu)
/* TODO: resolve externals */
-extern void submit_work_async(const struct work *work_in, struct timeval *tv);
extern char *set_int_range(const char *arg, int *i, int min, int max);
extern int dev_from_id(int thr_id);
@@ -833,7 +832,7 @@ CPUSearch:
/* if nonce found, submit work */
if (unlikely(rc)) {
applog(LOG_DEBUG, "CPU %d found something?", dev_from_id(thr_id));
- submit_work_async(work, NULL);
+ submit_nonce(thr, work, last_nonce);
work->blk.nonce = last_nonce + 1;
goto CPUSearch;
}
diff --git a/scrypt.c b/scrypt.c
index 3d92c15..da334df 100644
--- a/scrypt.c
+++ b/scrypt.c
@@ -419,10 +419,12 @@ void scrypt_regenhash(struct work *work)
flip32(ohash, ohash);
}
+static const uint32_t diff1targ = 0x0000ffff;
+
/* Used externally as confirmation of correct OCL code */
int scrypt_test(unsigned char *pdata, const unsigned char *ptarget, uint32_t nonce)
{
- uint32_t tmp_hash7, Htarg = ((const uint32_t *)ptarget)[7];
+ uint32_t tmp_hash7, Htarg = le32toh(((const uint32_t *)ptarget)[7]);
uint32_t data[20], ohash[8];
char *scratchbuf;
@@ -432,10 +434,11 @@ int scrypt_test(unsigned char *pdata, const unsigned char *ptarget, uint32_t non
scrypt_1024_1_1_256_sp(data, scratchbuf, ohash);
tmp_hash7 = be32toh(ohash[7]);
- /* FIXME: Needs to be able to return 0 as well for not meeting target
- * but target diff currently is sent to devices. */
- if (tmp_hash7 > Htarg)
+ applog(LOG_DEBUG, "harget %08lx diff1 %08lx hash %08lx", Htarg, diff1targ, tmp_hash7);
+ if (tmp_hash7 > diff1targ)
return -1;
+ if (tmp_hash7 > Htarg)
+ return 0;
return 1;
}
@@ -448,7 +451,7 @@ bool scanhash_scrypt(struct thr_info *thr, const unsigned char __maybe_unused *p
char *scratchbuf;
uint32_t data[20];
uint32_t tmp_hash7;
- uint32_t Htarg = ((const uint32_t *)ptarget)[7];
+ uint32_t Htarg = le32toh(((const uint32_t *)ptarget)[7]);
bool ret = false;
be32enc_vect(data, (const uint32_t *)pdata, 19);
@@ -463,7 +466,7 @@ bool scanhash_scrypt(struct thr_info *thr, const unsigned char __maybe_unused *p
uint32_t ostate[8];
*nonce = ++n;
- data[19] = n;
+ data[19] = htobe32(n);
scrypt_1024_1_1_256_sp(data, scratchbuf, ostate);
tmp_hash7 = be32toh(ostate[7]);