Commit 04ca23f4590f27f82af9ef2a837afe86683d7339

Stefan Sperling 2018-07-16T13:05:23

allow filtering history by paths in 'got log'

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
diff --git a/got/got.1 b/got/got.1
index b7807ca..d087539 100644
--- a/got/got.1
+++ b/got/got.1
@@ -91,11 +91,11 @@ will be checked out.
 .El
 .\".It Cm status
 .\"Show current status of files.
-.It Cm log [ Fl c Ar commit ] [ Fl f ] [ Fl l Ar N ] [ Fl p ] [ Ar repository-path ]
+.It Cm log [ Fl c Ar commit ] [ Fl f ] [ Fl l Ar N ] [ Fl p ] [ Fl r Ar repository-path ] [ path ]
 Display history of a repository.
-If the
-.Ar repository path
-is omitted, assume the repository is located in the current working directory.
+If a
+.Ar path
+is specified, show only commits which modified this path.
 .Pp
 The options for
 .Cm got log
@@ -115,6 +115,10 @@ individual commits which originated on other branches will be omitted.
 Limit history traversal to a given number of commits.
 .It Fl p
 Display the patch of modifications made in each commit.
+.It Fl r Ar repository-path
+Use the repository at the specified path.
+If not specified, assume the repository is located at or above the current
+working directory.
 .El
 .It Cm diff [ Ar repository-path ] Ar object1 Ar object2
 Display the differences between two objects in the repository.
diff --git a/got/got.c b/got/got.c
index bbdd8fe..005060e 100644
--- a/got/got.c
+++ b/got/got.c
@@ -386,12 +386,12 @@ print_commit(struct got_commit_object *commit, struct got_object_id *id,
 
 static const struct got_error *
 print_commits(struct got_object *root_obj, struct got_object_id *root_id,
-    struct got_repository *repo, int show_patch, int limit,
+    struct got_repository *repo, char *path, int show_patch, int limit,
     int first_parent_traversal)
 {
 	const struct got_error *err;
 	struct got_commit_graph *graph;
-	int ncommits;
+	int ncommits, found_obj = 0;
 
 	err = got_commit_graph_open(&graph, root_id, first_parent_traversal,
 	    repo);
@@ -425,6 +425,48 @@ print_commits(struct got_object *root_obj, struct got_object_id *root_id,
 		err = got_object_open_as_commit(&commit, repo, id);
 		if (err)
 			return err;
+		if (path) {
+			struct got_object *obj;
+			struct got_object_qid *pid;
+			int changed = 1;
+
+			err = got_object_open_by_path(&obj, repo, id, path);
+			if (err) {
+				if (err->code == GOT_ERR_NO_OBJ && found_obj) {
+					/*
+					 * Object was added in previous commit.
+					 * History stops here.
+					 */
+					err = NULL;
+				}
+				break;
+			}
+			found_obj = 1;
+
+			pid = SIMPLEQ_FIRST(&commit->parent_ids);
+			if (pid != NULL) {
+				struct got_object *pobj;
+				err = got_object_open_by_path(&pobj, repo,
+				    pid->id, path);
+				if (err) {
+					if (err->code != GOT_ERR_NO_OBJ) {
+						got_object_close(obj);
+						break;
+					}
+					err = NULL;
+					changed = 1;
+				} else {
+					changed = got_object_id_cmp(
+					    got_object_get_id(obj),
+					    got_object_get_id(pobj));
+					got_object_close(pobj);
+				}
+			}
+			if (!changed) {
+				got_object_commit_close(commit);
+				continue;
+			}
+		}
 		err = print_commit(commit, id, repo, show_patch);
 		got_object_commit_close(commit);
 		if (err || (limit && --limit == 0))
@@ -439,7 +481,7 @@ __dead static void
 usage_log(void)
 {
 	fprintf(stderr, "usage: %s log [-c commit] [-f] [ -l N ] [-p] "
-	    "[repository-path]\n", getprogname());
+	    "[-r repository-path] [path]\n", getprogname());
 	exit(1);
 }
 
@@ -447,10 +489,10 @@ static const struct got_error *
 cmd_log(int argc, char *argv[])
 {
 	const struct got_error *error;
-	struct got_repository *repo;
+	struct got_repository *repo = NULL;
 	struct got_object_id *id = NULL;
 	struct got_object *obj = NULL;
-	char *repo_path = NULL;
+	char *repo_path = NULL, *path = NULL, *cwd = NULL, *in_repo_path = NULL;
 	char *start_commit = NULL;
 	int ch;
 	int show_patch = 0, limit = 0, first_parent_traversal = 0;
@@ -461,7 +503,7 @@ cmd_log(int argc, char *argv[])
 		err(1, "pledge");
 #endif
 
-	while ((ch = getopt(argc, argv, "pc:l:f")) != -1) {
+	while ((ch = getopt(argc, argv, "pc:l:fr:")) != -1) {
 		switch (ch) {
 		case 'p':
 			show_patch = 1;
@@ -477,6 +519,11 @@ cmd_log(int argc, char *argv[])
 		case 'f':
 			first_parent_traversal = 1;
 			break;
+		case 'r':
+			repo_path = realpath(optarg, NULL);
+			if (repo_path == NULL)
+				err(1, "-r option");
+			break;
 		default:
 			usage();
 			/* NOTREACHED */
@@ -486,21 +533,31 @@ cmd_log(int argc, char *argv[])
 	argc -= optind;
 	argv += optind;
 
-	if (argc == 0) {
-		repo_path = getcwd(NULL, 0);
-		if (repo_path == NULL)
-			return got_error_from_errno();
-	} else if (argc == 1) {
-		repo_path = realpath(argv[0], NULL);
-		if (repo_path == NULL)
-			return got_error_from_errno();
-	} else
+	if (argc == 0)
+		path = strdup("");
+	else if (argc == 1)
+		path = strdup(argv[0]);
+	else
 		usage_log();
+	if (path == NULL)
+		return got_error_from_errno();
+
+	cwd = getcwd(NULL, 0);
+	if (cwd == NULL) {
+		error = got_error_from_errno();
+		goto done;
+	}
+	if (repo_path == NULL) {
+		repo_path = strdup(cwd);
+		if (repo_path == NULL) {
+			error = got_error_from_errno();
+			goto done;
+		}
+	}
 
 	error = got_repo_open(&repo, repo_path);
-	free(repo_path);
 	if (error != NULL)
-		return error;
+		goto done;
 
 	if (start_commit == NULL) {
 		struct got_reference *head_ref;
@@ -535,15 +592,31 @@ cmd_log(int argc, char *argv[])
 		}
 	}
 	if (error != NULL)
-		return error;
-	if (got_object_get_type(obj) == GOT_OBJ_TYPE_COMMIT)
-		error = print_commits(obj, id, repo, show_patch, limit,
-		    first_parent_traversal);
-	else
+		goto done;
+	if (got_object_get_type(obj) != GOT_OBJ_TYPE_COMMIT) {
 		error = got_error(GOT_ERR_OBJ_TYPE);
-	got_object_close(obj);
+		goto done;
+	}
+
+	error = got_repo_map_path(&in_repo_path, repo, path);
+	if (error != NULL)
+		goto done;
+	if (in_repo_path) {
+		free(path);
+		path = in_repo_path;
+	}
+
+	error = print_commits(obj, id, repo, path, show_patch,
+	    limit, first_parent_traversal);
+done:
+	free(path);
+	free(repo_path);
+	free(cwd);
+	if (obj)
+		got_object_close(obj);
 	free(id);
-	got_repo_close(repo);
+	if (repo)
+		got_repo_close(repo);
 	return error;
 }
 
diff --git a/include/got_repository.h b/include/got_repository.h
index c60c51c..3f8ef8c 100644
--- a/include/got_repository.h
+++ b/include/got_repository.h
@@ -38,3 +38,11 @@ struct got_reference;
  */
 const struct got_error *got_repo_get_reference(struct got_reference **,
     struct got_repository *, const char *);
+
+
+/* Indicate whether this is a bare repositiry (contains no git working tree). */
+int got_repo_is_bare(struct got_repository *);
+
+/* Attempt to map an arbitrary path to a path within the repository. */
+const struct got_error *got_repo_map_path(char **, struct got_repository *,
+    const char *);
diff --git a/lib/got_lib_path.h b/lib/got_lib_path.h
index af17675..1d1d155 100644
--- a/lib/got_lib_path.h
+++ b/lib/got_lib_path.h
@@ -40,3 +40,11 @@ char *got_path_normalize(const char *);
  * Relative paths are copied from input to buf as-is.
  */
 const struct got_error *got_canonpath(const char *, char *, size_t);
+
+/*
+ * Get child part of two absolute paths. The second path must equal the first
+ * path up to some path component, and must be longer than the first path.
+ * The result is allocated with malloc(3).
+ */
+const struct got_error *got_path_skip_common_ancestor(char **, const char *,
+    const char *);
diff --git a/lib/path.c b/lib/path.c
index d14f81c..e874cb7 100644
--- a/lib/path.c
+++ b/lib/path.c
@@ -105,3 +105,31 @@ got_canonpath(const char *input, char *buf, size_t bufsize)
 	} else
 		return got_error(GOT_ERR_NO_SPACE);
 }
+
+const struct got_error *
+got_path_skip_common_ancestor(char **child, const char *parent_abspath,
+    const char *abspath)
+{
+	const struct got_error *err = NULL;
+	size_t len_parent, len, bufsize;
+
+	len_parent = strlen(parent_abspath);
+	len = strlen(abspath);
+	if (len_parent >= len)
+		return got_error(GOT_ERR_BAD_PATH);
+	if (strncmp(parent_abspath, abspath, len_parent) != 0)
+		return got_error(GOT_ERR_BAD_PATH);
+	if (abspath[len_parent] != '/')
+		return got_error(GOT_ERR_BAD_PATH);
+	bufsize = len - len_parent + 1;
+	*child = malloc(bufsize);
+	if (*child == NULL)
+		return got_error_from_errno();
+	if (strlcpy(*child, abspath + len_parent, bufsize) >= bufsize) {
+		err = got_error_from_errno();
+		free(*child);
+		*child = NULL;
+		return err;
+	}
+	return NULL;
+}
diff --git a/lib/repository.c b/lib/repository.c
index ed9663e..59b728c 100644
--- a/lib/repository.c
+++ b/lib/repository.c
@@ -69,6 +69,12 @@ got_repo_get_path_git_dir(struct got_repository *repo)
 	return strdup(repo->path_git_dir);
 }
 
+int
+got_repo_is_bare(struct got_repository *repo)
+{
+	return (strcmp(repo->path, repo->path_git_dir) == 0);
+}
+
 static char *
 get_path_git_child(struct got_repository *repo, const char *basename)
 {
@@ -550,3 +556,138 @@ got_repo_close(struct got_repository *repo)
 		got_object_idcache_free(repo->commitcache.idcache);
 	free(repo);
 }
+
+const struct got_error *
+got_repo_map_path(char **in_repo_path, struct got_repository *repo,
+    const char *input_path)
+{
+	const struct got_error *err = NULL;
+	char *repo_abspath = NULL, *cwd = NULL;
+	struct stat sb;
+	size_t repolen, cwdlen, len;
+	char *canonpath, *path;
+
+	*in_repo_path = NULL;
+
+	cwd = getcwd(NULL, 0);
+	if (cwd == NULL)
+		return got_error_from_errno();
+
+	canonpath = strdup(input_path);
+	if (canonpath == NULL) {
+		err = got_error_from_errno();
+		goto done;
+	}
+	err = got_canonpath(input_path, canonpath, strlen(canonpath) + 1);
+	if (err)
+		goto done;
+
+	repo_abspath = got_repo_get_path(repo);
+	if (repo_abspath == NULL) {
+		err = got_error_from_errno();
+		goto done;
+	}
+
+	/* TODO: Call "get in-repository path of work-tree node" API. */
+
+	if (lstat(canonpath, &sb) != 0) {
+		if (errno != ENOENT) {
+			err = got_error_from_errno();
+			goto done;
+		}
+		/*
+		 * Path is not on disk.
+		 * Assume it is already relative to repository root.
+		 */
+		path = strdup(canonpath);
+	} else {
+		int is_repo_child = 0, is_cwd_child = 0;
+
+		path = realpath(canonpath, NULL);
+		if (path == NULL) {
+			err = got_error_from_errno();
+			goto done;
+		}
+
+		repolen = strlen(repo_abspath);
+		cwdlen = strlen(cwd);
+		len = strlen(path);
+
+		if (len > repolen && strncmp(path, repo_abspath, repolen) == 0)
+			is_repo_child = 1;
+		if (len > cwdlen && strncmp(path, cwd, cwdlen) == 0)
+			is_cwd_child = 1;
+
+		if (strcmp(path, repo_abspath) == 0) {
+			free(path);
+			path = strdup("");
+			if (path == NULL) {
+				err = got_error_from_errno();
+				goto done;
+			}
+		} else if (is_repo_child && is_cwd_child) {
+			char *child;
+			/* TODO: Is path inside a got worktree? */
+			/* Strip common prefix with repository path. */
+			err = got_path_skip_common_ancestor(&child,
+			    repo_abspath, path);
+			if (err)
+				goto done;
+			free(path);
+			path = child;
+		} else if (is_repo_child) {
+			/* Matched an on-disk path inside repository. */
+			if (got_repo_is_bare(repo)) {
+				/*
+				 * Matched an on-disk path inside repository
+				 * database. Treat as repository-relative.
+				 */
+			} else {
+				char *child;
+				/* Strip common prefix with repository path. */
+				err = got_path_skip_common_ancestor(&child,
+				    repo_abspath, path);
+				if (err)
+					goto done;
+				free(path);
+				path = child;
+			}
+		} else if (is_cwd_child) {
+			char *child;
+			/* TODO: Is path inside a got worktree? */
+			/* Strip common prefix with cwd. */
+			err = got_path_skip_common_ancestor(&child, cwd,
+			    path);
+			if (err)
+				goto done;
+			free(path);
+			path = child;
+		} else {
+			/*
+			 * Matched unrelated on-disk path.
+			 * Treat it as repository-relative.
+			 */
+		}
+	}
+
+	/* Make in-repository path absolute */
+	if (path[0] != '/') {
+		char *abspath;
+		if (asprintf(&abspath, "/%s", path) == -1) {
+			err = got_error_from_errno();
+			goto done;
+		}
+		free(path);
+		path = abspath;
+	}
+
+done:
+	free(repo_abspath);
+	free(cwd);
+	free(canonpath);
+	if (err)
+		free(path);
+	else
+		*in_repo_path = path;
+	return err;
+}