add support for fetching specific branches to 'got clone' and 'got fetch'
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733
diff --git a/got/got.1 b/got/got.1
index 21ccb8a..869f13d 100644
--- a/got/got.1
+++ b/got/got.1
@@ -136,7 +136,7 @@ follows the globbing rules documented in
.It Cm im
Short alias for
.Cm import .
-.It Cm clone Oo Fl a Oc Oo Fl q Oc Oo Fl v Oc Ar repository-URL Op Ar directory
+.It Cm clone Oo Fl a Oc Oo Fl b Ar branch Oc Oo Fl q Oc Oo Fl v Oc Ar repository-URL Op Ar directory
Clone a Git repository at the specified
.Ar repository-URL
into the specified
@@ -203,8 +203,25 @@ are as follows:
.Bl -tag -width Ds
.It Fl a
Fetch all branches from the remote repository.
-If this option is not specified, a branch resolved via the repository's HEAD
-reference will be fetched.
+If this option is not specified, a branch resolved via the remote
+repository's HEAD reference will be fetched.
+Cannot be used together with the
+.Fl b
+option.
+.It Fl b Ar branch
+Fetch the specified
+.Ar branch
+from the remote repository.
+This option may be specified multiple times to build a list of branches
+to fetch.
+If the branch corresponding to the remote repository's HEAD reference is not
+in this list, the cloned repository's HEAD reference will be set to the first
+branch which was fetched.
+If this option is not specified, a branch resolved via the remote
+repository's HEAD reference will be fetched.
+Cannot be used together with the
+.Fl a
+option.
.It Fl m
Create the cloned repository as a mirror of the original repository.
This is useful if the cloned repository will not be used to store
@@ -250,11 +267,11 @@ The maximum is 3.
.It Cm cl
Short alias for
.Cm clone .
-.It Cm fetch Oo Fl a Oc Oo Fl r Ar repository-path Oc Oo Fl q Oc Oo Fl v Oc Op Ar remote-repository-name
+.It Cm fetch Oo Fl a Oc Oo Fl b Ar branch Oc Oo Fl r Ar repository-path Oc Oo Fl q Oc Oo Fl v Oc Op Ar remote-repository
Fetch new changes from a remote repository.
If no
-.Ar remote-repository-name
-is specified the name
+.Ar remote-repository
+is specified,
.Dq origin
will be used.
The remote repository's URL is obtained from the corresponding entry in the
@@ -295,8 +312,22 @@ are as follows:
.Bl -tag -width Ds
.It Fl a
Fetch all branches from the remote repository.
-If this option is not specified, a branch resolved via the repository's HEAD
-reference will be fetched.
+If this option is not specified, a branch resolved via the remote
+repository's HEAD reference will be fetched.
+Cannot be used together with the
+.Fl b
+option.
+.It Fl b Ar branch
+Fetch the specified
+.Ar branch
+from the remote repository.
+This option may be specified multiple times to build a list of branches
+to fetch.
+If this option is not specified, a branch resolved via the remote
+repository's HEAD reference will be fetched.
+Cannot be used together with the
+.Fl a
+option.
.It Fl r Ar repository-path
Use the repository at the specified path.
If not specified, assume the repository is located at or above the current
diff --git a/got/got.c b/got/got.c
index c73a14b..4ba89fc 100644
--- a/got/got.c
+++ b/got/got.c
@@ -811,8 +811,8 @@ done:
__dead static void
usage_clone(void)
{
- fprintf(stderr, "usage: %s clone [-a] [-m] [-q] [-v] repository-url "
- "[directory]\n", getprogname());
+ fprintf(stderr, "usage: %s clone [-a] [-b branch] [-m] [-q] [-v] "
+ "repository-url [directory]\n", getprogname());
exit(1);
}
@@ -885,6 +885,21 @@ fetch_progress(void *arg, const char *message, off_t packfile_size,
}
static const struct got_error *
+create_head_ref(struct got_reference *target_ref, struct got_repository *repo)
+{
+ const struct got_error *err;
+ struct got_reference *head_symref;
+
+ err = got_ref_alloc_symref(&head_symref, GOT_REF_HEAD, target_ref);
+ if (err)
+ return err;
+
+ err = got_ref_write(head_symref, repo);
+ got_ref_close(head_symref);
+ return err;
+}
+
+static const struct got_error *
cmd_clone(int argc, char *argv[])
{
const struct got_error *error = NULL;
@@ -893,7 +908,7 @@ cmd_clone(int argc, char *argv[])
char *default_destdir = NULL, *id_str = NULL;
const char *repo_path;
struct got_repository *repo = NULL;
- struct got_pathlist_head refs, symrefs;
+ struct got_pathlist_head refs, symrefs, wanted_branches;
struct got_pathlist_entry *pe;
struct got_object_id *pack_hash = NULL;
int ch, fetchfd = -1;
@@ -908,12 +923,19 @@ cmd_clone(int argc, char *argv[])
TAILQ_INIT(&refs);
TAILQ_INIT(&symrefs);
+ TAILQ_INIT(&wanted_branches);
- while ((ch = getopt(argc, argv, "amvq")) != -1) {
+ while ((ch = getopt(argc, argv, "ab:mvq")) != -1) {
switch (ch) {
case 'a':
fetch_all_branches = 1;
break;
+ case 'b':
+ error = got_pathlist_append(&wanted_branches,
+ optarg, NULL);
+ if (error)
+ return error;
+ break;
case 'm':
mirror_references = 1;
break;
@@ -934,6 +956,9 @@ cmd_clone(int argc, char *argv[])
argc -= optind;
argv += optind;
+ if (fetch_all_branches && !TAILQ_EMPTY(&wanted_branches))
+ errx(1, "-a and -b options are mutually exclusive\n");
+
uri = argv[0];
if (argc == 1)
@@ -1023,7 +1048,8 @@ cmd_clone(int argc, char *argv[])
fpa.verbosity = verbosity;
error = got_fetch_pack(&pack_hash, &refs, &symrefs,
GOT_FETCH_DEFAULT_REMOTE_NAME, mirror_references,
- fetch_all_branches, fetchfd, repo, fetch_progress, &fpa);
+ fetch_all_branches, &wanted_branches, fetchfd,
+ repo, fetch_progress, &fpa);
if (error)
goto done;
@@ -1088,19 +1114,41 @@ cmd_clone(int argc, char *argv[])
goto done;
}
- error = got_ref_alloc_symref(&head_symref,
- GOT_REF_HEAD, target_ref);
+ if (verbosity >= 0)
+ printf("Setting %s to %s\n", refname, target);
+ error = create_head_ref(target_ref, repo);
got_ref_close(target_ref);
if (error)
goto done;
+ }
+ if (pe == NULL) {
+ /*
+ * We failed to set the HEAD reference. If we asked for
+ * a set of wanted branches use the first of one of those
+ * which could be fetched instead.
+ */
+ TAILQ_FOREACH(pe, &wanted_branches, entry) {
+ const char *target = pe->path;
+ struct got_reference *target_ref;
- if (verbosity >= 0)
- printf("Setting %s to %s\n", GOT_REF_HEAD,
- got_ref_get_symref_target(head_symref));
+ error = got_ref_open(&target_ref, repo, target, 0);
+ if (error) {
+ if (error->code == GOT_ERR_NOT_REF) {
+ error = NULL;
+ continue;
+ }
+ goto done;
+ }
- error = got_ref_write(head_symref, repo);
- if (error)
- goto done;
+ if (verbosity >= 0)
+ printf("Setting %s to %s\n", GOT_REF_HEAD,
+ got_ref_get_name(target_ref));
+ error = create_head_ref(target_ref, repo);
+ got_ref_close(target_ref);
+ if (error)
+ goto done;
+ break;
+ }
}
/* Create a config file git-fetch(1) can understand. */
@@ -1187,6 +1235,7 @@ done:
free(pe->data);
}
got_pathlist_free(&symrefs);
+ got_pathlist_free(&wanted_branches);
free(pack_hash);
free(proto);
free(host);
@@ -1268,8 +1317,8 @@ done:
__dead static void
usage_fetch(void)
{
- fprintf(stderr, "usage: %s fetch [-a] [-r repository-path] [-q] [-v] "
- "[remote-repository-name]\n", getprogname());
+ fprintf(stderr, "usage: %s fetch [-a] [-b branch] [-r repository-path] "
+ "[-q] [-v] [remote-repository-name]\n", getprogname());
exit(1);
}
@@ -1286,7 +1335,7 @@ cmd_fetch(int argc, char *argv[])
char *id_str = NULL;
struct got_repository *repo = NULL;
struct got_worktree *worktree = NULL;
- struct got_pathlist_head refs, symrefs;
+ struct got_pathlist_head refs, symrefs, wanted_branches;
struct got_pathlist_entry *pe;
struct got_object_id *pack_hash = NULL;
int i, ch, fetchfd = -1;
@@ -1295,12 +1344,19 @@ cmd_fetch(int argc, char *argv[])
TAILQ_INIT(&refs);
TAILQ_INIT(&symrefs);
+ TAILQ_INIT(&wanted_branches);
- while ((ch = getopt(argc, argv, "ar:vq")) != -1) {
+ while ((ch = getopt(argc, argv, "ab:r:vq")) != -1) {
switch (ch) {
case 'a':
fetch_all_branches = 1;
break;
+ case 'b':
+ error = got_pathlist_append(&wanted_branches,
+ optarg, NULL);
+ if (error)
+ return error;
+ break;
case 'r':
repo_path = realpath(optarg, NULL);
if (repo_path == NULL)
@@ -1325,6 +1381,9 @@ cmd_fetch(int argc, char *argv[])
argc -= optind;
argv += optind;
+ if (fetch_all_branches && !TAILQ_EMPTY(&wanted_branches))
+ errx(1, "-a and -b options are mutually exclusive\n");
+
if (argc == 0)
remote_name = GOT_FETCH_DEFAULT_REMOTE_NAME;
else if (argc == 1)
@@ -1427,8 +1486,8 @@ cmd_fetch(int argc, char *argv[])
fpa.last_p_resolved = -1;
fpa.verbosity = verbosity;
error = got_fetch_pack(&pack_hash, &refs, &symrefs, remote->name,
- remote->mirror_references, fetch_all_branches, fetchfd, repo,
- fetch_progress, &fpa);
+ remote->mirror_references, fetch_all_branches, &wanted_branches,
+ fetchfd, repo, fetch_progress, &fpa);
if (error)
goto done;
@@ -1526,6 +1585,7 @@ done:
free(pe->data);
}
got_pathlist_free(&symrefs);
+ got_pathlist_free(&wanted_branches);
free(id_str);
free(cwd);
free(repo_path);
diff --git a/include/got_fetch.h b/include/got_fetch.h
index 14f29c4..a7b9590 100644
--- a/include/got_fetch.h
+++ b/include/got_fetch.h
@@ -61,4 +61,5 @@ typedef const struct got_error *(*got_fetch_progress_cb)(void *,
*/
const struct got_error *got_fetch_pack(struct got_object_id **,
struct got_pathlist_head *, struct got_pathlist_head *, const char *,
- int, int, int, struct got_repository *, got_fetch_progress_cb, void *);
+ int, int, struct got_pathlist_head *, int, struct got_repository *,
+ got_fetch_progress_cb, void *);
diff --git a/lib/fetch.c b/lib/fetch.c
index e36d5b8..d9e55b8 100644
--- a/lib/fetch.c
+++ b/lib/fetch.c
@@ -387,7 +387,8 @@ check_pack_hash(int fd, size_t sz, uint8_t *hcomp)
const struct got_error*
got_fetch_pack(struct got_object_id **pack_hash, struct got_pathlist_head *refs,
struct got_pathlist_head *symrefs, const char *remote_name,
- int mirror_references, int fetch_all_branches, int fetchfd,
+ int mirror_references, int fetch_all_branches,
+ struct got_pathlist_head *wanted_branches, int fetchfd,
struct got_repository *repo,
got_fetch_progress_cb progress_cb, void *progress_arg)
{
@@ -554,7 +555,7 @@ got_fetch_pack(struct got_object_id **pack_hash, struct got_pathlist_head *refs,
goto done;
}
err = got_privsep_send_fetch_req(&fetchibuf, nfetchfd, &have_refs,
- fetch_all_branches);
+ fetch_all_branches, wanted_branches);
if (err != NULL)
goto done;
nfetchfd = -1;
diff --git a/lib/got_lib_privsep.h b/lib/got_lib_privsep.h
index 3df98dc..ca92bcd 100644
--- a/lib/got_lib_privsep.h
+++ b/lib/got_lib_privsep.h
@@ -110,6 +110,8 @@ enum got_imsg_type {
/* Messages related to networking. */
GOT_IMSG_FETCH_REQUEST,
+ GOT_IMSG_FETCH_HAVE_REF,
+ GOT_IMSG_FETCH_WANTED_BRANCH,
GOT_IMSG_FETCH_OUTFD,
GOT_IMSG_FETCH_SYMREFS,
GOT_IMSG_FETCH_REF,
@@ -239,17 +241,26 @@ struct got_imsg_tag_object {
*/
} __attribute__((__packed__));
-/* Structures for GOT_IMSG_FETCH_REQUEST data. */
+/* Structure for GOT_IMSG_FETCH_HAVE_REF data. */
struct got_imsg_fetch_have_ref {
uint8_t id[SHA1_DIGEST_LENGTH];
size_t name_len;
/* Followed by name_len data bytes. */
} __attribute__((__packed__));
+/* Structure for GOT_IMSG_FETCH_WANTED_BRANCH data. */
+struct got_imsg_fetch_wanted_branch {
+ size_t name_len;
+ /* Followed by name_len data bytes. */
+} __attribute__((__packed__));
+
+/* Structure for GOT_IMSG_FETCH_REQUEST data. */
struct got_imsg_fetch_request {
int fetch_all_branches;
size_t n_have_refs;
- /* Followed by n_have_refs times of got_imsg_fetch_have_ref data. */
+ size_t n_wanted_branches;
+ /* Followed by n_have_refs GOT_IMSG_FETCH_HAVE_REF messages. */
+ /* Followed by n_wanted_branches times GOT_IMSG_FETCH_WANTED_BRANCH. */
} __attribute__((__packed__));
/* Structures for GOT_IMSG_FETCH_SYMREFS data. */
@@ -345,7 +356,7 @@ struct got_imsg_remote {
int mirror_references;
/* Followed by name_len + url_len data bytes. */
-};
+} __attribute__((__packed__));
/*
* Structure for GOT_IMSG_GITCONFIG_REMOTES data.
@@ -390,7 +401,7 @@ const struct got_error *got_privsep_send_index_pack_done(struct imsgbuf *);
const struct got_error *got_privsep_recv_index_progress(int *, int *, int *,
int *, int *, struct imsgbuf *ibuf);
const struct got_error *got_privsep_send_fetch_req(struct imsgbuf *, int,
- struct got_pathlist_head *, int);
+ struct got_pathlist_head *, int, struct got_pathlist_head *);
const struct got_error *got_privsep_send_fetch_outfd(struct imsgbuf *, int);
const struct got_error *got_privsep_send_fetch_symrefs(struct imsgbuf *,
struct got_pathlist_head *);
diff --git a/lib/privsep.c b/lib/privsep.c
index c03ab3d..805dd3e 100644
--- a/lib/privsep.c
+++ b/lib/privsep.c
@@ -412,73 +412,107 @@ got_privsep_send_obj(struct imsgbuf *ibuf, struct got_object *obj)
const struct got_error *
got_privsep_send_fetch_req(struct imsgbuf *ibuf, int fd,
- struct got_pathlist_head *have_refs, int fetch_all_branches)
+ struct got_pathlist_head *have_refs, int fetch_all_branches,
+ struct got_pathlist_head *wanted_branches)
{
const struct got_error *err = NULL;
struct ibuf *wbuf;
- size_t len, n_have_refs = 0;
+ size_t len;
struct got_pathlist_entry *pe;
-
+ struct got_imsg_fetch_request fetchreq;
+
+ memset(&fetchreq, 0, sizeof(fetchreq));
+ fetchreq.fetch_all_branches = fetch_all_branches;
+ TAILQ_FOREACH(pe, have_refs, entry)
+ fetchreq.n_have_refs++;
+ TAILQ_FOREACH(pe, wanted_branches, entry)
+ fetchreq.n_wanted_branches++;
len = sizeof(struct got_imsg_fetch_request);
- TAILQ_FOREACH(pe, have_refs, entry) {
- len += sizeof(struct got_imsg_fetch_have_ref) + pe->path_len;
- n_have_refs++;
- }
if (len >= MAX_IMSGSIZE - IMSG_HEADER_SIZE) {
close(fd);
return got_error(GOT_ERR_NO_SPACE);
}
- wbuf = imsg_create(ibuf, GOT_IMSG_FETCH_REQUEST, 0, 0, len);
- if (wbuf == NULL) {
- close(fd);
- return got_error_from_errno("imsg_create FETCH_REQUEST");
- }
+ if (imsg_compose(ibuf, GOT_IMSG_FETCH_REQUEST, 0, 0, fd,
+ &fetchreq, sizeof(fetchreq)) == -1)
+ return got_error_from_errno(
+ "imsg_compose FETCH_SERVER_PROGRESS");
- /* Keep in sync with struct got_imsg_fetch_request definition! */
- if (imsg_add(wbuf, &fetch_all_branches, sizeof(fetch_all_branches))
- == -1) {
- err = got_error_from_errno("imsg_add FETCH_REQUEST");
- ibuf_free(wbuf);
- close(fd);
- return err;
- }
- if (imsg_add(wbuf, &n_have_refs, sizeof(n_have_refs)) == -1) {
- err = got_error_from_errno("imsg_add FETCH_REQUEST");
- ibuf_free(wbuf);
+ err = flush_imsg(ibuf);
+ if (err) {
close(fd);
return err;
}
+ fd = -1;
TAILQ_FOREACH(pe, have_refs, entry) {
const char *name = pe->path;
size_t name_len = pe->path_len;
struct got_object_id *id = pe->data;
+ len = sizeof(struct got_imsg_fetch_have_ref) + name_len;
+ wbuf = imsg_create(ibuf, GOT_IMSG_FETCH_HAVE_REF, 0, 0, len);
+ if (wbuf == NULL)
+ return got_error_from_errno("imsg_create FETCH_HAVE_REF");
+
/* Keep in sync with struct got_imsg_fetch_have_ref! */
if (imsg_add(wbuf, id->sha1, sizeof(id->sha1)) == -1) {
- err = got_error_from_errno("imsg_add FETCH_REQUEST");
+ err = got_error_from_errno("imsg_add FETCH_HAVE_REF");
ibuf_free(wbuf);
- close(fd);
return err;
}
if (imsg_add(wbuf, &name_len, sizeof(name_len)) == -1) {
- err = got_error_from_errno("imsg_add FETCH_REQUEST");
+ err = got_error_from_errno("imsg_add FETCH_HAVE_REF");
ibuf_free(wbuf);
- close(fd);
return err;
}
if (imsg_add(wbuf, name, name_len) == -1) {
- err = got_error_from_errno("imsg_add FETCH_REQUEST");
+ err = got_error_from_errno("imsg_add FETCH_HAVE_REF");
ibuf_free(wbuf);
- close(fd);
return err;
}
+
+ wbuf->fd = -1;
+ imsg_close(ibuf, wbuf);
+ err = flush_imsg(ibuf);
+ if (err)
+ return err;
}
- wbuf->fd = fd;
- imsg_close(ibuf, wbuf);
- return flush_imsg(ibuf);
+ TAILQ_FOREACH(pe, wanted_branches, entry) {
+ const char *name = pe->path;
+ size_t name_len = pe->path_len;
+
+ len = sizeof(struct got_imsg_fetch_wanted_branch) + name_len;
+ wbuf = imsg_create(ibuf, GOT_IMSG_FETCH_WANTED_BRANCH, 0, 0,
+ len);
+ if (wbuf == NULL)
+ return got_error_from_errno(
+ "imsg_create FETCH_WANTED_BRANCH");
+
+ /* Keep in sync with struct got_imsg_fetch_wanted_branch! */
+ if (imsg_add(wbuf, &name_len, sizeof(name_len)) == -1) {
+ err = got_error_from_errno(
+ "imsg_add FETCH_WANTED_BRANCH");
+ ibuf_free(wbuf);
+ return err;
+ }
+ if (imsg_add(wbuf, name, name_len) == -1) {
+ err = got_error_from_errno(
+ "imsg_add FETCH_WANTED_BRANCH");
+ ibuf_free(wbuf);
+ return err;
+ }
+
+ wbuf->fd = -1;
+ imsg_close(ibuf, wbuf);
+ err = flush_imsg(ibuf);
+ if (err)
+ return err;
+ }
+
+ return NULL;
+
}
const struct got_error *
diff --git a/libexec/got-fetch-pack/got-fetch-pack.c b/libexec/got-fetch-pack/got-fetch-pack.c
index 35e6b77..cb84af6 100644
--- a/libexec/got-fetch-pack/got-fetch-pack.c
+++ b/libexec/got-fetch-pack/got-fetch-pack.c
@@ -483,7 +483,7 @@ fetch_error(const char *buf, size_t len)
static const struct got_error *
fetch_pack(int fd, int packfd, struct got_object_id *packid,
struct got_pathlist_head *have_refs, int fetch_all_branches,
- struct imsgbuf *ibuf)
+ struct got_pathlist_head *wanted_branches, struct imsgbuf *ibuf)
{
const struct got_error *err = NULL;
char buf[GOT_FETCH_PKTMAX];
@@ -561,10 +561,21 @@ fetch_pack(int fd, int packfd, struct got_object_id *packid,
getprogname(), refname);
if (strncmp(refname, "refs/heads/", 11) == 0) {
- if (default_branch != NULL &&
- !match_branch(refname, default_branch))
- continue;
- found_branch = 1;
+ if (fetch_all_branches) {
+ found_branch = 1;
+ } else if (!TAILQ_EMPTY(wanted_branches)) {
+ TAILQ_FOREACH(pe, wanted_branches, entry) {
+ if (match_branch(refname, pe->path))
+ break;
+ }
+ if (pe == NULL)
+ continue;
+ found_branch = 1;
+ } else if (default_branch != NULL) {
+ if (!match_branch(refname, default_branch))
+ continue;
+ found_branch = 1;
+ }
} else if (strncmp(refname, "refs/tags/", 10) != 0) {
if (chattygot) {
fprintf(stderr, "%s: ignoring '%s' which is "
@@ -837,11 +848,12 @@ main(int argc, char **argv)
struct imsgbuf ibuf;
struct imsg imsg;
struct got_pathlist_head have_refs;
+ struct got_pathlist_head wanted_branches;
struct got_pathlist_entry *pe;
- struct got_imsg_fetch_request *fetch_req = NULL;
+ struct got_imsg_fetch_request fetch_req;
struct got_imsg_fetch_have_ref href;
- size_t datalen, remain;
- size_t offset;
+ struct got_imsg_fetch_wanted_branch wbranch;
+ size_t datalen;
#if 0
static int attached;
while (!attached)
@@ -849,6 +861,7 @@ main(int argc, char **argv)
#endif
TAILQ_INIT(&have_refs);
+ TAILQ_INIT(&wanted_branches);
if (getenv("GOT_FETCH_DEBUG") != NULL) {
fprintf(stderr, "%s being chatty!\n", getprogname());
@@ -876,43 +889,46 @@ main(int argc, char **argv)
goto done;
}
datalen = imsg.hdr.len - IMSG_HEADER_SIZE;
- if (datalen < sizeof(struct got_imsg_fetch_request)) {
- err = got_error(GOT_ERR_PRIVSEP_LEN);
- goto done;
- }
- fetch_req = (struct got_imsg_fetch_request *)imsg.data;
- if (datalen < sizeof(*fetch_req) +
- sizeof(struct got_imsg_fetch_have_ref) *
- fetch_req->n_have_refs) {
+ if (datalen < sizeof(fetch_req)) {
err = got_error(GOT_ERR_PRIVSEP_LEN);
goto done;
}
- offset = sizeof(*fetch_req);
- remain = datalen;
- for (i = 0; i < fetch_req->n_have_refs; i++) {
+ memcpy(&fetch_req, imsg.data, sizeof(fetch_req));
+ fetchfd = imsg.fd;
+ imsg_free(&imsg);
+
+ for (i = 0; i < fetch_req.n_have_refs; i++) {
struct got_object_id *id;
char *refname;
- if (remain < sizeof(href) || offset > datalen) {
+ if ((err = got_privsep_recv_imsg(&imsg, &ibuf, 0)) != 0) {
+ if (err->code == GOT_ERR_PRIVSEP_PIPE)
+ err = NULL;
+ goto done;
+ }
+ if (imsg.hdr.type == GOT_IMSG_STOP)
+ goto done;
+ if (imsg.hdr.type != GOT_IMSG_FETCH_HAVE_REF) {
+ err = got_error(GOT_ERR_PRIVSEP_MSG);
+ goto done;
+ }
+ datalen = imsg.hdr.len - IMSG_HEADER_SIZE;
+ if (datalen < sizeof(href)) {
err = got_error(GOT_ERR_PRIVSEP_LEN);
goto done;
}
- memcpy(&href, imsg.data + offset, sizeof(href));
- remain -= sizeof(href);
- if (remain < href.name_len) {
+ memcpy(&href, imsg.data, sizeof(href));
+ if (datalen - sizeof(href) < href.name_len) {
err = got_error(GOT_ERR_PRIVSEP_LEN);
goto done;
}
- remain -= href.name_len;
refname = malloc(href.name_len + 1);
if (refname == NULL) {
err = got_error_from_errno("malloc");
goto done;
}
- offset += sizeof(href);
- memcpy(refname, imsg.data + offset, href.name_len);
+ memcpy(refname, imsg.data + sizeof(href), href.name_len);
refname[href.name_len] = '\0';
- offset += href.name_len;
id = malloc(sizeof(*id));
if (id == NULL) {
@@ -927,8 +943,50 @@ main(int argc, char **argv)
free(id);
goto done;
}
+
+ imsg_free(&imsg);
+ }
+
+ for (i = 0; i < fetch_req.n_wanted_branches; i++) {
+ char *refname;
+
+ if ((err = got_privsep_recv_imsg(&imsg, &ibuf, 0)) != 0) {
+ if (err->code == GOT_ERR_PRIVSEP_PIPE)
+ err = NULL;
+ goto done;
+ }
+ if (imsg.hdr.type == GOT_IMSG_STOP)
+ goto done;
+ if (imsg.hdr.type != GOT_IMSG_FETCH_WANTED_BRANCH) {
+ err = got_error(GOT_ERR_PRIVSEP_MSG);
+ goto done;
+ }
+ datalen = imsg.hdr.len - IMSG_HEADER_SIZE;
+ if (datalen < sizeof(wbranch)) {
+ err = got_error(GOT_ERR_PRIVSEP_LEN);
+ goto done;
+ }
+ memcpy(&wbranch, imsg.data, sizeof(wbranch));
+ if (datalen - sizeof(wbranch) < wbranch.name_len) {
+ err = got_error(GOT_ERR_PRIVSEP_LEN);
+ goto done;
+ }
+ refname = malloc(wbranch.name_len + 1);
+ if (refname == NULL) {
+ err = got_error_from_errno("malloc");
+ goto done;
+ }
+ memcpy(refname, imsg.data + sizeof(wbranch), wbranch.name_len);
+ refname[wbranch.name_len] = '\0';
+
+ err = got_pathlist_append(&wanted_branches, refname, NULL);
+ if (err) {
+ free(refname);
+ goto done;
+ }
+
+ imsg_free(&imsg);
}
- fetchfd = imsg.fd;
if ((err = got_privsep_recv_imsg(&imsg, &ibuf, 0)) != 0) {
if (err->code == GOT_ERR_PRIVSEP_PIPE)
@@ -948,13 +1006,16 @@ main(int argc, char **argv)
packfd = imsg.fd;
err = fetch_pack(fetchfd, packfd, &packid, &have_refs,
- fetch_req->fetch_all_branches, &ibuf);
+ fetch_req.fetch_all_branches, &wanted_branches, &ibuf);
done:
TAILQ_FOREACH(pe, &have_refs, entry) {
free((char *)pe->path);
free(pe->data);
}
got_pathlist_free(&have_refs);
+ TAILQ_FOREACH(pe, &wanted_branches, entry)
+ free((char *)pe->path);
+ got_pathlist_free(&wanted_branches);
if (packfd != -1 && close(packfd) == -1 && err == NULL)
err = got_error_from_errno("close");
if (err != NULL)