Commit 510e8b0a9e13a975b329998e2e097877f6b8d8f3
2018-10-22T22:51:58
ncurses isn't thread-safe; disable ncurses calls in secondary threads
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45
diff --git a/tog/tog.c b/tog/tog.c
index 00b4e68..8c2e741 100644
--- a/tog/tog.c
+++ b/tog/tog.c
@@ -1281,10 +1281,12 @@ log_thread(void *arg)
a->selected_entry, *a->first_displayed_entry,
a->commits, *a->selected, a->view->nlines,
a->in_repo_path, a->commits_needed);
-
+#if 0 /* XXX ncurses isn't thread-safe */
+ if (!err) {
update_panels();
doupdate();
-
+ }
+#endif
if (done)
a->commits_needed = 0;
else if (a->commits_needed == 0) {
@@ -2218,10 +2220,12 @@ blame_cb(void *arg, int nlines, int lineno, struct got_object_id *id)
err = draw_blame(a->view, a->commit_id, a->f, a->path,
a->lines, a->nlines, 0, *a->selected_line, a->first_displayed_line,
a->last_displayed_line, a->eof, a->view->nlines);
+#if 0 /* XXX ncurses isn't thread-safe */
if (!err) {
update_panels();
doupdate();
}
+#endif
done:
errcode = pthread_mutex_unlock(&tog_mutex);
if (errcode)
@@ -2252,10 +2256,12 @@ blame_thread(void *arg)
a->lines, a->nlines, 1, *a->selected_line,
a->first_displayed_line, a->last_displayed_line, a->eof,
a->view->nlines);
+#if 0 /* XXX ncurses isn't thread-safe */
if (!err) {
update_panels();
doupdate();
}
+#endif
}
errcode = pthread_mutex_unlock(&tog_mutex);