Commit 7495ec13694c2696ee3fd6c7b4ec3e8f09e98f89

Stefan Sperling 2021-04-04T14:24:39

fix open file descriptor leak in error path of read_object_header_privsep()

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
diff --git a/lib/object.c b/lib/object.c
index 7f6e445..6941187 100644
--- a/lib/object.c
+++ b/lib/object.c
@@ -485,8 +485,10 @@ read_object_header_privsep(struct got_object **obj, struct got_repository *repo,
 		return request_object(obj, repo, obj_fd);
 
 	err = start_read_object_child(repo);
-	if (err)
+	if (err) {
+		close(obj_fd);
 		return err;
+	}
 
 	return request_object(obj, repo, obj_fd);
 }