Commit 99fda3ad1a9cbd1e892c591fa2ce9e2b3b979552

Stefan Sperling 2019-01-28T23:10:32

eliminate redundant strlen() call inside in_same_subdir()

diff --git a/lib/fileindex.c b/lib/fileindex.c
index 60e6716..c32bcc1 100644
--- a/lib/fileindex.c
+++ b/lib/fileindex.c
@@ -548,9 +548,9 @@ got_fileindex_read(struct got_fileindex *fileindex, FILE *infile)
 }
 
 static int
-in_same_subdir(struct got_fileindex_entry *ie, const char *parent_path)
+in_same_subdir(struct got_fileindex_entry *ie, const char *parent_path,
+    size_t parent_len)
 {
-	size_t parent_len = strlen(parent_path);
 	char *ie_name;
 
 	if (!got_path_is_child(ie->path, parent_path, parent_len))
@@ -572,7 +572,7 @@ cmp_entries(struct got_fileindex_entry *ie, const char *parent_path,
     size_t parent_len, struct got_tree_entry *te)
 {
 	int cmp = strncmp(ie->path, parent_path, parent_len);
-	if (cmp == 0 || in_same_subdir(ie, parent_path)) {
+	if (cmp == 0 || in_same_subdir(ie, parent_path, parent_len)) {
 		char *ie_name = ie->path + parent_len;
 		while (ie_name[0] == '/')
 			ie_name++;