Commit d7b899ab022b3f7c7a42ed1338efa4ad6be626c8

Stefan Sperling 2020-03-25T15:55:22

fix got_ref_change_symref(); it changed the ref's name instead of its target

diff --git a/include/got_reference.h b/include/got_reference.h
index df306d5..5286f89 100644
--- a/include/got_reference.h
+++ b/include/got_reference.h
@@ -121,7 +121,7 @@ got_ref_change_ref(struct got_reference *, struct got_object_id *);
 
 /* Change the reference name a symbolic reference points to. */
 const struct got_error *got_ref_change_symref(struct got_reference *,
-    char *);
+    const char *);
 
 /*
  * Change a symbolic reference into a regular reference which points to
diff --git a/lib/reference.c b/lib/reference.c
index 0355087..a4aa416 100644
--- a/lib/reference.c
+++ b/lib/reference.c
@@ -1048,7 +1048,7 @@ got_ref_change_ref(struct got_reference *ref, struct got_object_id *id)
 }
 
 const struct got_error *
-got_ref_change_symref(struct got_reference *ref, char *refname)
+got_ref_change_symref(struct got_reference *ref, const char *refname)
 {
 	char *new_name;
 
@@ -1059,8 +1059,8 @@ got_ref_change_symref(struct got_reference *ref, char *refname)
 	if (new_name == NULL)
 		return got_error_from_errno("strdup");
 
-	free(ref->ref.symref.name);
-	ref->ref.symref.name = new_name;
+	free(ref->ref.symref.ref);
+	ref->ref.symref.ref = new_name;
 	return NULL;
 }