Commit dda76f1836d14f05a7f1ff0ea0fa2b1d191fce2c

Stefan Sperling 2020-02-13T10:52:18

add another XXX comment; I'm not quite sure what to do about this just yet

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
diff --git a/gotweb/gotweb.c b/gotweb/gotweb.c
index aada9b6..726420c 100644
--- a/gotweb/gotweb.c
+++ b/gotweb/gotweb.c
@@ -3742,6 +3742,11 @@ gw_output_repo_tree(struct gw_trans *gw_trans)
 			goto done;
 	}
 
+	/*
+	 * XXX gw_trans->commit might have already been allocated in
+	 * gw_parse_querystring(); could we more cleanly seperate values
+	 * we received as arguments from values we compute ourselves?
+	 */
 	error = got_object_id_str(&gw_trans->commit, commit_id);
 	if (error)
 		goto done;