Log

Author Commit Date CI Message
Stefan Sperling c6621528 2022-06-18T17:06:40 bump version number
Stefan Sperling c57e65c9 2022-06-18T17:02:58 CHANGES for 0.72
Stefan Sperling f704b35c 2022-06-18T16:52:41 small grammar and accuracy fixes in a comment
Stefan Sperling 4bfe9f0a 2022-06-18T16:48:54 add missing braces around multi-line if-statement body; pointed out by op@
Stefan Sperling 364ac6fd 2022-06-18T16:47:03 take tog selection cursor position into account when searching for next match Patch by Mikhail ok op@ jamsek
Stefan Sperling 89a34d6e 2022-06-18T16:32:12 wrap an overlong line in enumeration_request()
Stefan Sperling 80f51a9e 2022-06-18T16:32:12 fix unexpected imsg error after incomplete enumeration in got-read-pack reported by jrick and op@ ok op@
Omar Polo dfee752e 2022-06-18T16:18:11 tog: reset matched and search data after C-l otherwise they point to free'd data. ok stsp@
Omar Polo 031611fc 2022-06-18T16:17:45 memset all stack-allocated structs used to send messages; ok stsp@
Omar Polo 1a69d37f 2022-06-18T16:17:45 zero the whole struct got_imsg_object before sending it otherwise some fields may be unitialized and fail the validation done on the receiving side. ok stsp@
Stefan Sperling b4998ee2 2022-06-17T13:00:45 bump version number
Stefan Sperling 6de537c0 2022-06-17T11:01:51 CHANGES for 0.71
Stefan Sperling a00719e9 2022-06-17T11:01:26 fix a segfault in tog diff The f1 tempfile must always be created. Even if the initial diff has no objects on the left side, the view can be switched to a different diff which does have objects on both sides. When that happened, tog crashed. (To reproduce: open tog in got.git, hit G, hit Enter, hit <)
Stefan Sperling dd6e31d7 2022-06-17T10:29:12 fix build of tog on sparc64 with -Werror error was tog/tog.c:636: warning: function declaration isn't a prototype
Omar Polo 4d1f6af3 2022-06-17T08:51:16 account for the vborder in draw_commit the vborder is drawn on top of the window and that can cause issues with double-width characters. Instead, account for it when computing the space available for the log message. ok stsp@
Omar Polo 0dbbbe90 2022-06-17T08:49:32 tog: resize main view drawing the child view on top of the main view when the layout is split-screen can produce some ugly glitches when double-width characters are involved. (issue found by stsp) ok stsp@
Omar Polo 4e4a9ac8 2022-06-17T08:49:32 simplify scroll_wline (now span_wline) and format_line generalize scroll_wline to start at a specified offset so that we can reuse it to simplify format_line. While here, simplify scroll_wline (now called span_wline) too. ok and improvements by stsp@
Stefan Sperling 95d136ac 2022-06-16T21:26:24 fix wrong pointer in NULL check; found by tracey
Stefan Sperling 44a87665 2022-06-16T21:22:49 fix highlighting issues in tog diff/blame search on lines with tabs
Stefan Sperling cb713507 2022-06-16T20:55:21 tog: fix crash in expand_tab while searching in diff/blame views found by op@ ok op@ tracey@
Stefan Sperling 1853e0f4 2022-06-16T20:48:35 fix diff and blame view search for horizontal scrolling with unicode ok op@
Stefan Sperling 87411fa9 2022-06-16T18:24:53 wrap overlong lines in tog.c
Stefan Sperling 4cb9d869 2022-06-16T17:17:40 fix horizontal scrolling of unicode in the blame view ok op@
Stefan Sperling 969c159c 2022-06-16T17:17:19 fix horizontal scrolling of unicode in tog diff view ok op@
Mark Jamsek f7443f66 2022-06-16T15:13:39 add missing linebreaks to demarcate sentences in tog.1 ok op@
Mark Jamsek 367ddf28 2022-06-16T14:49:57 missed style(9) fixes in previous commit ok tb@
Tracey Emery 20282b02 2022-06-16T14:45:29 fix build with -DGOT_NO_OBJ_CACHE ok stsp
Mark Jamsek 6e1c41ad 2022-06-16T14:41:49 plug realloc memleak and style(9) fixes in expand_tab() fixes and ok from tb@
Stefan Sperling ccda2f4d 2022-06-16T13:37:55 move horizontal line scrolling logic into format_line() for easier reuse ok op@
Stefan Sperling 0ce35b66 2022-06-16T13:36:46 fix an off-by-one in tog's draw_file() causing wrong diff output This issue caused empty lines added in diffs to be displayed without leading + in the diff view. Problem found by op@ ok op jamsek
Stefan Sperling b0dd8d27 2022-06-16T11:40:20 fix a recent regression where tog segfaults if Ctrl+l is used in the log view
Stefan Sperling 29688b02 2022-06-16T11:33:48 fix horizontal scrolling of unicode in tog log view ok jamsek
Stefan Sperling a75b3e2d 2022-06-16T08:10:33 fix horizontal scrolling bug in the blame view ok op@, jamsek
Stefan Sperling b4996bee 2022-06-16T07:04:07 show last-modified date in the "tog ref" view if the 'm' key is pressed Patch by Mark Jamsek
Stefan Sperling 145b6838 2022-06-16T07:00:28 implement horizontal scrolling for tog diff, blame, and log views Patch by Mark Jamsek
Omar Polo 1b1b91ab 2022-06-15T21:21:27 style: remove double semicolon
Stefan Sperling 61bce19e 2022-06-15T19:19:28 revert "clear the rest of the pack_fds pointers" There is no need to clear local variables before returning from a function. ok tracey
Stefan Sperling 75c1763d 2022-06-15T18:06:48 fix D_GOTWWW default path; gotweb can now run without a config file again ok tracey
Tracey Emery bb1c2cf3 2022-06-15T15:37:20 clear the rest of the pack_fds pointers
Tracey Emery e17984a0 2022-06-15T15:33:46 clear gw_trans->pack_fds pointer in gotweb
Tracey Emery b0c3aa90 2022-06-15T15:28:07 fix recent regression in gotweb for pack_fds
Stefan Sperling 5a950d09 2022-06-15T14:27:20 using a local packfd variable in open_worktree() is sufficient
Stefan Sperling d188eb19 2022-06-15T14:26:34 remove pointless assignment at the end of got_repo_pack_fds_close()
Stefan Sperling bb711527 2022-06-15T14:25:37 don't look for close() errors if opentemp() failed in got_repo_pack_fds_open()
Stefan Sperling 8b195234 2022-06-15T14:02:55 clear pack_fds pointer in tog's stop_blame() after closing
Stefan Sperling 74467cc8 2022-06-15T13:53:50 fix handling of pack_fds used by tog's log thread
Tracey Emery 0ae84acc 2022-06-15T13:52:20 move got_opentempfd out of got_repo_open. ok stsp@ thanks for all the help massaging this diff
Stefan Sperling 06c44edc 2022-06-15T13:10:50 check for errors from fclose() in patch_file()
Omar Polo 11ce22a1 2022-06-15T12:50:10 plug memory and fd leak in got patch
Stefan Sperling 33c3719a 2022-06-15T08:50:55 re-add u/d keybindings as aliases for Ctrl-u/d, matching more(1) and less(1) patch by Mikhail
Stefan Sperling afd31498 2022-06-14T22:35:34 fix a harmless off-by-one from previous commit
Stefan Sperling a5e587e0 2022-06-14T22:32:11 fix a bug in got_privsep_send_object_idlist() exposed by recent changes The old code did not work correctly if only a single object Id was to be sent to got-read-pack. Make got-read-pack error out if the list of commits for object enumeration is empty to catch this problem if it occurs again. Found by the send_basic test, which was failing with GOT_TEST_PACK=1 ok tracey
Stefan Sperling db9b9b1c 2022-06-14T20:26:15 let got-read-pack be explicit about whether it could enumerate all objects This allows the main process to avoid looping over all object IDs again in case the pack file used for enumeration is complete. ok op@
Stefan Sperling ffe3518f 2022-06-14T18:50:43 fix wrong arguments to calloc(3) in enumeration_request()
Omar Polo b4b1b9c0 2022-06-14T13:16:15 remove trailing whitespaces
Omar Polo 0fca100c 2022-06-14T13:16:15 compute object size, not pointer size in this case they're luckily the same; got_imsg_object_idlist and got_imsg_reused_delta only have one size_t long field. ok stsp@
Omar Polo c98b0f0b 2022-06-14T13:16:15 strictier validation for data received from libexec helpers use correct error code and ok stsp@
Omar Polo 3e6054c4 2022-06-14T13:16:14 drop unused variable
Omar Polo bf31a716 2022-06-14T13:16:14 use strndup instead of malloc+memcpy Simplifies the reading of the author/committer string and makes also the code shorter. ok stsp@
Omar Polo 71fee5a3 2022-06-14T13:16:14 don't check datalen when calling recv_imsg_error recv_imsg_error already checks the size of the message, and it does so more precisely than the removed code. ok stsp@
Omar Polo 35095610 2022-06-14T10:35:07 got patch: use ints for line offsets instead of longs ints have the advantage that their size is more likely to be the same across the various architecture supported by OpenBSD, thus introducing less possible differences. INT_MAX is still (at least) a few order of magnitudes higher than the patches we dealt with (even abnormal ones.) suggested by stsp@
Omar Polo 5b7126c5 2022-06-14T08:31:16 actually guarding against negative line offsets previous commit looked at some pretty zeroes returned from calloc instead of the actual numbers received.
Omar Polo 2399b53d 2022-06-14T08:26:27 style; set datalen only once
Omar Polo 71393b5c 2022-06-14T08:10:55 got patch: guard against invalid (negative) line offsets under normal circumstances got-read-patch can't send negative line offsets; that's not an excuse not to guard the main process from those as well. This makes sure we bail out early instead of trying to apply the diff.
Omar Polo 0e07a2a1 2022-06-13T20:57:43 free patch on error
Omar Polo 99b94ad7 2022-06-13T20:30:09 got patch: ensure new and old paths are NUL-terminated
Stefan Sperling eb7b30a1 2022-06-13T17:13:59 fix error handling in find_pack_for_enumeration(); pointed out by op@
Stefan Sperling 0ab4c957 2022-06-13T17:13:59 Bring back object enumeration inside got-read-pack as a fast path. The problem that was found in the earlier version has been fixed. ok op@
Stefan Sperling 85c34e74 2022-06-13T09:37:38 fix error case handling in print_commit_oneline(); pointed out by op@
Stefan Sperling 61dd0f65 2022-06-13T09:37:38 remove outdated and overly-specific documentation of got log -s output ok op@
Stefan Sperling 783ffc01 2022-06-13T09:37:38 adjust expected test output after got log -s changes ok op@
Stefan Sperling d91e0535 2022-06-13T09:37:38 make got log -s show committer date ok op@
Stefan Sperling 4cac2b4e 2022-06-13T09:37:38 make got log -s display local reference names ok op@
Stefan Sperling 83cc4199 2022-06-13T07:59:28 in tog, rework Ctrl+u/d to scroll by half a page, and drop d/u again This matches actual behaviour of less(1) for Ctrl+u/d, and leaves d/u free for potential future use. Suggested by naddy. Patch by Mark Jamsek
Omar Polo 793b9394 2022-06-12T15:45:11 got log: sync match_commit from tog So that 'got log -S' can match also the author and committer name, and the commit ID too. ok stsp@
Stefan Sperling 80b7e8da 2022-06-11T19:24:51 add less(1)-style key bindings for up/down to tog; patch by Mikhail
Stefan Sperling 3ef807ee 2022-06-08T11:01:11 reword description of how got log -p and -P interact with got log -S
Stefan Sperling a558dd1b 2022-06-08T10:56:53 reuse a temporary file across commits during got log -p -S suggested by + ok op@
Stefan Sperling ee0fb1ff 2022-06-08T10:33:53 make it possible to match committed patches with got log -p -S pattern ok op@
Stefan Sperling caea18c1 2022-06-08T09:51:05 add a missing .Pp to got.1
Stefan Sperling 90e25b1f 2022-06-08T09:43:35 plug a memory leak in show_change(), line was leaked
Stefan Sperling c1c775eb 2022-06-08T09:16:08 add one-line output mode to got log with -s flag -s for short. Moves log search to -S. Patch by Evan Silberman
Stefan Sperling e44d9391 2022-06-07T19:20:01 revert object enumeration in got-read-pack for now; needs more work This implementation marked commits and trees as enumerated before all trees which they depend on were enumerated. This behaviour leads to incomplete pack files when a tree is only partially packed and got-read-pack hits a missing tree entry as a result. The algorithm must be reworked such that packed leave nodes are marked enumerated first, then bubble-up. Found by op@
Stefan Sperling 0e90588f 2022-06-07T17:50:48 in enumeration_request(), use the correct index for tagged commit objects Fixes an error where got-read-pack errors out with "bad object data" during 'got send' because we ended up handing a tag object to the commit object parser.
Stefan Sperling 9f4f302a 2022-06-07T16:04:15 free id and path in load_packed_tree_ids() on error, else they would leak pointed out by op@
Stefan Sperling f0972833 2022-06-07T16:00:56 fix wrong line wrap; pointed out by op@
Stefan Sperling 876f8c1a 2022-06-07T15:59:48 imsg_add() already frees wbuf on error; pointed out by op@
Stefan Sperling cee6a7ea 2022-06-07T15:56:46 implement object enumeration support in got-read-pack ok op@
Omar Polo 9fdde394 2022-06-04T14:13:46 got stage: implicitly unstage when staging the reverse of the staged diff otherwise we end up with a staged empty edit for that file. ok stsp@
Stefan Sperling 4264b841 2022-06-04T14:02:21 check the maximum cached delta size against the correct constant
Stefan Sperling dac5c75e 2022-06-04T13:58:48 convert delta cache to a hash table This approach uses more memory but is much faster. To offset the additional memory usage somewhat the cache now stores very small deltas only. However, overall memory usage goes up. Hopefully we will find a way to reduce this later. ok op@
Omar Polo 84246752 2022-06-03T20:26:49 set `ret' in a few places where it was forgotten; ok tracey@
Omar Polo a19f439c 2022-06-03T20:26:48 don't pass $ret to test_done on failure when it's known to be zero Otherwise the test directory it's not left in place; ok tracey@
Stefan Sperling 6a881297 2022-06-02T12:32:00 properly swap cached struct pack array elements in got_repo_cache_pack() Avoids clobbering open files for delta base/accumulation, leaking file descriptors, and triggering errors from close(2) during got_repo_close() as we try to close the same file descriptor more than once.
Stefan Sperling b72706c3 2022-06-01T05:08:20 move creation of tempfiles outside of lib/diff.c ok tracey
Stefan Sperling 2497f032 2022-05-31T19:25:28 tog: override SIGTERM and SIGINT handlers to avoid ncurses cleanup() handler ok thomas
Stefan Sperling cfcf1cbc 2022-05-31T18:49:16 reduce GOT_PACK_CACHE_SIZE to 32, otherwise it uses too many open files found by tracey
Stefan Sperling 13242195 2022-05-31T18:34:45 ensure that all open basefd/accumfd get closed in got_repo_close() found by tracey
Stefan Sperling 57160834 2022-05-31T11:00:09 open temporary files needed for delta application in got_repo_open() This prepares for callers of got_repo_open() that cannot afford to open files in /tmp, such as gotwebd. In a follow-up change, we could ask such callers to pass in the required amount of open temporary files. One consequence is that got_repo_open() now requires the "cpath" pledge promise. Add the "cpath" promise to affected callers and remove it once the repository has been opened. ok tracey
Stefan Sperling f18c433a 2022-05-31T08:44:55 avoid get_delta_chain_max_size() in dump_delta_chain_to_mem()