|
2c986b8f
|
2022-07-04T09:15:23
|
|
check for specific chars instead of using isspace(3)
Reminded by naddy and stsp; it was missing a cast to unsigned char to
prevent issues on archs with signed chars and was too broad anyway.
While here, drop an extra check immediately after.
ok stsp@
|
|
c632297d
|
2022-07-03T21:49:23
|
|
Use pipe() which is a more understood syscall than pipe2() which doesn't
exist on MacOS, for instance. Since we we're passing in 0 to pipe2(),
this mean no fcntl() flags were being sent. As such, it's the same
syscall as pipe() which also has the added benefit that it's more
portable.
committing on behalf of thomas with my ok
|
|
|
91d845ad
|
2022-07-03T21:44:01
|
|
fix tag signing when the key file does not exist
This should fail without creating any tag. Before, ssh-keygen(1)
would print an error to stderr, but got would create an unsigned tag.
ok op@
|
|
|
4d5ee956
|
2022-07-02T21:27:21
|
|
create and verify tags signed by SSH keys
This adds a new -s flag to 'got tag' that specifies the signer
identity (for example, a key file) of the tagger. The tag object will
include a signature that validates each of the tag object headers and
the tag message.
Verifying these signed tags requires maintaining an allowed signers
file which maps signer identities (i.e. the email address of the
tagger) to SSH public keys. See ssh-keygen(1) for more details of the
allowed signers file. After creating this file and providing the path
to it in got.conf(5) using the allowed_signers option, tags may be
verified using with 'got tag -V tag_name'. The return code will be
non-zero if a signature fails to verify.
ok stsp@
|
|
|
6c77e033
|
2022-07-02T21:21:52
|
|
fix imsg_add TREE_ENTRY: Result too large on i386
There's a math error when computing the size of one entries in the
batching code. Reported by semarie, ok semarie stsp
|
|
|
a92a2042
|
2022-07-02T21:16:13
|
|
got patch: handle mangled whitespaces
This makes 'got patch' try to ignore whitespaces when trying to match a
hunk.
Discused with and ok stsp@
|
|
|
5dffb1a1
|
2022-07-02T21:08:31
|
|
got patch: don't loose the x bit when merging with diff3
This fixes a regression introduced with the diff3 merge: files merged
this way have their permissions resetted after patch.
The issue is due the fact that patch_file looks at a temporary files
and not at the original "old file".
Reported by and ok stsp@
|
|
4b752015
|
2022-06-30T21:35:28
|
|
switch 'tog diff' and 'tog blame' to Myers diff for speed
Make the choice of diff algorithm configurable by diff API users.
The got and gotweb programs keep using Patience diffs which are
prettier than Myers. But tog should be as fast as possible since
it is being used interactively. If performance of Patience diff
gets improved later we can consider switching tog back over to it.
ok tracey jamsek
|
|
|
49d4a017
|
2022-06-30T10:43:37
|
|
move more opentemp out of diffreg.c
ok tracey
|
|
e6e73e55
|
2022-06-30T08:41:14
|
|
move remaining got_opentemp's out of blame. ok op@
|
|
|
f9d37699
|
2022-06-28T20:33:41
|
|
move got_opentempfd() out of lib/diff.c again
ok tracey
|
|
|
1b484788
|
2022-06-28T18:34:57
|
|
move got_opentempfd out of blame_open ok stsp@ jrick@
|
|
|
7a13e6e5
|
2022-06-28T18:19:03
|
|
pass the correct file to fdopen(); ok tracey
|
|
|
ce7556f2
|
2022-06-28T18:04:05
|
|
fix missed dup in open_blob per stsp@
|
|
|
eb81bc23
|
2022-06-28T13:27:12
|
|
move got_opentempfd out of open_blob. ok stsp@
|
|
|
61af9b21
|
2022-06-28T11:31:11
|
|
implement support for commit coloring in got-read-pack for speed
ok op, tracey
|
|
|
db0dfdd7
|
2022-06-27T18:47:02
|
|
got patch: handle git-style diffs for the 3-way merge too
tweak and ok stsp@
|
|
|
497a5915
|
2022-06-27T18:47:02
|
|
handle blob ids without corresponding blob ids
ok stsp@
|
|
|
58e31a80
|
2022-06-27T18:47:02
|
|
build with -Wwrite-strings
Throwing this into the mix for a while, we can always get rid of it
again if it becomes annoying. No objections from stsp@
|
|
|
3d589bee
|
2022-06-25T14:54:41
|
|
allow start_pack_privsep_child() to be called from outside lib/object.c
|
|
|
8469d821
|
2022-06-25T09:25:07
|
|
always show commit or tree IDs in diff header, in order to help 'got patch'
The idea is that got patch can simply look for a line such as:
commit - abcde1234567...
to find the merge base commit ID to show in diff3 conflict markers.
got log -p now displays commit IDs in its diff header, instead ofl
tree or blob IDs.
ok op@
|
|
|
336075a4
|
2022-06-25T09:22:02
|
|
build with -Wmissing-prototypes
ok stsp@
|
|
|
9802c41c
|
2022-06-21T16:52:34
|
|
got patch: use status G for merged files (and document it)
Suggested by stsp@. This makes possible to tell if 'got patch' used a
merge-base from the repository for the 3-way merge or did a simple
search/replace operation.
While here update the tests to look for the 'G' status and the manpage,
which was also missing the documentation for the 'C' status in got
patch.
ok stsp@
|
|
|
dbc68eed
|
2022-06-21T16:52:34
|
|
got patch: ignore blobs not found
since diffs are often enclosed in other formats (e.g. emails) we might
parse something and think it's a blob id when it's not. This should
already happens, but apply_patch is looking for the wrong error due to a
leftover from previous attempts. Reported by stsp@
while here tweak the test_patch_merge_unknown_blob to also try with a
dummy commit id, as now got-read-patch requires it in order to consider
a blob id.
ok stsp@
|
|
|
d8b5af43
|
2022-06-19T11:51:33
|
|
use the commitid in the patch diff3 conflict header
suggested by and ok stsp@
|
|
|
827bcd6c
|
2022-06-19T11:51:32
|
|
patch_file: move file ownership to parent
ok stsp@
|
|
|
55e9459f
|
2022-06-19T11:51:32
|
|
got patch: use diff3 to merge the changes
Parse the "blob -" metadata in diffs produced by 'got diff' and use the
original file for patching. Then, use the diff3 with the current
version of the file to merge the differences.
This solves many failures automagically or at least turns them into a
conflict.
ok/improvements stsp@
|
|
|
05737d49
|
2022-06-19T11:51:32
|
|
patch_file: fill tmp with the patched file even in nop mode
future work with diff3 merge will need the fully patched file even in
the nop mode
ok stsp@
|
|
|
80f51a9e
|
2022-06-18T16:32:12
|
|
fix unexpected imsg error after incomplete enumeration in got-read-pack
reported by jrick and op@
ok op@
|
|
|
031611fc
|
2022-06-18T16:17:45
|
|
memset all stack-allocated structs used to send messages; ok stsp@
|
|
|
1a69d37f
|
2022-06-18T16:17:45
|
|
zero the whole struct got_imsg_object before sending it
otherwise some fields may be unitialized and fail the validation done on
the receiving side.
ok stsp@
|
|
|
20282b02
|
2022-06-16T14:45:29
|
|
fix build with -DGOT_NO_OBJ_CACHE
ok stsp
|
|
|
1b1b91ab
|
2022-06-15T21:21:27
|
|
style: remove double semicolon
|
|
|
5a950d09
|
2022-06-15T14:27:20
|
|
using a local packfd variable in open_worktree() is sufficient
|
|
|
d188eb19
|
2022-06-15T14:26:34
|
|
remove pointless assignment at the end of got_repo_pack_fds_close()
|
|
|
bb711527
|
2022-06-15T14:25:37
|
|
don't look for close() errors if opentemp() failed in got_repo_pack_fds_open()
|
|
|
0ae84acc
|
2022-06-15T13:52:20
|
|
move got_opentempfd out of got_repo_open. ok stsp@
thanks for all the help massaging this diff
|
|
|
06c44edc
|
2022-06-15T13:10:50
|
|
check for errors from fclose() in patch_file()
|
|
|
11ce22a1
|
2022-06-15T12:50:10
|
|
plug memory and fd leak in got patch
|
|
|
afd31498
|
2022-06-14T22:35:34
|
|
fix a harmless off-by-one from previous commit
|
|
|
a5e587e0
|
2022-06-14T22:32:11
|
|
fix a bug in got_privsep_send_object_idlist() exposed by recent changes
The old code did not work correctly if only a single object Id was to
be sent to got-read-pack. Make got-read-pack error out if the list
of commits for object enumeration is empty to catch this problem if
it occurs again.
Found by the send_basic test, which was failing with GOT_TEST_PACK=1
ok tracey
|
|
|
db9b9b1c
|
2022-06-14T20:26:15
|
|
let got-read-pack be explicit about whether it could enumerate all objects
This allows the main process to avoid looping over all object IDs again
in case the pack file used for enumeration is complete.
ok op@
|
|
|
b4b1b9c0
|
2022-06-14T13:16:15
|
|
remove trailing whitespaces
|
|
|
0fca100c
|
2022-06-14T13:16:15
|
|
compute object size, not pointer size
in this case they're luckily the same; got_imsg_object_idlist and
got_imsg_reused_delta only have one size_t long field.
ok stsp@
|
|
|
c98b0f0b
|
2022-06-14T13:16:15
|
|
strictier validation for data received from libexec helpers
use correct error code and ok stsp@
|
|
|
3e6054c4
|
2022-06-14T13:16:14
|
|
drop unused variable
|
|
|
bf31a716
|
2022-06-14T13:16:14
|
|
use strndup instead of malloc+memcpy
Simplifies the reading of the author/committer string and makes also the
code shorter.
ok stsp@
|
|
|
71fee5a3
|
2022-06-14T13:16:14
|
|
don't check datalen when calling recv_imsg_error
recv_imsg_error already checks the size of the message, and it does so
more precisely than the removed code.
ok stsp@
|
|
|
35095610
|
2022-06-14T10:35:07
|
|
got patch: use ints for line offsets instead of longs
ints have the advantage that their size is more likely to be the same
across the various architecture supported by OpenBSD, thus introducing
less possible differences.
INT_MAX is still (at least) a few order of magnitudes higher than the
patches we dealt with (even abnormal ones.)
suggested by stsp@
|
|
|
5b7126c5
|
2022-06-14T08:31:16
|
|
actually guarding against negative line offsets
previous commit looked at some pretty zeroes returned from calloc
instead of the actual numbers received.
|
|
|
2399b53d
|
2022-06-14T08:26:27
|
|
style; set datalen only once
|
|
|
71393b5c
|
2022-06-14T08:10:55
|
|
got patch: guard against invalid (negative) line offsets
under normal circumstances got-read-patch can't send negative line
offsets; that's not an excuse not to guard the main process from those
as well.
This makes sure we bail out early instead of trying to apply the diff.
|
|
|
0e07a2a1
|
2022-06-13T20:57:43
|
|
free patch on error
|
|
|
99b94ad7
|
2022-06-13T20:30:09
|
|
got patch: ensure new and old paths are NUL-terminated
|
|
|
eb7b30a1
|
2022-06-13T17:13:59
|
|
fix error handling in find_pack_for_enumeration(); pointed out by op@
|
|
|
0ab4c957
|
2022-06-13T17:13:59
|
|
Bring back object enumeration inside got-read-pack as a fast path.
The problem that was found in the earlier version has been fixed.
ok op@
|
|
|
a558dd1b
|
2022-06-08T10:56:53
|
|
reuse a temporary file across commits during got log -p -S
suggested by + ok op@
|
|
|
e44d9391
|
2022-06-07T19:20:01
|
|
revert object enumeration in got-read-pack for now; needs more work
This implementation marked commits and trees as enumerated before all trees
which they depend on were enumerated. This behaviour leads to incomplete
pack files when a tree is only partially packed and got-read-pack hits
a missing tree entry as a result. The algorithm must be reworked such
that packed leave nodes are marked enumerated first, then bubble-up.
Found by op@
|
|
|
9f4f302a
|
2022-06-07T16:04:15
|
|
free id and path in load_packed_tree_ids() on error, else they would leak
pointed out by op@
|
|
|
f0972833
|
2022-06-07T16:00:56
|
|
fix wrong line wrap; pointed out by op@
|
|
|
876f8c1a
|
2022-06-07T15:59:48
|
|
imsg_add() already frees wbuf on error; pointed out by op@
|
|
|
cee6a7ea
|
2022-06-07T15:56:46
|
|
implement object enumeration support in got-read-pack
ok op@
|
|
|
9fdde394
|
2022-06-04T14:13:46
|
|
got stage: implicitly unstage when staging the reverse of the staged diff
otherwise we end up with a staged empty edit for that file.
ok stsp@
|
|
|
4264b841
|
2022-06-04T14:02:21
|
|
check the maximum cached delta size against the correct constant
|
|
|
dac5c75e
|
2022-06-04T13:58:48
|
|
convert delta cache to a hash table
This approach uses more memory but is much faster. To offset the
additional memory usage somewhat the cache now stores very small
deltas only. However, overall memory usage goes up. Hopefully we
will find a way to reduce this later.
ok op@
|
|
|
6a881297
|
2022-06-02T12:32:00
|
|
properly swap cached struct pack array elements in got_repo_cache_pack()
Avoids clobbering open files for delta base/accumulation, leaking file
descriptors, and triggering errors from close(2) during got_repo_close()
as we try to close the same file descriptor more than once.
|
|
|
b72706c3
|
2022-06-01T05:08:20
|
|
move creation of tempfiles outside of lib/diff.c
ok tracey
|
|
|
cfcf1cbc
|
2022-05-31T18:49:16
|
|
reduce GOT_PACK_CACHE_SIZE to 32, otherwise it uses too many open files
found by tracey
|
|
|
13242195
|
2022-05-31T18:34:45
|
|
ensure that all open basefd/accumfd get closed in got_repo_close()
found by tracey
|
|
|
57160834
|
2022-05-31T11:00:09
|
|
open temporary files needed for delta application in got_repo_open()
This prepares for callers of got_repo_open() that cannot afford to
open files in /tmp, such as gotwebd. In a follow-up change, we could
ask such callers to pass in the required amount of open temporary files.
One consequence is that got_repo_open() now requires the "cpath" pledge
promise. Add the "cpath" promise to affected callers and remove it once
the repository has been opened.
ok tracey
|
|
|
f18c433a
|
2022-05-31T08:44:55
|
|
avoid get_delta_chain_max_size() in dump_delta_chain_to_mem()
|
|
|
6395114c
|
2022-05-31T08:44:55
|
|
avoid get_delta_chain_max_size() in dump_delta_chain_to_file()
|
|
|
ce2bf7b7
|
2022-05-29T17:51:33
|
|
fix a bug in findwixt() which caused pack files with missing parent commits
The 'nskip' variable is supposed to reflect commits which are waiting on
the queue and have the 'skip' color. Only increment 'nskip' when adding
such commits to the queue.
Problem observed with got send -T and a tag pointing to a deleted branch.
Test to reproduce the bug written by op@.
|
|
|
d6a28ffe
|
2022-05-20T21:21:42
|
|
use random seeds for murmurhash2
change the three hardcoded seeds to fresh ones generated on demand via
arc4random. Suggested/fixed by and ok stsp@
|
|
|
17cfdba6
|
2022-05-20T21:19:30
|
|
include header
|
|
|
411cbec1
|
2022-05-20T09:31:25
|
|
shrink struct got_pack_meta a bit by removing the have_reused_delta flag
This flag can be expressed as m->reused_delta_offset != 0 because all
deltas in valid pack files will be written at a non-zero offset.
We allocate a huge number of these structs during packing, so every
little bit helps.
|
|
|
adb4bbb2
|
2022-05-20T08:40:46
|
|
reduce the amount of memory used for caching deltas during deltification
With files sorted properly for deltification we produce better deltas
but end up consuming more memory and risk running into OpenBSD ulimits
during packing. To compensate, reduce the threshold for the amount of
delta data we store in memory, spooling more deltas into the cache file.
ok op@
|
|
|
f8174ca5
|
2022-05-20T08:40:46
|
|
store a path hash instead of a verbatim path in pack meta data
This reduces memory use by gotadmin pack. The goal is to sort files
which share a path next to each other for deltification. A hash of
the path is good enough for this purpose and consumes less memory
than a verbatim copy of the path. Git does something similar.
ok op@
|
|
|
3e6ceea0
|
2022-05-20T08:40:46
|
|
fix paths stored in pack meta data, improving file deltification
The old code was broken and stored an empty path or filenames, instead
of a repository-relative path. Which means we didn't sort files for
deltification as was intended.
Fixing this provides much better deltas in large pack files written by
gotadmin pack -a. In my test case, pack size changed from 2GB to 1.5GB.
ok op@
|
|
|
17259bfa
|
2022-05-19T09:26:13
|
|
plug a small memleak on error in got_pack_create()
|
|
|
e1f5d7cf
|
2022-05-19T07:36:33
|
|
avoid malloc/free for duplicate check in got_pathlists_insert()
ok op@
|
|
|
c9b75c7b
|
2022-05-19T07:31:57
|
|
revert "Skip poll(2) if an imsgbuf has a non-empty read buffer"
imsg_read() will call recvmsg() on the file descriptor regardless
of the read buffer's state, so we should ensure that data is ready.
The read buffer is used by imsg_get(), not imsg_read().
We already call imsg_get() before imsg_read(), and call the latter
only if imsg_get() returns zero.
|
|
|
2ab71455
|
2022-05-19T07:18:46
|
|
Skip poll(2) if an imsgbuf has a non-empty read buffer.
|
|
|
1453347d
|
2022-05-19T07:14:21
|
|
imsg_add() frees its msg argument on error; avoid double-free in error paths
|
|
|
33fd69c2
|
2022-05-19T06:50:59
|
|
batch up tree entries in imsg instead of sending one imsg per tree entry
This speeds up loading of trees significantly.
ok op@
|
|
|
9985f404
|
2022-05-19T06:40:09
|
|
parse tree entries into an array instead of a pathlist
Avoids some extra malloc/free in a performance-critical path.
ok op@
|
|
|
3483a4da
|
2022-05-18T07:45:08
|
|
prevent an out-of-bounds access in got_privsep_recv_tree()
|
|
|
baef4d75
|
2022-05-18T07:44:49
|
|
plug memory leak in an error path of got_privsep_recv_tree()
|
|
|
13fcf1bf
|
2022-05-18T07:44:30
|
|
make got_privsep_recv_tree() reject trees with less than zero entries
|
|
|
7429ae85
|
2022-05-18T07:43:45
|
|
rework logic in got_privsep_recv_tree() to avoid an ugly 'goto'
no functional change
|
|
|
4bcdc895
|
2022-05-17T17:35:17
|
|
refactor got_patch / got_worktree_patch_complete
let got_patch own fileindex_path and call got_worktree_patch_complete
only if got_wokrtree_patch_prepare hasn't failed.
suggested by stsp@
|
|
|
f2dd7807
|
2022-05-17T13:28:02
|
|
got patch: avoid open/sync/close the fileindex over and over again
Instead of flushing the fileindex after every patch in the patchfile
just reuse the same fileindex and sync it only at the end of the patch
operation. This speeds up 'got patch' on large repositories by quite a
lot.
|
|
e45f7eba
|
2022-05-14T18:55:37
|
|
got patch: switch from fseek() to fseeko(), use unary minus while here
ok op
|
|
|
be33dff7
|
2022-05-13T15:28:04
|
|
got patch: fail when reading empty hunks
|
|
|
e93fb944
|
2022-05-10T11:34:16
|
|
map delta cache file into memory if possible while writing a pack file
with a fix from + ok op@
|
|
|
dc3fe1bf
|
2022-05-10T11:24:12
|
|
fix load_object_ids() such that packing tags works if zero commits are packed
reported by jrick and op
|
|
|
fae7e038
|
2022-05-07T11:50:56
|
|
run the search for deltas to reuse in got-read-pack
This significantly speeds up the deltification step of packing by
avoiding imsg traffic. gotadmin no longer requests individual raw
deltas from got-read-pack to check whether it can reuse them.
Instead, got-read-pack obtains a list of objects we want to pack,
and hands back the list of all deltas in its pack file which can be
reused. Messages are now batched such that imsg buffers are filled
as much as possible.
Another advantage is that deltas we are not going to reuse will
no longer be written to the delta cache file, saving disk space.
Before this patch, any raw delta candidate was written to the
delta cache file by got-read-pack, and the decision whether to
reuse the delta happened afterwards in the gotadmin process.
Code for reading individual raw deltas is now unused and could be
removed at some point.
ok op@
|
|
|
2f8438b0
|
2022-05-04T15:39:15
|
|
avoid 'remove unused' loop by storing excluded objects in a separate set
ok op@
|
|
|
f5e78e05
|
2022-05-04T15:39:15
|
|
avoid loop over the ID set which removes objects IDs with reused deltas
ok op@
|
|
|
2d9e6abf
|
2022-05-04T13:43:24
|
|
store deltas in compressed form while packing, both in memory and cache file
This reduces memory and disk space consumption during packing.
with tweaks + memleak on error fix from op@
ok op@
|