netops: Use the size_t, Luke
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73
diff --git a/src/netops.c b/src/netops.c
index 7291ba6..b525192 100644
--- a/src/netops.c
+++ b/src/netops.c
@@ -40,7 +40,7 @@
#include "common.h"
#include "netops.h"
-void gitno_buffer_setup(gitno_buffer *buf, char *data, unsigned int len, int fd)
+void gitno_buffer_setup(gitno_buffer *buf, char *data, unsigned int len, int fd)
{
memset(buf, 0x0, sizeof(gitno_buffer));
memset(data, 0x0, len);
@@ -68,8 +68,9 @@ int gitno_recv(gitno_buffer *buf)
/* Consume up to ptr and move the rest of the buffer to the beginning */
void gitno_consume(gitno_buffer *buf, const char *ptr)
{
- int consumed;
+ size_t consumed;
+ assert(ptr - buf->data >= 0);
assert(ptr - buf->data <= (int) buf->len);
consumed = ptr - buf->data;
@@ -80,7 +81,7 @@ void gitno_consume(gitno_buffer *buf, const char *ptr)
}
/* Consume const bytes and move the rest of the buffer to the beginning */
-void gitno_consume_n(gitno_buffer *buf, unsigned int cons)
+void gitno_consume_n(gitno_buffer *buf, size_t cons)
{
memmove(buf->data, buf->data + cons, buf->len - buf->offset);
memset(buf->data + cons, 0x0, buf->len - buf->offset);
@@ -130,9 +131,10 @@ cleanup:
return error;
}
-int gitno_send(int s, const char *msg, int len, int flags)
+int gitno_send(int s, const char *msg, size_t len, int flags)
{
- int ret, off = 0;
+ int ret;
+ size_t off = 0;
while (off < len) {
ret = send(s, msg + off, len - off, flags);
diff --git a/src/netops.h b/src/netops.h
index d18116f..a146074 100644
--- a/src/netops.h
+++ b/src/netops.h
@@ -12,18 +12,18 @@ typedef unsigned int GIT_SOCKET;
typedef struct gitno_buffer {
char *data;
- unsigned int len;
- unsigned int offset;
+ size_t len;
+ size_t offset;
GIT_SOCKET fd;
} gitno_buffer;
void gitno_buffer_setup(gitno_buffer *buf, char *data, unsigned int len, int fd);
int gitno_recv(gitno_buffer *buf);
void gitno_consume(gitno_buffer *buf, const char *ptr);
-void gitno_consume_n(gitno_buffer *buf, unsigned int cons);
+void gitno_consume_n(gitno_buffer *buf, size_t cons);
int gitno_connect(const char *host, const char *port);
-int gitno_send(int s, const char *msg, int len, int flags);
+int gitno_send(int s, const char *msg, size_t len, int flags);
int gitno_select_in(gitno_buffer *buf, long int sec, long int usec);
#endif