Commit 0fae0391163c9c747e4b80976cf06dbf2917e479

Carlos Martín Nieto 2014-12-10T01:29:07

Merge pull request #2753 from ethomson/win32_leaks Win32 leaks

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
diff --git a/src/indexer.c b/src/indexer.c
index 8127ff8..92f85c1 100644
--- a/src/indexer.c
+++ b/src/indexer.c
@@ -1028,6 +1028,7 @@ int git_indexer_commit(git_indexer *idx, git_transfer_progress *stats)
 	p_rename(idx->pack->pack_name, git_buf_cstr(&filename));
 
 	git_buf_free(&filename);
+	git_hash_ctx_cleanup(&ctx);
 	return 0;
 
 on_error:
diff --git a/src/odb.c b/src/odb.c
index 5961b35..d2dff71 100644
--- a/src/odb.c
+++ b/src/odb.c
@@ -1045,6 +1045,7 @@ void git_odb_stream_free(git_odb_stream *stream)
 	if (stream == NULL)
 		return;
 
+	git_hash_ctx_cleanup(stream->hash_ctx);
 	git__free(stream->hash_ctx);
 	stream->free(stream);
 }
diff --git a/src/transports/winhttp.c b/src/transports/winhttp.c
index 032ac51..56b7c99 100644
--- a/src/transports/winhttp.c
+++ b/src/transports/winhttp.c
@@ -241,6 +241,31 @@ static int certificate_check(winhttp_stream *s, int valid)
 	return error;
 }
 
+static void winhttp_stream_close(winhttp_stream *s)
+{
+	if (s->chunk_buffer) {
+		git__free(s->chunk_buffer);
+		s->chunk_buffer = NULL;
+	}
+
+	if (s->post_body) {
+		CloseHandle(s->post_body);
+		s->post_body = NULL;
+	}
+
+	if (s->request_uri) {
+		git__free(s->request_uri);
+		s->request_uri = NULL;
+	}
+
+	if (s->request) {
+		WinHttpCloseHandle(s->request);
+		s->request = NULL;
+	}
+
+	s->sent_request = 0;
+}
+
 static int winhttp_stream_connect(winhttp_stream *s)
 {
 	winhttp_subtransport *t = OWNING_SUBTRANSPORT(s);
@@ -420,6 +445,9 @@ static int winhttp_stream_connect(winhttp_stream *s)
 	error = 0;
 
 on_error:
+	if (error < 0)
+		winhttp_stream_close(s);
+
 	git__free(proxy_url);
 	git_buf_free(&buf);
 	return error;
@@ -497,6 +525,31 @@ static int write_chunk(HINTERNET request, const char *buffer, size_t len)
 	return 0;
 }
 
+static int winhttp_close_connection(winhttp_subtransport *t)
+{
+	int ret = 0;
+
+	if (t->connection) {
+		if (!WinHttpCloseHandle(t->connection)) {
+			giterr_set(GITERR_OS, "Unable to close connection");
+			ret = -1;
+		}
+
+		t->connection = NULL;
+	}
+
+	if (t->session) {
+		if (!WinHttpCloseHandle(t->session)) {
+			giterr_set(GITERR_OS, "Unable to close session");
+			ret = -1;
+		}
+
+		t->session = NULL;
+	}
+
+	return ret;
+}
+
 static int winhttp_connect(
 	winhttp_subtransport *t,
 	const char *url)
@@ -510,6 +563,9 @@ static int winhttp_connect(
 
 	GIT_UNUSED(url);
 
+	t->session = NULL;
+	t->connection = NULL;
+
 	/* Prepare port */
 	if (git__strtol32(&port, t->connection_data.port, NULL, 10) < 0)
 		return -1;
@@ -554,6 +610,9 @@ static int winhttp_connect(
 	error = 0;
 
 on_error:
+	if (error < 0)
+		winhttp_close_connection(t);
+
 	git__free(wide_host);
 
 	return error;
@@ -790,9 +849,7 @@ replay:
 			git__free(location);
 
 			/* Replay the request */
-			WinHttpCloseHandle(s->request);
-			s->request = NULL;
-			s->sent_request = 0;
+			winhttp_stream_close(s);
 
 			if (!git__prefixcmp_icase(location8, prefix_https)) {
 				/* Upgrade to secure connection; disconnect and start over */
@@ -801,7 +858,10 @@ replay:
 					return -1;
 				}
 
-				winhttp_connect(t, location8);
+				winhttp_close_connection(t);
+
+				if (winhttp_connect(t, location8) < 0)
+					return -1;
 			}
 
 			git__free(location8);
@@ -840,9 +900,7 @@ replay:
 				if (!cred_error) {
 					assert(t->cred);
 
-					WinHttpCloseHandle(s->request);
-					s->request = NULL;
-					s->sent_request = 0;
+					winhttp_stream_close(s);
 
 					/* Successfully acquired a credential */
 					goto replay;
@@ -1109,26 +1167,7 @@ static void winhttp_stream_free(git_smart_subtransport_stream *stream)
 {
 	winhttp_stream *s = (winhttp_stream *)stream;
 
-	if (s->chunk_buffer) {
-		git__free(s->chunk_buffer);
-		s->chunk_buffer = NULL;
-	}
-
-	if (s->post_body) {
-		CloseHandle(s->post_body);
-		s->post_body = NULL;
-	}
-
-	if (s->request_uri) {
-		git__free(s->request_uri);
-		s->request_uri = NULL;
-	}
-
-	if (s->request) {
-		WinHttpCloseHandle(s->request);
-		s->request = NULL;
-	}
-
+	winhttp_stream_close(s);
 	git__free(s);
 }
 
@@ -1257,7 +1296,6 @@ static int winhttp_action(
 static int winhttp_close(git_smart_subtransport *subtransport)
 {
 	winhttp_subtransport *t = (winhttp_subtransport *)subtransport;
-	int ret = 0;
 
 	gitno_connection_data_free_ptrs(&t->connection_data);
 	memset(&t->connection_data, 0x0, sizeof(gitno_connection_data));
@@ -1272,25 +1310,7 @@ static int winhttp_close(git_smart_subtransport *subtransport)
 		t->url_cred = NULL;
 	}
 
-	if (t->connection) {
-		if (!WinHttpCloseHandle(t->connection)) {
-			giterr_set(GITERR_OS, "Unable to close connection");
-			ret = -1;
-		}
-
-		t->connection = NULL;
-	}
-
-	if (t->session) {
-		if (!WinHttpCloseHandle(t->session)) {
-			giterr_set(GITERR_OS, "Unable to close session");
-			ret = -1;
-		}
-
-		t->session = NULL;
-	}
-
-	return ret;
+	return winhttp_close_connection(t);
 }
 
 static void winhttp_free(git_smart_subtransport *subtransport)
diff --git a/tests/clar_libgit2.c b/tests/clar_libgit2.c
index 9640b92..10f37ad 100644
--- a/tests/clar_libgit2.c
+++ b/tests/clar_libgit2.c
@@ -80,7 +80,7 @@ char *cl_getenv(const char *name)
 
 int cl_setenv(const char *name, const char *value)
 {
-	wchar_t *wide_name, *wide_value;
+	wchar_t *wide_name, *wide_value = NULL;
 
 	cl_assert(git__utf8_to_16_alloc(&wide_name, name) >= 0);
 
@@ -95,6 +95,8 @@ int cl_setenv(const char *name, const char *value)
 		SetEnvironmentVariableW(wide_name, NULL);
 	}
 
+	git__free(wide_name);
+	git__free(wide_value);
 	return 0;
 }
 
diff --git a/tests/core/link.c b/tests/core/link.c
index 1794a38..83999eb 100644
--- a/tests/core/link.c
+++ b/tests/core/link.c
@@ -23,7 +23,7 @@ void test_core_link__cleanup(void)
 }
 
 #ifdef GIT_WIN32
-static bool is_administrator(void)
+static bool should_run(void)
 {
 	static SID_IDENTIFIER_AUTHORITY authority = { SECURITY_NT_AUTHORITY };
 	PSID admin_sid;
@@ -35,6 +35,11 @@ static bool is_administrator(void)
 
 	return is_admin ? true : false;
 }
+#else
+static bool should_run(void)
+{
+	return true;
+}
 #endif
 
 static void do_symlink(const char *old, const char *new, int is_dir)
@@ -48,9 +53,6 @@ static void do_symlink(const char *old, const char *new, int is_dir)
 	HMODULE module;
 	create_symlink_func pCreateSymbolicLink;
 
-	if (!is_administrator())
-		clar__skip();
-
 	cl_assert(module = GetModuleHandle("kernel32"));
 	cl_assert(pCreateSymbolicLink = (create_symlink_func)GetProcAddress(module, "CreateSymbolicLinkA"));
 
@@ -67,9 +69,6 @@ static void do_hardlink(const char *old, const char *new)
 	HMODULE module;
 	create_hardlink_func pCreateHardLink;
 
-	if (!is_administrator())
-		clar__skip();
-
 	cl_assert(module = GetModuleHandle("kernel32"));
 	cl_assert(pCreateHardLink = (create_hardlink_func)GetProcAddress(module, "CreateHardLinkA"));
 
@@ -147,6 +146,8 @@ static void do_junction(const char *old, const char *new)
 
 	CloseHandle(handle);
 	LocalFree(reparse_buf);
+
+	git_buf_free(&unparsed_buf);
 }
 
 static void do_custom_reparse(const char *path)
@@ -235,6 +236,9 @@ void test_core_link__stat_symlink(void)
 {
 	struct stat st;
 
+	if (!should_run())
+		clar__skip();
+
 	cl_git_rewritefile("stat_target", "This is the target of a symbolic link.\n");
 	do_symlink("stat_target", "stat_symlink", 0);
 
@@ -251,6 +255,9 @@ void test_core_link__stat_symlink_directory(void)
 {
 	struct stat st;
 
+	if (!should_run())
+		clar__skip();
+
 	p_mkdir("stat_dirtarget", 0777);
 	do_symlink("stat_dirtarget", "stat_dirlink", 1);
 
@@ -265,6 +272,9 @@ void test_core_link__stat_symlink_chain(void)
 {
 	struct stat st;
 
+	if (!should_run())
+		clar__skip();
+
 	cl_git_rewritefile("stat_final_target", "Final target of some symbolic links...\n");
 	do_symlink("stat_final_target", "stat_chain_3", 0);
 	do_symlink("stat_chain_3", "stat_chain_2", 0);
@@ -279,6 +289,9 @@ void test_core_link__stat_dangling_symlink(void)
 {
 	struct stat st;
 
+	if (!should_run())
+		clar__skip();
+
 	do_symlink("stat_nonexistent", "stat_dangling", 0);
 
 	cl_must_fail(p_stat("stat_nonexistent", &st));
@@ -289,6 +302,9 @@ void test_core_link__stat_dangling_symlink_directory(void)
 {
 	struct stat st;
 
+	if (!should_run())
+		clar__skip();
+
 	do_symlink("stat_nonexistent", "stat_dangling_dir", 1);
 
 	cl_must_fail(p_stat("stat_nonexistent_dir", &st));
@@ -300,6 +316,9 @@ void test_core_link__lstat_symlink(void)
 	git_buf target_path = GIT_BUF_INIT;
 	struct stat st;
 
+	if (!should_run())
+		clar__skip();
+
 	/* Windows always writes the canonical path as the link target, so
 	 * write the full path on all platforms.
 	 */
@@ -324,6 +343,9 @@ void test_core_link__lstat_symlink_directory(void)
 	git_buf target_path = GIT_BUF_INIT;
 	struct stat st;
 
+	if (!should_run())
+		clar__skip();
+
 	git_buf_join(&target_path, '/', clar_sandbox_path(), "lstat_dirtarget");
 
 	p_mkdir("lstat_dirtarget", 0777);
@@ -343,6 +365,9 @@ void test_core_link__lstat_dangling_symlink(void)
 {
 	struct stat st;
 
+	if (!should_run())
+		clar__skip();
+
 	do_symlink("lstat_nonexistent", "lstat_dangling", 0);
 
 	cl_must_fail(p_lstat("lstat_nonexistent", &st));
@@ -356,6 +381,9 @@ void test_core_link__lstat_dangling_symlink_directory(void)
 {
 	struct stat st;
 
+	if (!should_run())
+		clar__skip();
+
 	do_symlink("lstat_nonexistent", "lstat_dangling_dir", 1);
 
 	cl_must_fail(p_lstat("lstat_nonexistent", &st));
@@ -454,6 +482,9 @@ void test_core_link__stat_hardlink(void)
 {
 	struct stat st;
 
+	if (!should_run())
+		clar__skip();
+
 	cl_git_rewritefile("stat_hardlink1", "This file has many names!\n");
 	do_hardlink("stat_hardlink1", "stat_hardlink2");
 
@@ -470,6 +501,9 @@ void test_core_link__lstat_hardlink(void)
 {
 	struct stat st;
 
+	if (!should_run())
+		clar__skip();
+
 	cl_git_rewritefile("lstat_hardlink1", "This file has many names!\n");
 	do_hardlink("lstat_hardlink1", "lstat_hardlink2");
 
@@ -537,6 +571,9 @@ void test_core_link__readlink_symlink(void)
 	int len;
 	char buf[2048];
 
+	if (!should_run())
+		clar__skip();
+
 	git_buf_join(&target_path, '/', clar_sandbox_path(), "readlink_target");
 
 	cl_git_rewritefile("readlink_target", "This is the target of a symlink\n");
@@ -558,6 +595,9 @@ void test_core_link__readlink_dangling(void)
 	int len;
 	char buf[2048];
 
+	if (!should_run())
+		clar__skip();
+
 	git_buf_join(&target_path, '/', clar_sandbox_path(), "readlink_nonexistent");
 
 	do_symlink(git_buf_cstr(&target_path), "readlink_dangling", 0);
@@ -579,6 +619,9 @@ void test_core_link__readlink_multiple(void)
 	int len;
 	char buf[2048];
 
+	if (!should_run())
+		clar__skip();
+
 	git_buf_join(&target_path, '/', clar_sandbox_path(), "readlink_final");
 	git_buf_join(&path3, '/', clar_sandbox_path(), "readlink_3");
 	git_buf_join(&path2, '/', clar_sandbox_path(), "readlink_2");