Commit 1551b1f02b534390f26c57f6b06b9d8582982db8
2022-02-21T09:06:56
Merge pull request #6226 from libgit2/cmn/update-tips-error remote: do store the update_tips callback error value
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62
diff --git a/src/remote.c b/src/remote.c
index 038afc6..f6421b9 100644
--- a/src/remote.c
+++ b/src/remote.c
@@ -1852,7 +1852,7 @@ static int update_one_tip(
}
if (callbacks && callbacks->update_tips != NULL &&
- callbacks->update_tips(refname.ptr, &old, &head->oid, callbacks->payload) < 0)
+ (error = callbacks->update_tips(refname.ptr, &old, &head->oid, callbacks->payload)) < 0)
git_error_set_after_callback_function(error, "git_remote_fetch");
done:
diff --git a/tests/network/fetchlocal.c b/tests/network/fetchlocal.c
index c54f454..dc37c38 100644
--- a/tests/network/fetchlocal.c
+++ b/tests/network/fetchlocal.c
@@ -509,3 +509,44 @@ void test_network_fetchlocal__prune_load_fetch_prune_config(void)
git_remote_free(origin);
git_repository_free(repo);
}
+
+static int update_tips_error(const char *ref, const git_oid *old, const git_oid *new, void *data)
+{
+ int *callcount = (int *) data;
+
+ GIT_UNUSED(ref);
+ GIT_UNUSED(old);
+ GIT_UNUSED(new);
+
+ (*callcount)++;
+
+ return -1;
+}
+
+void test_network_fetchlocal__update_tips_error_is_propagated(void)
+{
+ git_repository *repo;
+ git_reference_iterator *iterator;
+ git_reference *ref;
+ git_remote *remote;
+ git_fetch_options options = GIT_FETCH_OPTIONS_INIT;
+ int callcount = 0;
+
+ cl_git_pass(git_repository_init(&repo, "foo.git", true));
+ cl_set_cleanup(cleanup_local_repo, "foo.git");
+
+ cl_git_pass(git_remote_create_with_fetchspec(&remote, repo, "origin", cl_git_fixture_url("testrepo.git"), "+refs/heads/*:refs/remotes/update-tips/*"));
+
+ options.callbacks.update_tips = update_tips_error;
+ options.callbacks.payload = &callcount;
+
+ cl_git_fail(git_remote_fetch(remote, NULL, &options, NULL));
+ cl_assert_equal_i(1, callcount);
+
+ cl_git_pass(git_reference_iterator_glob_new(&iterator, repo, "refs/remotes/update-tips/**/"));
+ cl_assert_equal_i(GIT_ITEROVER, git_reference_next(&ref, iterator));
+
+ git_reference_iterator_free(iterator);
+ git_remote_free(remote);
+ git_repository_free(repo);
+}