Create netops and start moving git:// to it Signed-off-by: Carlos Martín Nieto <carlos@cmartin.tk>
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173
diff --git a/src/netops.c b/src/netops.c
new file mode 100644
index 0000000..04f758f
--- /dev/null
+++ b/src/netops.c
@@ -0,0 +1,76 @@
+/*
+ * This file is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License, version 2,
+ * as published by the Free Software Foundation.
+ *
+ * In addition to the permissions in the GNU General Public License,
+ * the authors give you unlimited permission to link the compiled
+ * version of this file into combinations with other programs,
+ * and to distribute those combinations without any restriction
+ * coming from the use of this file. (The General Public License
+ * restrictions do apply in other respects; for example, they cover
+ * modification of the file, and distribution when not linked into
+ * a combined executable.)
+ *
+ * This file is distributed in the hope that it will be useful, but
+ * WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ * General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; see the file COPYING. If not, write to
+ * the Free Software Foundation, 51 Franklin Street, Fifth Floor,
+ * Boston, MA 02110-1301, USA.
+ */
+
+#include <sys/types.h>
+#include <sys/socket.h>
+#include <netdb.h>
+
+#include "git2/errors.h"
+
+#include "common.h"
+#include "netops.h"
+
+int gitno_connect(const char *host, const char *port)
+{
+ struct addrinfo *info, *p;
+ struct addrinfo hints;
+ int ret, error = GIT_SUCCESS;
+ int s;
+
+ memset(&hints, 0x0, sizeof(struct addrinfo));
+ hints.ai_family = AF_UNSPEC;
+ hints.ai_socktype = SOCK_STREAM;
+
+ ret = getaddrinfo(host, port, &hints, &info);
+ if (ret != 0) {
+ error = GIT_EOSERR;
+ goto cleanup;
+ }
+
+ for (p = info; p != NULL; p = p->ai_next) {
+ s = socket(p->ai_family, p->ai_socktype, p->ai_protocol);
+ if (s < 0) {
+ error = GIT_EOSERR;
+ goto cleanup;
+ }
+
+ ret = connect(s, p->ai_addr, p->ai_addrlen);
+ /* If we can't connect, try the next one */
+ if (ret < 0) {
+ continue;
+ }
+
+ /* Return the socket */
+ error = s;
+ goto cleanup;
+ }
+
+ /* Oops, we couldn't connect to any address */
+ error = GIT_EOSERR;
+
+cleanup:
+ freeaddrinfo(info);
+ return error;
+}
diff --git a/src/netops.h b/src/netops.h
new file mode 100644
index 0000000..10627d4
--- /dev/null
+++ b/src/netops.h
@@ -0,0 +1,9 @@
+/*
+ * netops.h - convencience functions for networking
+ */
+#ifndef INCLUDE_netops_h__
+#define INCLUDE_netops_h__
+
+int gitno_connect(const char *host, const char *port);
+
+#endif
diff --git a/src/transport_git.c b/src/transport_git.c
index e5c7b1d..12af21b 100644
--- a/src/transport_git.c
+++ b/src/transport_git.c
@@ -42,6 +42,7 @@
#include "vector.h"
#include "transport.h"
#include "common.h"
+#include "netops.h"
typedef struct {
int socket;
@@ -91,53 +92,29 @@ static int do_connect(git_priv *priv, const char *url)
char *host, *port, *msg;
const char prefix[] = "git://";
int error, ret, msg_len, connected = 0;
- struct addrinfo *info, *p;
- struct addrinfo hints;
-
- memset(&hints, 0x0, sizeof(struct addrinfo));
- hints.ai_family = AF_UNSPEC; /* IPv4 or IPv6 */
- hints.ai_socktype = SOCK_STREAM; /* TCP */
if (!git__prefixcmp(url, prefix))
url += STRLEN(prefix);
error = extract_host_and_port(&host, &port, url);
+ s = gitno_connect(host, port);
+ connected = 1;
- ret = getaddrinfo(host, port, &hints, &info);
- if (ret != 0) {
- info = NULL;
- error = git__throw(GIT_EOSERR, "Failed to get address info: %s", gai_strerror(ret));
+ error = git_pkt_gen_proto(&msg, &msg_len, url);
+ if (error < GIT_SUCCESS)
goto cleanup;
- }
- for (p = info; p != NULL; p = p->ai_next) {
- s = socket(p->ai_family, p->ai_socktype, p->ai_protocol);
- if (s < 0) {
- error = git__throw(GIT_EOSERR, "Failed to create socket");
- goto cleanup;
- }
-
- ret = connect(s, p->ai_addr, p->ai_addrlen);
- if (ret < 0) { /* Try the next one */
- continue;
- }
- connected = 1;
-
- error = git_pkt_gen_proto(&msg, &msg_len, url);
- if (error < GIT_SUCCESS)
- break;
-
- /* FIXME: Do this in a loop */
- ret = send(s, msg, msg_len, 0);
- free(msg);
- if (ret < 0)
- error = git__throw(GIT_EOSERR, "Failed to send request");
+ /* FIXME: Do this in a loop */
+ ret = send(s, msg, msg_len, 0);
+ free(msg);
+ if (ret < 0) {
+ error = git__throw(GIT_EOSERR, "Failed to send request");
+ goto cleanup;
}
priv->socket = s;
cleanup:
- freeaddrinfo(info);
free(host);
free(port);