Commit 2bed3553f4595a42d9a6884edc66b991e21f881e
2014-04-18T00:34:04
cherry-pick: terminate the commit id string We treat this as a NUL-terminated string, so make sure that we add the terminator.
diff --git a/src/cherrypick.c b/src/cherrypick.c
index 67a2c6a..6a5ca83 100644
--- a/src/cherrypick.c
+++ b/src/cherrypick.c
@@ -187,7 +187,7 @@ int git_cherry_pick(
goto on_error;
}
- git_oid_fmt(commit_oidstr, git_commit_id(commit));
+ git_oid_nfmt(commit_oidstr, sizeof(commit_oidstr), git_commit_id(commit));
if ((error = write_merge_msg(repo, commit_msg)) < 0 ||
(error = git_buf_printf(&their_label, "%.7s... %s", commit_oidstr, commit_summary)) < 0 ||