Commit 2dc7b5ef0e3eeb33bd28d6ef77e62fbef39ce7f6
2019-12-14T12:53:04
tests: pack: add missing asserts around `git_packbuilder_write`
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49
diff --git a/tests/pack/packbuilder.c b/tests/pack/packbuilder.c
index 59eb3da..32f0612 100644
--- a/tests/pack/packbuilder.c
+++ b/tests/pack/packbuilder.c
@@ -145,7 +145,7 @@ void test_pack_packbuilder__get_hash(void)
seed_packbuilder();
- git_packbuilder_write(_packbuilder, ".", 0, NULL, NULL);
+ cl_git_pass(git_packbuilder_write(_packbuilder, ".", 0, NULL, NULL));
git_oid_fmt(hex, git_packbuilder_hash(_packbuilder));
cl_assert_equal_s(hex, "7f5fa362c664d68ba7221259be1cbd187434b2f0");
@@ -158,7 +158,7 @@ static void test_write_pack_permission(mode_t given, mode_t expected)
seed_packbuilder();
- git_packbuilder_write(_packbuilder, ".", given, NULL, NULL);
+ cl_git_pass(git_packbuilder_write(_packbuilder, ".", given, NULL, NULL));
/* Windows does not return group/user bits from stat,
* files are never executable.
@@ -197,7 +197,7 @@ void test_pack_packbuilder__permissions_readwrite(void)
void test_pack_packbuilder__does_not_fsync_by_default(void)
{
seed_packbuilder();
- git_packbuilder_write(_packbuilder, ".", 0666, NULL, NULL);
+ cl_git_pass(git_packbuilder_write(_packbuilder, ".", 0666, NULL, NULL));
cl_assert_equal_sz(0, p_fsync__cnt);
}
@@ -215,7 +215,7 @@ void test_pack_packbuilder__fsync_global_setting(void)
cl_git_pass(git_libgit2_opts(GIT_OPT_ENABLE_FSYNC_GITDIR, 1));
p_fsync__cnt = 0;
seed_packbuilder();
- git_packbuilder_write(_packbuilder, ".", 0666, NULL, NULL);
+ cl_git_pass(git_packbuilder_write(_packbuilder, ".", 0666, NULL, NULL));
cl_assert_equal_sz(expected_fsyncs, p_fsync__cnt);
}
@@ -224,7 +224,7 @@ void test_pack_packbuilder__fsync_repo_setting(void)
cl_repo_set_bool(_repo, "core.fsyncObjectFiles", true);
p_fsync__cnt = 0;
seed_packbuilder();
- git_packbuilder_write(_packbuilder, ".", 0666, NULL, NULL);
+ cl_git_pass(git_packbuilder_write(_packbuilder, ".", 0666, NULL, NULL));
cl_assert_equal_sz(expected_fsyncs, p_fsync__cnt);
}