Commit 3829ba2e710553893faf6336cc6b2f3fc17a293e

Carlos Martín Nieto 2017-01-09T17:50:17

http: correct the expected error for RC4 We must make sure that we're getting a certificate error from the library so we know that we're testing the right thing.

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
diff --git a/tests/online/badssl.c b/tests/online/badssl.c
index f3470f6..6dacc18 100644
--- a/tests/online/badssl.c
+++ b/tests/online/badssl.c
@@ -70,6 +70,8 @@ void test_online_badssl__old_cipher(void)
 	if (!g_has_ssl)
 		cl_skip();
 
-	cl_git_fail(git_clone(&g_repo, "https://rc4.badssl.com/fake.git", "./fake", NULL));
-	cl_git_fail(git_clone(&g_repo, "https://rc4.badssl.com/fake.git", "./fake", &opts));
+	cl_git_fail_with(GIT_ECERTIFICATE,
+			 git_clone(&g_repo, "https://rc4.badssl.com/fake.git", "./fake", NULL));
+	cl_git_fail_with(GIT_ECERTIFICATE,
+			 git_clone(&g_repo, "https://rc4.badssl.com/fake.git", "./fake", &opts));
 }