Commit 3b3577c764ad06cd24bb9047107022abdf6fea90
2011-06-07T23:32:14
config: store new variables with the internal representation of the section The section name should be stored in its case-sensitive variant when we are adding a new variable. Use the internalize_section function to do just that. Signed-off-by: Carlos Martín Nieto <cmn@elego.de>
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53
diff --git a/src/config_file.c b/src/config_file.c
index 74162d7..5e3dabd 100644
--- a/src/config_file.c
+++ b/src/config_file.c
@@ -237,6 +237,39 @@ static int cvar_normalize_name(cvar_t *var, char **output)
return GIT_SUCCESS;
}
+static char *interiorize_section(const char *orig)
+{
+ char *dot, *last_dot, *section, *ret;
+ int len;
+
+ dot = strchr(orig, '.');
+ last_dot = strrchr(orig, '.');
+ len = last_dot - orig;
+
+ /* No subsection, this is easy */
+ if (last_dot == dot)
+ return git__strndup(orig, dot - orig);
+
+ section = git__malloc(len + 4);
+ if (section == NULL)
+ return NULL;
+
+ memset(section, 0x0, len + 4);
+ ret = section;
+ len = dot - orig;
+ memcpy(section, orig, len);
+ section += len;
+ len = STRLEN(" \"");
+ memcpy(section, " \"", len);
+ section += len;
+ len = last_dot - dot - 1;
+ memcpy(section, dot + 1, len);
+ section += len;
+ *section = '"';
+
+ return ret;
+}
+
static int config_open(git_config_file *cfg)
{
int error;
@@ -334,7 +367,7 @@ static int config_set(git_config_file *cfg, const char *name, const char *value)
memset(var, 0x0, sizeof(cvar_t));
- var->section = git__strndup(name, last_dot - name);
+ var->section = interiorize_section(name);
if (var->section == NULL) {
error = GIT_ENOMEM;
goto out;