thodg/libgit2

2021-12-29T15:26:33

Disabling setting `CMAKE_FIND_LIBRARY_SUFFIXES` on Apple platforms. On macOS, since Big Sur, the libraries were moved to a cache. The SDK comes with stubs in the SDK (`/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX12.1.sdk/usr/lib/` or whatever SDK version one has installed) where most have the `.tbd` suffix (although some still are `.a`). Forcing `CMAKE_FIND_LIBRARY_SUFFIXES` on Apple platforms broke building, unless one has copies of the libraries installed elsewhere (like Brew), as many libraries (like `iconv` or `pcre`) are not found. This fix disables setting the `CMAKE_FIND_LIBRARY_SUFFIXES` to `.a` if the platform is `APPLE` when building static libs.

diff --git a/cmake/DefaultCFlags.cmake b/cmake/DefaultCFlags.cmake
index fa59e1d..ad3db09 100644
--- a/cmake/DefaultCFlags.cmake
+++ b/cmake/DefaultCFlags.cmake
@@ -92,7 +92,7 @@ else()
 		set(CMAKE_C_ARCHIVE_FINISH "<CMAKE_RANLIB> -D <TARGET>")
 	endif()
 
-	if(NOT BUILD_SHARED_LIBS)
+	if(NOT APPLE AND NOT BUILD_SHARED_LIBS)
 		set(CMAKE_FIND_LIBRARY_SUFFIXES ".a")
 	endif()