Commit 4374f1871fb68365e612ae4c6be03e6149604435
2012-05-09T12:34:13
Merge pull request #678 from nulltoken/fix/msvc-weird-error Fix MSVC compilation issue
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316
diff --git a/tests-clar/diff/blob.c b/tests-clar/diff/blob.c
index 07f0539..6d7ad41 100644
--- a/tests-clar/diff/blob.c
+++ b/tests-clar/diff/blob.c
@@ -2,7 +2,7 @@
#include "diff_helpers.h"
static git_repository *g_repo = NULL;
-static diff_expects exp;
+static diff_expects expected;
static git_diff_options opts;
static git_blob *d, *alien;
@@ -16,7 +16,7 @@ void test_diff_blob__initialize(void)
opts.context_lines = 1;
opts.interhunk_lines = 1;
- memset(&exp, 0, sizeof(exp));
+ memset(&expected, 0, sizeof(expected));
/* tests/resources/attr/root_test4.txt */
cl_git_pass(git_oid_fromstrn(&oid, "fe773770c5a6", 12));
@@ -55,61 +55,61 @@ void test_diff_blob__can_compare_text_blobs(void)
/* Doing the equivalent of a `git diff -U1` on these files */
cl_git_pass(git_diff_blobs(
- a, b, &opts, &exp, diff_file_fn, diff_hunk_fn, diff_line_fn));
+ a, b, &opts, &expected, diff_file_fn, diff_hunk_fn, diff_line_fn));
- cl_assert(exp.files == 1);
- cl_assert(exp.file_mods == 1);
- cl_assert(exp.at_least_one_of_them_is_binary == false);
+ cl_assert(expected.files == 1);
+ cl_assert(expected.file_mods == 1);
+ cl_assert(expected.at_least_one_of_them_is_binary == false);
- cl_assert(exp.hunks == 1);
- cl_assert(exp.lines == 6);
- cl_assert(exp.line_ctxt == 1);
- cl_assert(exp.line_adds == 5);
- cl_assert(exp.line_dels == 0);
+ cl_assert(expected.hunks == 1);
+ cl_assert(expected.lines == 6);
+ cl_assert(expected.line_ctxt == 1);
+ cl_assert(expected.line_adds == 5);
+ cl_assert(expected.line_dels == 0);
- memset(&exp, 0, sizeof(exp));
+ memset(&expected, 0, sizeof(expected));
cl_git_pass(git_diff_blobs(
- b, c, &opts, &exp, diff_file_fn, diff_hunk_fn, diff_line_fn));
+ b, c, &opts, &expected, diff_file_fn, diff_hunk_fn, diff_line_fn));
- cl_assert(exp.files == 1);
- cl_assert(exp.file_mods == 1);
- cl_assert(exp.at_least_one_of_them_is_binary == false);
+ cl_assert(expected.files == 1);
+ cl_assert(expected.file_mods == 1);
+ cl_assert(expected.at_least_one_of_them_is_binary == false);
- cl_assert(exp.hunks == 1);
- cl_assert(exp.lines == 15);
- cl_assert(exp.line_ctxt == 3);
- cl_assert(exp.line_adds == 9);
- cl_assert(exp.line_dels == 3);
+ cl_assert(expected.hunks == 1);
+ cl_assert(expected.lines == 15);
+ cl_assert(expected.line_ctxt == 3);
+ cl_assert(expected.line_adds == 9);
+ cl_assert(expected.line_dels == 3);
- memset(&exp, 0, sizeof(exp));
+ memset(&expected, 0, sizeof(expected));
cl_git_pass(git_diff_blobs(
- a, c, &opts, &exp, diff_file_fn, diff_hunk_fn, diff_line_fn));
+ a, c, &opts, &expected, diff_file_fn, diff_hunk_fn, diff_line_fn));
- cl_assert(exp.files == 1);
- cl_assert(exp.file_mods == 1);
- cl_assert(exp.at_least_one_of_them_is_binary == false);
+ cl_assert(expected.files == 1);
+ cl_assert(expected.file_mods == 1);
+ cl_assert(expected.at_least_one_of_them_is_binary == false);
- cl_assert(exp.hunks == 1);
- cl_assert(exp.lines == 13);
- cl_assert(exp.line_ctxt == 0);
- cl_assert(exp.line_adds == 12);
- cl_assert(exp.line_dels == 1);
+ cl_assert(expected.hunks == 1);
+ cl_assert(expected.lines == 13);
+ cl_assert(expected.line_ctxt == 0);
+ cl_assert(expected.line_adds == 12);
+ cl_assert(expected.line_dels == 1);
opts.context_lines = 1;
- memset(&exp, 0, sizeof(exp));
+ memset(&expected, 0, sizeof(expected));
cl_git_pass(git_diff_blobs(
- c, d, &opts, &exp, diff_file_fn, diff_hunk_fn, diff_line_fn));
+ c, d, &opts, &expected, diff_file_fn, diff_hunk_fn, diff_line_fn));
- cl_assert(exp.files == 1);
- cl_assert(exp.file_mods == 1);
- cl_assert(exp.at_least_one_of_them_is_binary == false);
+ cl_assert(expected.files == 1);
+ cl_assert(expected.file_mods == 1);
+ cl_assert(expected.at_least_one_of_them_is_binary == false);
- cl_assert(exp.hunks == 2);
- cl_assert(exp.lines == 14);
- cl_assert(exp.line_ctxt == 4);
- cl_assert(exp.line_adds == 6);
- cl_assert(exp.line_dels == 4);
+ cl_assert(expected.hunks == 2);
+ cl_assert(expected.lines == 14);
+ cl_assert(expected.line_ctxt == 4);
+ cl_assert(expected.line_adds == 6);
+ cl_assert(expected.line_dels == 4);
git_blob_free(a);
git_blob_free(b);
@@ -121,97 +121,97 @@ void test_diff_blob__can_compare_against_null_blobs(void)
git_blob *e = NULL;
cl_git_pass(git_diff_blobs(
- d, e, &opts, &exp, diff_file_fn, diff_hunk_fn, diff_line_fn));
+ d, e, &opts, &expected, diff_file_fn, diff_hunk_fn, diff_line_fn));
- cl_assert(exp.files == 1);
- cl_assert(exp.file_dels == 1);
- cl_assert(exp.at_least_one_of_them_is_binary == false);
+ cl_assert(expected.files == 1);
+ cl_assert(expected.file_dels == 1);
+ cl_assert(expected.at_least_one_of_them_is_binary == false);
- cl_assert(exp.hunks == 1);
- cl_assert(exp.hunk_old_lines == 14);
- cl_assert(exp.lines == 14);
- cl_assert(exp.line_dels == 14);
+ cl_assert(expected.hunks == 1);
+ cl_assert(expected.hunk_old_lines == 14);
+ cl_assert(expected.lines == 14);
+ cl_assert(expected.line_dels == 14);
opts.flags |= GIT_DIFF_REVERSE;
- memset(&exp, 0, sizeof(exp));
+ memset(&expected, 0, sizeof(expected));
cl_git_pass(git_diff_blobs(
- d, e, &opts, &exp, diff_file_fn, diff_hunk_fn, diff_line_fn));
+ d, e, &opts, &expected, diff_file_fn, diff_hunk_fn, diff_line_fn));
- cl_assert(exp.files == 1);
- cl_assert(exp.file_adds == 1);
- cl_assert(exp.at_least_one_of_them_is_binary == false);
+ cl_assert(expected.files == 1);
+ cl_assert(expected.file_adds == 1);
+ cl_assert(expected.at_least_one_of_them_is_binary == false);
- cl_assert(exp.hunks == 1);
- cl_assert(exp.hunk_new_lines == 14);
- cl_assert(exp.lines == 14);
- cl_assert(exp.line_adds == 14);
+ cl_assert(expected.hunks == 1);
+ cl_assert(expected.hunk_new_lines == 14);
+ cl_assert(expected.lines == 14);
+ cl_assert(expected.line_adds == 14);
opts.flags ^= GIT_DIFF_REVERSE;
- memset(&exp, 0, sizeof(exp));
+ memset(&expected, 0, sizeof(expected));
cl_git_pass(git_diff_blobs(
- alien, NULL, &opts, &exp, diff_file_fn, diff_hunk_fn, diff_line_fn));
+ alien, NULL, &opts, &expected, diff_file_fn, diff_hunk_fn, diff_line_fn));
- cl_assert(exp.at_least_one_of_them_is_binary == true);
+ cl_assert(expected.at_least_one_of_them_is_binary == true);
- cl_assert(exp.files == 1);
- cl_assert(exp.file_dels == 1);
- cl_assert(exp.hunks == 0);
- cl_assert(exp.lines == 0);
+ cl_assert(expected.files == 1);
+ cl_assert(expected.file_dels == 1);
+ cl_assert(expected.hunks == 0);
+ cl_assert(expected.lines == 0);
- memset(&exp, 0, sizeof(exp));
+ memset(&expected, 0, sizeof(expected));
cl_git_pass(git_diff_blobs(
- NULL, alien, &opts, &exp, diff_file_fn, diff_hunk_fn, diff_line_fn));
+ NULL, alien, &opts, &expected, diff_file_fn, diff_hunk_fn, diff_line_fn));
- cl_assert(exp.at_least_one_of_them_is_binary == true);
+ cl_assert(expected.at_least_one_of_them_is_binary == true);
- cl_assert(exp.files == 1);
- cl_assert(exp.file_adds == 1);
- cl_assert(exp.hunks == 0);
- cl_assert(exp.lines == 0);
+ cl_assert(expected.files == 1);
+ cl_assert(expected.file_adds == 1);
+ cl_assert(expected.hunks == 0);
+ cl_assert(expected.lines == 0);
}
-static void assert_identical_blobs_comparison(diff_expects exp)
+static void assert_identical_blobs_comparison(diff_expects expected)
{
- cl_assert(exp.files == 1);
- cl_assert(exp.file_unmodified == 1);
- cl_assert(exp.hunks == 0);
- cl_assert(exp.lines == 0);
+ cl_assert(expected.files == 1);
+ cl_assert(expected.file_unmodified == 1);
+ cl_assert(expected.hunks == 0);
+ cl_assert(expected.lines == 0);
}
void test_diff_blob__can_compare_identical_blobs(void)
{
cl_git_pass(git_diff_blobs(
- d, d, &opts, &exp, diff_file_fn, diff_hunk_fn, diff_line_fn));
+ d, d, &opts, &expected, diff_file_fn, diff_hunk_fn, diff_line_fn));
- cl_assert(exp.at_least_one_of_them_is_binary == false);
- assert_identical_blobs_comparison(exp);
+ cl_assert(expected.at_least_one_of_them_is_binary == false);
+ assert_identical_blobs_comparison(expected);
- memset(&exp, 0, sizeof(exp));
+ memset(&expected, 0, sizeof(expected));
cl_git_pass(git_diff_blobs(
- NULL, NULL, &opts, &exp, diff_file_fn, diff_hunk_fn, diff_line_fn));
+ NULL, NULL, &opts, &expected, diff_file_fn, diff_hunk_fn, diff_line_fn));
- cl_assert(exp.at_least_one_of_them_is_binary == false);
- assert_identical_blobs_comparison(exp);
+ cl_assert(expected.at_least_one_of_them_is_binary == false);
+ assert_identical_blobs_comparison(expected);
- memset(&exp, 0, sizeof(exp));
+ memset(&expected, 0, sizeof(expected));
cl_git_pass(git_diff_blobs(
- alien, alien, &opts, &exp, diff_file_fn, diff_hunk_fn, diff_line_fn));
+ alien, alien, &opts, &expected, diff_file_fn, diff_hunk_fn, diff_line_fn));
- cl_assert(exp.at_least_one_of_them_is_binary == true);
- assert_identical_blobs_comparison(exp);
+ cl_assert(expected.at_least_one_of_them_is_binary == true);
+ assert_identical_blobs_comparison(expected);
}
-static void assert_binary_blobs_comparison(diff_expects exp)
+static void assert_binary_blobs_comparison(diff_expects expected)
{
- cl_assert(exp.at_least_one_of_them_is_binary == true);
+ cl_assert(expected.at_least_one_of_them_is_binary == true);
- cl_assert(exp.files == 1);
- cl_assert(exp.file_mods == 1);
- cl_assert(exp.hunks == 0);
- cl_assert(exp.lines == 0);
+ cl_assert(expected.files == 1);
+ cl_assert(expected.file_mods == 1);
+ cl_assert(expected.hunks == 0);
+ cl_assert(expected.lines == 0);
}
void test_diff_blob__can_compare_two_binary_blobs(void)
@@ -224,16 +224,16 @@ void test_diff_blob__can_compare_two_binary_blobs(void)
cl_git_pass(git_blob_lookup_prefix(&heart, g_repo, &h_oid, 4));
cl_git_pass(git_diff_blobs(
- alien, heart, &opts, &exp, diff_file_fn, diff_hunk_fn, diff_line_fn));
+ alien, heart, &opts, &expected, diff_file_fn, diff_hunk_fn, diff_line_fn));
- assert_binary_blobs_comparison(exp);
+ assert_binary_blobs_comparison(expected);
- memset(&exp, 0, sizeof(exp));
+ memset(&expected, 0, sizeof(expected));
cl_git_pass(git_diff_blobs(
- heart, alien, &opts, &exp, diff_file_fn, diff_hunk_fn, diff_line_fn));
+ heart, alien, &opts, &expected, diff_file_fn, diff_hunk_fn, diff_line_fn));
- assert_binary_blobs_comparison(exp);
+ assert_binary_blobs_comparison(expected);
git_blob_free(heart);
}
@@ -241,14 +241,14 @@ void test_diff_blob__can_compare_two_binary_blobs(void)
void test_diff_blob__can_compare_a_binary_blob_and_a_text_blob(void)
{
cl_git_pass(git_diff_blobs(
- alien, d, &opts, &exp, diff_file_fn, diff_hunk_fn, diff_line_fn));
+ alien, d, &opts, &expected, diff_file_fn, diff_hunk_fn, diff_line_fn));
- assert_binary_blobs_comparison(exp);
+ assert_binary_blobs_comparison(expected);
- memset(&exp, 0, sizeof(exp));
+ memset(&expected, 0, sizeof(expected));
cl_git_pass(git_diff_blobs(
- d, alien, &opts, &exp, diff_file_fn, diff_hunk_fn, diff_line_fn));
+ d, alien, &opts, &expected, diff_file_fn, diff_hunk_fn, diff_line_fn));
- assert_binary_blobs_comparison(exp);
+ assert_binary_blobs_comparison(expected);
}