Commit 4ab9567f6968f3cdd58ad260ba7782b6e46ca02e

Edward Thomson 2020-12-14T17:47:24

Merge pull request #4418 from libgit2/cmn/rc4 Re-enable the RC4 test

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
diff --git a/tests/online/badssl.c b/tests/online/badssl.c
index 6524fcd..6735e9c 100644
--- a/tests/online/badssl.c
+++ b/tests/online/badssl.c
@@ -67,14 +67,9 @@ void test_online_badssl__old_cipher(void)
 	git_clone_options opts = GIT_CLONE_OPTIONS_INIT;
 	opts.fetch_opts.callbacks.certificate_check = cert_check_assert_invalid;
 
-	/* FIXME: we don't actually reject RC4 anywhere, figure out what to tweak */
-	cl_skip();
-
 	if (!g_has_ssl)
 		cl_skip();
 
-	cl_git_fail_with(GIT_ECERTIFICATE,
-			 git_clone(&g_repo, "https://rc4.badssl.com/fake.git", "./fake", NULL));
-	cl_git_fail_with(GIT_ECERTIFICATE,
-			 git_clone(&g_repo, "https://rc4.badssl.com/fake.git", "./fake", &opts));
+	cl_git_fail(git_clone(&g_repo, "https://rc4.badssl.com/fake.git", "./fake", NULL));
+	cl_git_fail(git_clone(&g_repo, "https://rc4.badssl.com/fake.git", "./fake", &opts));
 }