Commit 4bb1568f22b03642cc160aecab1c1e15093ec748
2021-03-04T06:14:36
Be a little bit less aggressive GIT_WARN_UNUSED_RESULT Now we're limiting ourselves to only functions that allocate or acquire locks.
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50
diff --git a/src/sortedcache.h b/src/sortedcache.h
index 777b28b..0e1f63c 100644
--- a/src/sortedcache.h
+++ b/src/sortedcache.h
@@ -88,7 +88,7 @@ void git_sortedcache_free(git_sortedcache *sc);
void git_sortedcache_incref(git_sortedcache *sc);
/* Get the pathname associated with this cache at creation time */
-GIT_WARN_UNUSED_RESULT const char *git_sortedcache_path(git_sortedcache *sc);
+const char *git_sortedcache_path(git_sortedcache *sc);
/*
* CACHE WRITE FUNCTIONS
@@ -145,7 +145,7 @@ GIT_WARN_UNUSED_RESULT int git_sortedcache_upsert(
/* Removes entry at pos from cache
* You should already be holding the write lock when you call this.
*/
-GIT_WARN_UNUSED_RESULT int git_sortedcache_remove(git_sortedcache *sc, size_t pos);
+int git_sortedcache_remove(git_sortedcache *sc, size_t pos);
/*
* CACHE READ FUNCTIONS
@@ -163,23 +163,20 @@ GIT_WARN_UNUSED_RESULT int git_sortedcache_rlock(git_sortedcache *sc);
void git_sortedcache_runlock(git_sortedcache *sc);
/* Lookup item by key - returns NULL if not found */
-GIT_WARN_UNUSED_RESULT void *git_sortedcache_lookup(
- const git_sortedcache *sc, const char *key);
+void *git_sortedcache_lookup(const git_sortedcache *sc, const char *key);
/* Get how many items are in the cache
*
* You can call this function without holding a lock, but be aware
* that it may change before you use it.
*/
-GIT_WARN_UNUSED_RESULT size_t git_sortedcache_entrycount(
- const git_sortedcache *sc);
+size_t git_sortedcache_entrycount(const git_sortedcache *sc);
/* Lookup item by index - returns NULL if out of range */
-GIT_WARN_UNUSED_RESULT void *git_sortedcache_entry(
- git_sortedcache *sc, size_t pos);
+void *git_sortedcache_entry(git_sortedcache *sc, size_t pos);
/* Lookup index of item by key - returns GIT_ENOTFOUND if not found */
-GIT_WARN_UNUSED_RESULT int git_sortedcache_lookup_index(
+int git_sortedcache_lookup_index(
size_t *out, git_sortedcache *sc, const char *key);
#endif