Commit 589b8129e065b0bcfdbb7c4eee815b6e149218bc
2020-12-14T10:43:07
badssl: RC4 should not fail with ECERTIFICATE Using RC4 is not a _certificate_ problem, it's a cipher problem. The SSL implementation should and will fail with an unrecoverable error (-1). There's no opportunity to accept/continue.
diff --git a/tests/online/badssl.c b/tests/online/badssl.c
index ffd4ef1..6735e9c 100644
--- a/tests/online/badssl.c
+++ b/tests/online/badssl.c
@@ -70,8 +70,6 @@ void test_online_badssl__old_cipher(void)
if (!g_has_ssl)
cl_skip();
- cl_git_fail_with(GIT_ECERTIFICATE,
- git_clone(&g_repo, "https://rc4.badssl.com/fake.git", "./fake", NULL));
- cl_git_fail_with(GIT_ECERTIFICATE,
- git_clone(&g_repo, "https://rc4.badssl.com/fake.git", "./fake", &opts));
+ cl_git_fail(git_clone(&g_repo, "https://rc4.badssl.com/fake.git", "./fake", NULL));
+ cl_git_fail(git_clone(&g_repo, "https://rc4.badssl.com/fake.git", "./fake", &opts));
}