Commit 5b7487bee63e7f5cb6ea1d9090d52ae631296cd8

Ramsay Jones 2010-06-01T19:26:42

Fix a memory corruption runtime error On the msvc build, the tests t0401-parse and t0501-walk both crash with a runtime error (ACCESS_VIOLATION). This is caused by writing to un-allocated memory due to an under-allocation of a git_revpool_table data structure. Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk> Signed-off-by: Andreas Ericsson <ae@op5.se>

1
2
3
4
5
6
7
8
9
10
11
12
13
diff --git a/src/revobject.c b/src/revobject.c
index a9e9df3..94eb865 100644
--- a/src/revobject.c
+++ b/src/revobject.c
@@ -38,7 +38,7 @@ git_revpool_table *git_revpool_table_create(unsigned int min_size)
 	git_revpool_table *table;
 	int i;
 
-	table = git__malloc(sizeof(table));
+	table = git__malloc(sizeof(*table));
 
 	if (table == NULL)
 		return NULL;