Commit 5f3276c7e66fe54b0485da2def84a6ae322cce59
2017-02-07T16:33:28
Add support for lowercase proxy environment variables curl supports HTTPS_PROXY in addition to https_proxy (and their http counterparts). This change ensures parity with curl's behavior.
diff --git a/src/remote.c b/src/remote.c
index 8da7346..1f5c58b 100644
--- a/src/remote.c
+++ b/src/remote.c
@@ -774,6 +774,18 @@ int git_remote__get_http_proxy(git_remote *remote, bool use_ssl, char **proxy_ur
error = git__getenv(&val, use_ssl ? "HTTPS_PROXY" : "HTTP_PROXY");
if (error < 0) {
+ if (error != GIT_ENOTFOUND) {
+ return error;
+ }
+
+ giterr_clear();
+ error = 0;
+ }
+
+ /* try lowercase environment variables */
+ error = git__getenv(&val, use_ssl ? "https_proxy" : "http_proxy");
+
+ if (error < 0) {
if (error == GIT_ENOTFOUND) {
giterr_clear();
error = 0;