Commit 630a67366eb475003b46bf56dc06b90197458259
2018-02-07T22:30:27
refspec: add public parsing api Fix typo Fix some type issues More fixes Address requested changes Add test Fix naming Fix condition and tests Address requested changes Fix typo
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84
diff --git a/include/git2/refspec.h b/include/git2/refspec.h
index 9acdc72..eaf7747 100644
--- a/include/git2/refspec.h
+++ b/include/git2/refspec.h
@@ -22,6 +22,23 @@
GIT_BEGIN_DECL
/**
+ * Parse a given refspec string
+ *
+ * @param refspec a pointer to hold the refspec handle
+ * @param input the refspec string
+ * @param is_fetch is this a refspec for a fetch
+ * @return 0 if the refspec string could be parsed, -1 otherwise
+ */
+GIT_EXTERN(int) git_refspec_parse(git_refspec **refspec, const char *input, int is_fetch);
+
+/**
+ * Free a refspec object which has been created by git_refspec_parse
+ *
+ * @param refspec the refspec object
+ */
+GIT_EXTERN(void) git_refspec_free(git_refspec *refspec);
+
+/**
* Get the source specifier
*
* @param refspec the refspec
diff --git a/src/refspec.c b/src/refspec.c
index 8061788..b058d5f 100644
--- a/src/refspec.c
+++ b/src/refspec.c
@@ -160,6 +160,31 @@ void git_refspec__free(git_refspec *refspec)
memset(refspec, 0x0, sizeof(git_refspec));
}
+int git_refspec_parse(git_refspec **out_refspec, const char *input, int is_fetch)
+{
+ git_refspec *refspec;
+ assert(out_refspec && input);
+
+ *out_refspec = NULL;
+
+ refspec = git__malloc(sizeof(git_refspec));
+ GITERR_CHECK_ALLOC(refspec);
+
+ if (git_refspec__parse(refspec, input, !!is_fetch) != 0) {
+ git__free(refspec);
+ return -1;
+ }
+
+ *out_refspec = refspec;
+ return 0;
+}
+
+void git_refspec_free(git_refspec *refspec)
+{
+ git_refspec__free(refspec);
+ git__free(refspec);
+}
+
const char *git_refspec_src(const git_refspec *refspec)
{
return refspec == NULL ? NULL : refspec->src;
diff --git a/tests/network/refspecs.c b/tests/network/refspecs.c
index 051802b..16e585b 100644
--- a/tests/network/refspecs.c
+++ b/tests/network/refspecs.c
@@ -158,3 +158,15 @@ void test_network_refspecs__matching(void)
git_refspec__free(&spec);
}
+
+void test_network_refspecs__parse_free(void)
+{
+ git_refspec *spec = NULL;
+
+ cl_git_fail(git_refspec_parse(&spec, "", 0));
+ cl_git_fail(git_refspec_parse(&spec, ":::", 0));
+ cl_git_pass(git_refspec_parse(&spec, "HEAD:", 1));
+
+ cl_assert(spec != NULL);
+ git_refspec_free(spec);
+}