Commit 6ac91dfe52e857814fc197614dea0dbf672bdc0f
2011-06-29T14:06:18
Hide ".git" directory on Windows upon creation of a non bare repository Directory which name starts with a dot are hidden on Linux platforms. This patch makes libgit2 behaves similarly on Windows.
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69
diff --git a/src/fileops.c b/src/fileops.c
index 3397aad..936a6b4 100644
--- a/src/fileops.c
+++ b/src/fileops.c
@@ -746,4 +746,16 @@ int gitfo_readlink__w32(const char *link, char *target, size_t target_len)
return dwRet;
}
+int gitfo_hide_directory__w32(const char *path)
+{
+ int error;
+
+ error = SetFileAttributes(path, FILE_ATTRIBUTE_HIDDEN) != 0 ?
+ GIT_SUCCESS : GIT_ERROR; /* MSDN states a "non zero" value indicates a success */
+
+ if (error < GIT_SUCCESS)
+ error = git__throw(GIT_EOSERR, "Failed to hide directory '%s'", path);
+
+ return error;
+}
#endif
diff --git a/src/fileops.h b/src/fileops.h
index 953fc73..229f6c4 100644
--- a/src/fileops.h
+++ b/src/fileops.h
@@ -99,6 +99,7 @@ extern int gitfo_mv_force(const char *from, const char *to);
extern int gitfo_lstat__w32(const char *file_name, struct stat *buf);
extern int gitfo_readlink__w32(const char *link, char *target, size_t target_len);
+ extern int gitfo_hide_directory__w32(const char *path);
#else
# define gitfo_lstat(p,b) lstat(p,b)
# define gitfo_readlink(a, b, c) readlink(a, b, c)
diff --git a/src/repository.c b/src/repository.c
index 47884c9..e0927c0 100644
--- a/src/repository.c
+++ b/src/repository.c
@@ -648,6 +648,15 @@ static int repo_init_structure(repo_init *results)
if (gitfo_mkdir_recurs(git_dir, mode))
return git__throw(GIT_ERROR, "Failed to initialize repository structure. Could not mkdir");
+#ifdef GIT_WIN32
+ /* Hides the ".git" directory */
+ if (!results->is_bare) {
+ error = gitfo_hide_directory__w32(git_dir);
+ if (error < GIT_SUCCESS)
+ return git__rethrow(error, "Failed to initialize repository structure");
+ }
+#endif
+
/* Creates the '/objects/info/' directory */
git__joinpath(temp_path, git_dir, GIT_OBJECTS_INFO_DIR);
error = gitfo_mkdir_recurs(temp_path, mode);
diff --git a/tests/t12-repo.c b/tests/t12-repo.c
index 534839b..3b010c8 100644
--- a/tests/t12-repo.c
+++ b/tests/t12-repo.c
@@ -127,6 +127,11 @@ static int ensure_repository_init(
if (git__suffixcmp(repo->path_index, expected_path_index) != 0)
goto cleanup;
+#ifdef GIT_WIN32
+ if ((GetFileAttributes(repo->path_repository) & FILE_ATTRIBUTE_HIDDEN) == 0)
+ goto cleanup;
+#endif
+
if (git_repository_is_bare(repo) == 1)
goto cleanup;
} else if (git_repository_is_bare(repo) == 0)