Commit 6fd00266a8c5c39d98abf2ec899db6f5cbd8874f

Linquize 2014-12-19T23:54:01

COM0 is a valid path, although Windows Explorer does not allow to create this

diff --git a/src/path.c b/src/path.c
index 768a7e1..0bad962 100644
--- a/src/path.c
+++ b/src/path.c
@@ -1254,7 +1254,7 @@ GIT_INLINE(bool) verify_dospath(
 	if (len < last || git__strncasecmp(component, dospath, 3) != 0)
 		return true;
 
-	if (trailing_num && !git__isdigit(component[3]))
+	if (trailing_num && (component[3] < '1' || component[3] > '9'))
 		return true;
 
 	return (len > last &&
diff --git a/tests/path/core.c b/tests/path/core.c
index 85fee82..6c7466e 100644
--- a/tests/path/core.c
+++ b/tests/path/core.c
@@ -233,6 +233,8 @@ void test_path_core__isvalid_dos_paths_withnum(void)
 	cl_assert_equal_b(false, git_path_isvalid(NULL, "com1.asdf\\zippy", GIT_PATH_REJECT_DOS_PATHS));
 	cl_assert_equal_b(false, git_path_isvalid(NULL, "com1:asdf\\foobar", GIT_PATH_REJECT_DOS_PATHS));
 
+	cl_assert_equal_b(true, git_path_isvalid(NULL, "com0", 0));
+	cl_assert_equal_b(true, git_path_isvalid(NULL, "com0", GIT_PATH_REJECT_DOS_PATHS));
 	cl_assert_equal_b(true, git_path_isvalid(NULL, "com10", 0));
 	cl_assert_equal_b(true, git_path_isvalid(NULL, "com10", GIT_PATH_REJECT_DOS_PATHS));
 	cl_assert_equal_b(true, git_path_isvalid(NULL, "comn", GIT_PATH_REJECT_DOS_PATHS));